From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Brandon Maier via buildroot <buildroot@buildroot.org>
Cc: Bernd Kuhls <bernd@kuhls.net>,
"Yann E . MORIN" <yann.morin.1998@free.fr>,
Brandon Maier <brandon.maier@collins.com>,
"Neal J. Buchmeyer" <neal.buchmeyer@collins.com>
Subject: Re: [Buildroot] [PATCH v2 2/2] package/wireless_tools: add option to build ifrename
Date: Sat, 4 Nov 2023 19:18:32 +0100 [thread overview]
Message-ID: <20231104191832.29e6cfc6@windsurf> (raw)
In-Reply-To: <20231024184835.3911-2-brandon.maier@collins.com>
On Tue, 24 Oct 2023 18:48:35 +0000
Brandon Maier via buildroot <buildroot@buildroot.org> wrote:
> diff --git a/package/wireless_tools/Config.in b/package/wireless_tools/Config.in
> index f676e33b57..d7f2ed2381 100644
> --- a/package/wireless_tools/Config.in
> +++ b/package/wireless_tools/Config.in
> @@ -1,6 +1,7 @@
> config BR2_PACKAGE_WIRELESS_TOOLS
> bool "wireless tools"
> select BR2_PACKAGE_WIRELESS_TOOLS_IWCONFIG if \
> + !BR2_PACKAGE_WIRELESS_TOOLS_IFRENAME && \
> !BR2_PACKAGE_WIRELESS_TOOLS_LIB
> help
> A collection of tools to configure wireless lan cards.
> @@ -15,6 +16,11 @@ config BR2_PACKAGE_WIRELESS_TOOLS_IWCONFIG
> Build and install the iwconfig, iwlist, iwspy, iwpriv, and
> iwgetid tools.
>
> +config BR2_PACKAGE_WIRELESS_TOOLS_IFRENAME
> + bool "Add ifrename"
Changed to:
bool "Install ifrename"
> define WIRELESS_TOOLS_INSTALL_TARGET_CMDS
> - $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) PREFIX="$(TARGET_DIR)" LDCONFIG=/bin/true \
> - $(WIRELESS_TOOLS_INSTALL_TARGETS)
> + $(if $(WIRELESS_TOOLS_INSTALL_TARGETS),
> + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) PREFIX="$(TARGET_DIR)" \
> + LDCONFIG=/bin/true $(WIRELESS_TOOLS_INSTALL_TARGETS))
Indented this last line with one more tab.
And applied. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-11-04 18:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 20:33 [Buildroot] [PATCH 1/1] package/wireless_tools: add option to build ifrename Brandon Maier via buildroot
2023-10-22 18:47 ` Yann E. MORIN
2023-10-24 18:52 ` Maier, Brandon L Collins via buildroot
2023-10-24 18:48 ` [Buildroot] [PATCH v2 1/2] package/wireless_tools: make 'iwconfig' tool optional Brandon Maier via buildroot
2023-10-24 18:48 ` [Buildroot] [PATCH v2 2/2] package/wireless_tools: add option to build ifrename Brandon Maier via buildroot
2023-11-04 18:18 ` Thomas Petazzoni via buildroot [this message]
2023-11-04 18:17 ` [Buildroot] [PATCH v2 1/2] package/wireless_tools: make 'iwconfig' tool optional Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231104191832.29e6cfc6@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=brandon.maier@collins.com \
--cc=neal.buchmeyer@collins.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.