All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Francois Dugast <francois.dugast.foss@gmail.com>
Cc: Michel Stempin <michel.stempin@wanadoo.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] board/licheepi_zero: move board files to their own directory
Date: Sat, 4 Nov 2023 19:38:18 +0100	[thread overview]
Message-ID: <20231104193818.519472c7@windsurf> (raw)
In-Reply-To: <20231027114700.1904-1-francois.dugast.foss@gmail.com>

Hello François,

On Fri, 27 Oct 2023 13:46:59 +0200
Francois Dugast <francois.dugast.foss@gmail.com> wrote:

> Group files for board licheepi_zero under a new directory. This is
> to prepare for a new board also coming to the licheepi directory.
> 
> Signed-off-by: Francois Dugast <francois.dugast.foss@gmail.com>
> ---
>  board/licheepi/{ => licheepi_zero}/boot.cmd     | 0
>  board/licheepi/{ => licheepi_zero}/genimage.cfg | 0
>  board/licheepi/{ => licheepi_zero}/readme.txt   | 0

Could you rename the folder to licheepi-zero instead of licheepi_zero?

I would have done it myself while applying if there were no other
issues with the patch series, but I have comments on PATCH 2/2.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2023-11-04 18:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-27 11:46 [Buildroot] [PATCH 1/2] board/licheepi_zero: move board files to their own directory Francois Dugast
2023-10-27 11:47 ` [Buildroot] [PATCH 2/2] board/licheepi/licheepi_nano: new board Francois Dugast
2023-10-29 18:49   ` Yann E. MORIN
2023-10-29 18:45 ` [Buildroot] [PATCH 1/2] board/licheepi_zero: move board files to their own directory Yann E. MORIN
2023-11-04 18:38 ` Thomas Petazzoni via buildroot [this message]
2023-11-04 18:46   ` Thomas Petazzoni via buildroot
  -- strict thread matches above, loose matches on Subject: below --
2023-10-04 20:07 Francois Dugast

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231104193818.519472c7@windsurf \
    --to=buildroot@buildroot.org \
    --cc=francois.dugast.foss@gmail.com \
    --cc=michel.stempin@wanadoo.fr \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.