All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Stefan Agner <stefan@agner.ch>
Cc: christian@aperture.us, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/containerd: add control for additional build tags
Date: Sat, 4 Nov 2023 21:36:04 +0100	[thread overview]
Message-ID: <20231104213604.056218ed@windsurf> (raw)
In-Reply-To: <4642abb656bb8e63ff759d6f2ab6eafeb2e3d39d.1696436249.git.stefan@agner.ch>

On Wed,  4 Oct 2023 18:17:36 +0200
Stefan Agner <stefan@agner.ch> wrote:

> +config BR2_PACKAGE_CONTAINERD_DRIVER_DEVMAPPER
> +	bool "devmapper snapshot driver"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # lvm2
> +	depends on BR2_USE_MMU # lvm2
> +	depends on !BR2_STATIC_LIBS # lvm2
> +	select BR2_PACKAGE_LVM2
> +	help
> +	  Build the devmapper snapshot driver for containerd.

I've added a Config.in comment here for the dependencies.

> +config BR2_PACKAGE_CONTAINERD_DRIVER_ZFS
> +	bool "zfs snapshot driver"
> +	depends on BR2_LINUX_KERNEL # zfs
> +	depends on BR2_PACKAGE_HAS_UDEV # zfs

I've propagated all "depends on" of zfs here.

> +	select BR2_PACKAGE_ZFS
> +	help
> +	  Build the zfs snapshot driver for containerd.

I've added a Config.in comment here for the dependencies.

> +
> +config BR2_PACKAGE_CONTAINERD_CRI
> +	bool "Build Kubernetes CRI support"

Dropped the "Build" word since none of the other options in this
package have this.

Applied, thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2023-11-04 20:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-04 16:17 [Buildroot] [PATCH] package/containerd: add control for additional build tags Stefan Agner
2023-10-04 17:38 ` Christian Stewart via buildroot
2023-11-04 20:36 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231104213604.056218ed@windsurf \
    --to=buildroot@buildroot.org \
    --cc=christian@aperture.us \
    --cc=stefan@agner.ch \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.