Re: [Buildroot] [PATCH] package/libcanberra: new package

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Takumi Takahashi <takumiiinn@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/libcanberra: new package
Date: Sat, 4 Nov 2023 23:07:31 +0100	[thread overview]
Message-ID: <20231104230731.0f7591a7@windsurf> (raw)
In-Reply-To: <20231003124004.983018-1-takumiiinn@gmail.com>

Hello,

Thanks for your contribution! I applied it, after adjusting a few
things, see below.

On Tue,  3 Oct 2023 21:40:03 +0900
Takumi Takahashi <takumiiinn@gmail.com> wrote:

> This package defines a simple abstract interface for playing event sounds.
> It is mainly used by desktop applications such as GDM and GNOME Session.
> 
> http://0pointer.de/lennart/projects/libcanberra/
> 
> Signed-off-by: Takumi Takahashi <takumiiinn@gmail.com>
> ---
>  package/Config.in                    |  1 +
>  package/libcanberra/Config.in        | 17 ++++++++
>  package/libcanberra/libcanberra.hash |  3 ++
>  package/libcanberra/libcanberra.mk   | 59 ++++++++++++++++++++++++++++
>  4 files changed, 80 insertions(+)

An entry in the DEVELOPERS file was missing.

> +comment "libcanberra needs a alsa-lib or pulseaudio or gstreamer"
> +	depends on !BR2_PACKAGE_ALSA_LIB && !BR2_PACKAGE_PULSEAUDIO && !BR2_PACKAGE_GSTREAMER1

This is not really useful, as it doesn't prevent a build failure. So
instead, I've added...

> +
> +config BR2_PACKAGE_LIBCANBERRA
> +	bool "libcanberra"
> +	depends on BR2_USE_WCHAR
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on !BR2_STATIC_LIBS

This:

+       # We need at least one audio backend
+       select BR2_PACKAGE_ALSA_LIB if \
+              !BR2_PACKAGE_PULSEAUDIO && \
+              !BR2_PACKAGE_GSTREAMER1

> +sha256  c2b671e67e0c288a69fc33dc1b6f1b534d07882c2aceed37004bf48c601afa72  libcanberra-0.30.tar.xz
> +sha256  a9bdde5616ecdd1e980b44f360600ee8783b1f99b8cc83a2beb163a0a390e861  LGPL
> diff --git a/package/libcanberra/libcanberra.mk b/package/libcanberra/libcanberra.mk
> new file mode 100644
> index 0000000000..1eadcb571b
> --- /dev/null
> +++ b/package/libcanberra/libcanberra.mk
> @@ -0,0 +1,59 @@
> +################################################################################
> +#
> +# libcanberra
> +#
> +################################################################################
> +
> +LIBCANBERRA_VERSION = 0.30
> +LIBCANBERRA_SOURCE = libcanberra-$(LIBCANBERRA_VERSION).tar.xz
> +LIBCANBERRA_SITE = http://0pointer.de/lennart/projects/libcanberra
> +LIBCANBERRA_LICENSE = LGPL-2.1+
> +LIBCANBERRA_LICENSE_FILES = LICENSE

This was incorrect: the file is named "LGPL". I only realized this
after pushing, so I fixed up in a follow-up commit.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot