From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF8D4C8F7 for ; Mon, 6 Nov 2023 07:30:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A86093 for ; Sun, 5 Nov 2023 23:30:00 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 388E36732D; Mon, 6 Nov 2023 08:29:57 +0100 (CET) Date: Mon, 6 Nov 2023 08:29:57 +0100 From: Christoph Hellwig To: Christian Brauner Cc: Dave Chinner , Christoph Hellwig , Jan Kara , "Darrick J. Wong" , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 1/2] fs: remove dead check Message-ID: <20231106072957.GA17547@lst.de> References: <20231104-vfs-multi-device-freeze-v2-0-5b5b69626eac@kernel.org> <20231104-vfs-multi-device-freeze-v2-1-5b5b69626eac@kernel.org> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231104-vfs-multi-device-freeze-v2-1-5b5b69626eac@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) On Sat, Nov 04, 2023 at 03:00:12PM +0100, Christian Brauner wrote: > Above we call super_lock_excl() which waits until the superblock is > SB_BORN and since SB_BORN is never unset once set this check can never > fire. Plus, we also hold an active reference at this point already so > this superblock can't even be shutdown. Looks good: Reviewed-by: Christoph Hellwig