From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: Chao Ye <cye@redhat.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] ci: add centos stream support
Date: Mon, 6 Nov 2023 11:40:23 +0100 [thread overview]
Message-ID: <20231106104023.GA1236692@pevik> (raw)
In-Reply-To: <CAEemH2ewUHBC17LL+4OXd8AZqciGrRqo4Ty+Hik2KcXP+t4fNA@mail.gmail.com>
> Hi Petr,
> On Fri, Nov 3, 2023 at 5:14 PM Petr Vorel <pvorel@suse.cz> wrote:
> > > Hi Petr,
> > > On Thu, Nov 2, 2023 at 5:21 PM Petr Vorel <pvorel@suse.cz> wrote:
> > > > Hi Li,
> > > > > This is base on Peter's patch:
> > > > > CI: ReAplace CentOS 7 with openSUSE Leap 42.2, Ubuntu xenial
> > > > > Ci: https://github.com/wangli5665/ltp/actions/runs/6729379565
> > > > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > > Thanks!
> > > > ATM we have 18 jobs, IMHO we should not add more without removing
> > others
> > > > just to
> > > > have reasonable CI runtime.
> > > Your concern makes sense, but I have no idea which one could be removed.
> > I wonder if just adding CentOS 9 would be enough. Because in CI we test
> > just
> > compilation. The point of the public CI is to test the oldest distros,
> > newest
> > distros and something in between, that should cover the most of compilation
> > problems (no need to test *all* used distros to be safe).
> > But sure, both can stay if you want. The runtime is still reasonable.
> > NOTE: I did not care much in case of iputils, which have much faster build
> > than
> > LTP.
> > If we want to add both CentOS 8 and 9, we could remove some of
> > debian:oldstable (bullseye)
> > (similar kernel).
> > And, we could add just openSUSE Leap 42.2, which has older glibc and gcc
> > than
> > Ubuntu 16.04 LTS xenial. For sure there are more people which use xenial
> > than
> > old Leap 42.2, but as I said, the goal is to test the oldest distro we
> > maintainers really care about (and do not have extra work for nothing,
> > which is
> > IMHO keeping CentOS 7 compilable).
> > WDYT?
> Your explanation is quite useful, thanks!
> I'm fine to remove the CentOS8 build in this patch,
> should I resent the new patch or push it directly?
You can push it directly. If it does not apply, feel free to push my change
first. I'll post a note about keeping only openSUSE Leap 42.2 in the patchset.
Acked-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-11-06 10:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 7:20 [LTP] [PATCH] ci: add centos stream support Li Wang
2023-11-02 9:21 ` Petr Vorel
2023-11-02 9:27 ` Li Wang
2023-11-03 9:14 ` Petr Vorel
2023-11-06 9:44 ` Li Wang
2023-11-06 10:40 ` Petr Vorel [this message]
2023-11-06 10:58 ` Li Wang
2023-11-06 11:00 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231106104023.GA1236692@pevik \
--to=pvorel@suse.cz \
--cc=cye@redhat.com \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.