Re: [PATCH v3 03/12] iommu/amd: Introduce per device DTE update function

[Jason Gunthorpe <jgg@ziepe.ca>]

On Mon, Oct 16, 2023 at 10:43:42AM +0000, Vasant Hegde wrote:

> @@ -1679,6 +1680,24 @@ static void domain_flush_np_cache(struct protection_domain *domain,
>  }
>  
>  
> +/* Update and flush DTE for the given device */
> +void amd_iommu_dev_update_dte(struct iommu_dev_data *dev_data, bool set)
> +{
> +	struct amd_iommu *iommu = get_amd_iommu_from_dev(dev_data->dev);
> +
> +	if (!iommu)
> +		return;

Can't be null

> +	if (set)
> +		set_dte_entry(iommu, dev_data);
> +	else
> +		clear_dte_entry(iommu, dev_data->devid);
> +
> +	clone_aliases(iommu, dev_data->dev);
> +
> +	device_flush_dte(dev_data);

This should take in iommu too..

> +}

Makes sense though

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

My other note was to basically do this:

void amd_iommu_dev_update_dte(struct iommu_dev_data *dev_data, const struct amd_dte *dte)

Where the caller functions would generate the DTE content instead of
having ste_dte_entry try to reverse engineer which caller is calling
it.

Jason