From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5D84C4167D for ; Tue, 7 Nov 2023 15:48:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344258AbjKGPso (ORCPT ); Tue, 7 Nov 2023 10:48:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344249AbjKGPsH (ORCPT ); Tue, 7 Nov 2023 10:48:07 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C906F10E9; Tue, 7 Nov 2023 07:47:48 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44CFBC433CA; Tue, 7 Nov 2023 15:47:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699372068; bh=bpz0U3LZxSfFLxq8A9lqCNLA2l/RdLM6YJC2tsAEoXI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eUKgFJ9skIOV7Q8YqlulEIDSOHYr8tNhi8xDZVFIlIps47FSbPIr3XlNTQohA/LRF H6d855CoLDQ1MgPP3NmJAuD566H5U0dsAmjhK4NX9xii2ryIC6WmoIgPB3yg58Zk+B HalvNsK3YhSamSmNEv/ImwY8FKT1ftVefkayaB83/KoNG6TqTvsSpRGwBjDaXlRezM YuJjYv3fKd1JXOPBhMzZFT/pvvCVFoUU19oin5UBRt6unTsmMiLPoTj+9QNsmWAGPv QE/Cjvu6dHSRQBMvLOt8bl0QzPVVzbtDNR6Zh7JonwzG7lC13TfTdlUK33En9nTmFU 6FpvjCncvMjQg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Bjorn Helgaas , Jonathan Cameron , Sasha Levin , thomas.petazzoni@bootlin.com, pali@kernel.org, lpieralisi@kernel.org, kw@linux.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 6.6 21/36] PCI: mvebu: Use FIELD_PREP() with Link Width Date: Tue, 7 Nov 2023 10:46:03 -0500 Message-ID: <20231107154654.3765336-21-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231107154654.3765336-1-sashal@kernel.org> References: <20231107154654.3765336-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Ilpo Järvinen [ Upstream commit 408599ec561ad5862cda4f107626009f6fa97a74 ] mvebu_pcie_setup_hw() setups the Maximum Link Width field in the Link Capabilities registers using an open-coded variant of FIELD_PREP() with a literal in shift. Improve readability by using FIELD_PREP(PCI_EXP_LNKCAP_MLW, ...). Link: https://lore.kernel.org/r/20230919125648.1920-6-ilpo.jarvinen@linux.intel.com Signed-off-by: Ilpo Järvinen Signed-off-by: Bjorn Helgaas Reviewed-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/pci/controller/pci-mvebu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c index 60810a1fbfb75..29fe09c99e7d9 100644 --- a/drivers/pci/controller/pci-mvebu.c +++ b/drivers/pci/controller/pci-mvebu.c @@ -264,7 +264,7 @@ static void mvebu_pcie_setup_hw(struct mvebu_pcie_port *port) */ lnkcap = mvebu_readl(port, PCIE_CAP_PCIEXP + PCI_EXP_LNKCAP); lnkcap &= ~PCI_EXP_LNKCAP_MLW; - lnkcap |= (port->is_x4 ? 4 : 1) << 4; + lnkcap |= FIELD_PREP(PCI_EXP_LNKCAP_MLW, port->is_x4 ? 4 : 1); mvebu_writel(port, lnkcap, PCIE_CAP_PCIEXP + PCI_EXP_LNKCAP); /* Disable Root Bridge I/O space, memory space and bus mastering. */ -- 2.42.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26497C4167D for ; Tue, 7 Nov 2023 15:48:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cN5tWLaVKJXwkwHe695PtVaAmDv+MRYqxhUoOKPlxAA=; b=S/y8XCXI/asSIL QC6S4+L6reejAFnXuDLu2qGtsyYJN31XDww9vVmUSYbsjPvefOAytxq5lIXONBBc9DWEBqPuIR5w0 Q4ZRU3ovDD0cpfgYUaHg0BOBXrLjUI8RvlWb64ldVtYOCsDCL5RY8vEsvc3GJ7mVWUTwdt7LYDZKG 3tZEPIDITaV7ZvNCrdvb71KaV8qFcyL8lqvMxwwAs5ygTPbnOPhcajYD8o8YOZH2OAlxQklxhWbpB 2oga1iSRNqzYwlxMGEw2vRoH5KohVyrF0MPXPx5yX+1E3BpgdT3uc8v+2zZd76pdKgx8MGy27co1Z hP6AinKDaFoeHqiJgvFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0OJ0-001t0j-03; Tue, 07 Nov 2023 15:47:54 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0OIx-001sye-2L for linux-arm-kernel@lists.infradead.org; Tue, 07 Nov 2023 15:47:53 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CBD756125A; Tue, 7 Nov 2023 15:47:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44CFBC433CA; Tue, 7 Nov 2023 15:47:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699372068; bh=bpz0U3LZxSfFLxq8A9lqCNLA2l/RdLM6YJC2tsAEoXI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eUKgFJ9skIOV7Q8YqlulEIDSOHYr8tNhi8xDZVFIlIps47FSbPIr3XlNTQohA/LRF H6d855CoLDQ1MgPP3NmJAuD566H5U0dsAmjhK4NX9xii2ryIC6WmoIgPB3yg58Zk+B HalvNsK3YhSamSmNEv/ImwY8FKT1ftVefkayaB83/KoNG6TqTvsSpRGwBjDaXlRezM YuJjYv3fKd1JXOPBhMzZFT/pvvCVFoUU19oin5UBRt6unTsmMiLPoTj+9QNsmWAGPv QE/Cjvu6dHSRQBMvLOt8bl0QzPVVzbtDNR6Zh7JonwzG7lC13TfTdlUK33En9nTmFU 6FpvjCncvMjQg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Bjorn Helgaas , Jonathan Cameron , Sasha Levin , thomas.petazzoni@bootlin.com, pali@kernel.org, lpieralisi@kernel.org, kw@linux.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 6.6 21/36] PCI: mvebu: Use FIELD_PREP() with Link Width Date: Tue, 7 Nov 2023 10:46:03 -0500 Message-ID: <20231107154654.3765336-21-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231107154654.3765336-1-sashal@kernel.org> References: <20231107154654.3765336-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231107_074751_807416_D7A533E9 X-CRM114-Status: GOOD ( 10.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RnJvbTogSWxwbyBKw6RydmluZW4gPGlscG8uamFydmluZW5AbGludXguaW50ZWwuY29tPgoKWyBV cHN0cmVhbSBjb21taXQgNDA4NTk5ZWM1NjFhZDU4NjJjZGE0ZjEwNzYyNjAwOWY2ZmE5N2E3NCBd CgptdmVidV9wY2llX3NldHVwX2h3KCkgc2V0dXBzIHRoZSBNYXhpbXVtIExpbmsgV2lkdGggZmll bGQgaW4gdGhlIExpbmsKQ2FwYWJpbGl0aWVzIHJlZ2lzdGVycyB1c2luZyBhbiBvcGVuLWNvZGVk IHZhcmlhbnQgb2YgRklFTERfUFJFUCgpIHdpdGgKYSBsaXRlcmFsIGluIHNoaWZ0LiBJbXByb3Zl IHJlYWRhYmlsaXR5IGJ5IHVzaW5nCkZJRUxEX1BSRVAoUENJX0VYUF9MTktDQVBfTUxXLCAuLi4p LgoKTGluazogaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvci8yMDIzMDkxOTEyNTY0OC4xOTIwLTYt aWxwby5qYXJ2aW5lbkBsaW51eC5pbnRlbC5jb20KU2lnbmVkLW9mZi1ieTogSWxwbyBKw6Rydmlu ZW4gPGlscG8uamFydmluZW5AbGludXguaW50ZWwuY29tPgpTaWduZWQtb2ZmLWJ5OiBCam9ybiBI ZWxnYWFzIDxiaGVsZ2Fhc0Bnb29nbGUuY29tPgpSZXZpZXdlZC1ieTogSm9uYXRoYW4gQ2FtZXJv biA8Sm9uYXRoYW4uQ2FtZXJvbkBodWF3ZWkuY29tPgpTaWduZWQtb2ZmLWJ5OiBTYXNoYSBMZXZp biA8c2FzaGFsQGtlcm5lbC5vcmc+Ci0tLQogZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktbXZl YnUuYyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigt KQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLW12ZWJ1LmMgYi9kcml2 ZXJzL3BjaS9jb250cm9sbGVyL3BjaS1tdmVidS5jCmluZGV4IDYwODEwYTFmYmZiNzUuLjI5ZmUw OWM5OWU3ZDkgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLW12ZWJ1LmMK KysrIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktbXZlYnUuYwpAQCAtMjY0LDcgKzI2NCw3 IEBAIHN0YXRpYyB2b2lkIG12ZWJ1X3BjaWVfc2V0dXBfaHcoc3RydWN0IG12ZWJ1X3BjaWVfcG9y dCAqcG9ydCkKIAkgKi8KIAlsbmtjYXAgPSBtdmVidV9yZWFkbChwb3J0LCBQQ0lFX0NBUF9QQ0lF WFAgKyBQQ0lfRVhQX0xOS0NBUCk7CiAJbG5rY2FwICY9IH5QQ0lfRVhQX0xOS0NBUF9NTFc7Ci0J bG5rY2FwIHw9IChwb3J0LT5pc194NCA/IDQgOiAxKSA8PCA0OworCWxua2NhcCB8PSBGSUVMRF9Q UkVQKFBDSV9FWFBfTE5LQ0FQX01MVywgcG9ydC0+aXNfeDQgPyA0IDogMSk7CiAJbXZlYnVfd3Jp dGVsKHBvcnQsIGxua2NhcCwgUENJRV9DQVBfUENJRVhQICsgUENJX0VYUF9MTktDQVApOwogCiAJ LyogRGlzYWJsZSBSb290IEJyaWRnZSBJL08gc3BhY2UsIG1lbW9yeSBzcGFjZSBhbmQgYnVzIG1h c3RlcmluZy4gKi8KLS0gCjIuNDIuMAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK