From: "Michael S. Tsirkin" <mst@redhat.com>
To: ankita@nvidia.com
Cc: jgg@nvidia.com, alex.williamson@redhat.com, clg@redhat.com,
shannon.zhaosl@gmail.com, peter.maydell@linaro.org,
ani@anisinha.ca, berrange@redhat.com, eduardo@habkost.net,
imammedo@redhat.com, eblake@redhat.com, armbru@redhat.com,
david@redhat.com, gshan@redhat.com, Jonathan.Cameron@huawei.com,
aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com,
targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com,
dnigam@nvidia.com, udhoke@nvidia.com, qemu-arm@nongnu.org,
qemu-devel@nongnu.org
Subject: Re: [PATCH v3 2/2] hw/acpi: Implement the SRAT GI affinity structure
Date: Tue, 7 Nov 2023 17:25:11 -0500 [thread overview]
Message-ID: <20231107172318-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20231107190039.19434-3-ankita@nvidia.com>
On Wed, Nov 08, 2023 at 12:30:39AM +0530, ankita@nvidia.com wrote:
> + for (l = gi->nodelist; l; l = l->next) {
> + PCIDeviceHandle dev_handle = {0};
> + PCIDevice *pci_dev = PCI_DEVICE(o);
> + dev_handle.bdf = PCI_BUILD_BDF(pci_bus_num(pci_get_bus(pci_dev)),
> + pci_dev->devfn);
> + build_srat_generic_pci_initiator_affinity(table_data,
> + l->value, &dev_handle);
> + }
> + }
if you never initialize segment then I don't see why have it.
It's just the bdf, just pass that as parameter no need for a struct.
--
MST
next prev parent reply other threads:[~2023-11-07 22:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 19:00 [PATCH v3 0/2] vfio/nvgpu: Add vfio pci variant module for grace hopper ankita
2023-11-07 19:00 ` [PATCH v3 1/2] qom: new object to associate device to numa node ankita
2023-11-15 13:59 ` Markus Armbruster
2023-11-07 19:00 ` [PATCH v3 2/2] hw/acpi: Implement the SRAT GI affinity structure ankita
2023-11-07 21:33 ` Alex Williamson
2023-11-07 22:20 ` Michael S. Tsirkin
2023-11-07 22:25 ` Michael S. Tsirkin [this message]
2023-11-13 11:14 ` Ankit Agrawal
2023-11-13 14:18 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231107172318-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=acurrid@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=ani@anisinha.ca \
--cc=aniketa@nvidia.com \
--cc=ankita@nvidia.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=cjia@nvidia.com \
--cc=clg@redhat.com \
--cc=david@redhat.com \
--cc=dnigam@nvidia.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=gshan@redhat.com \
--cc=imammedo@redhat.com \
--cc=jgg@nvidia.com \
--cc=kwankhede@nvidia.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=targupta@nvidia.com \
--cc=udhoke@nvidia.com \
--cc=vsethi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.