All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Cleber Rosa" <crosa@redhat.com>, "John Snow" <jsnow@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PULL 3/5] audio: don't abort on f32 audio format in wav backend
Date: Tue,  7 Nov 2023 19:08:15 +0000	[thread overview]
Message-ID: <20231107190817.1607710-4-berrange@redhat.com> (raw)
In-Reply-To: <20231107190817.1607710-1-berrange@redhat.com>

Print a debug message as is done for other unsupported audio formats
to give the user the chance to understand their mistake.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 audio/wavaudio.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/audio/wavaudio.c b/audio/wavaudio.c
index ea20fed0cc..a8798a1c42 100644
--- a/audio/wavaudio.c
+++ b/audio/wavaudio.c
@@ -97,6 +97,10 @@ static int wav_init_out(HWVoiceOut *hw, struct audsettings *as,
         dolog ("WAVE files can not handle 32bit formats\n");
         return -1;
 
+    case AUDIO_FORMAT_F32:
+        dolog("WAVE files can not handle float formats\n");
+        return -1;
+
     default:
         abort();
     }
-- 
2.41.0



  parent reply	other threads:[~2023-11-07 19:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-07 19:08 [PULL 0/5] Misc fixes patches Daniel P. Berrangé
2023-11-07 19:08 ` [PULL 1/5] crypto/rsakey-builtin.c.inc: Clean up two error paths Daniel P. Berrangé
2023-11-07 19:08 ` [PULL 2/5] io: Stop appending -listen to net listeners Daniel P. Berrangé
2023-11-07 19:08 ` Daniel P. Berrangé [this message]
2023-11-07 19:08 ` [PULL 4/5] MAINTAINERS: update libvirt devel mailing list address Daniel P. Berrangé
2023-11-07 20:16   ` Philippe Mathieu-Daudé
2023-11-07 19:08 ` [PULL 5/5] scripts/cpu-x86-uarch-abi.py: Fix parameter error of cmd Daniel P. Berrangé
2023-11-08 14:20 ` [PULL 0/5] Misc fixes patches Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231107190817.1607710-4-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.