From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Martin Bark <martin@barkynet.com>,
Daniel Price <daniel.price@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/nodejs: fix additional modules installation
Date: Tue, 7 Nov 2023 22:40:57 +0100 [thread overview]
Message-ID: <20231107214057.GM229059@scaer> (raw)
In-Reply-To: <20231031090114.618913-1-giulio.benetti@benettiengineering.com>
Giulio, All,
On 2023-10-31 10:01 +0100, Giulio Benetti spake thusly:
> At the moment the npm_config_nodedir is set to the build directory but
> npm nodedir must be the one on target to find the expected files. So let's
> set npm_config_nodedir to $(TARGET_DIR)/usr.
>
> Fixes:
> https://bugs.busybox.net/show_bug.cgi?id=15826
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
I have drastically extended the commit log to explain what nodedir is,
and why we decided to set it to...
> ---
> package/nodejs/nodejs.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
> index 2a8c570932..8f86413049 100644
> --- a/package/nodejs/nodejs.mk
> +++ b/package/nodejs/nodejs.mk
> @@ -20,7 +20,7 @@ NODEJS_BIN_ENV = $(TARGET_CONFIGURE_OPTS) \
> npm_config_arch=$(NODEJS_CPU) \
> npm_config_target_arch=$(NODEJS_CPU) \
> npm_config_build_from_source=true \
> - npm_config_nodedir=$(BUILD_DIR)/nodejs-$(NODEJS_VERSION) \
> + npm_config_nodedir=$(TARGET_DIR)/usr \
... STAGING_DIR, not TARGET_DIR.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> npm_config_prefix=$(TARGET_DIR)/usr \
> npm_config_cache=$(BUILD_DIR)/.npm-cache
>
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-11-07 21:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 9:01 [Buildroot] [PATCH] package/nodejs: fix additional modules installation Giulio Benetti
2023-11-06 19:12 ` Marcus Hoffmann via buildroot
2023-11-07 21:51 ` Yann E. MORIN
2023-11-07 15:15 ` Yann E. MORIN
2023-11-07 17:27 ` Yann E. MORIN
2023-11-07 21:40 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231107214057.GM229059@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=daniel.price@gmail.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=martin@barkynet.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.