From: Mike Kravetz <mike.kravetz@oracle.com>
To: Edward Adam Davis <eadavis@qq.com>
Cc: riel@surriel.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
llvm@lists.linux.dev, muchun.song@linux.dev, nathan@kernel.org,
ndesaulniers@google.com,
syzbot+6ada951e7c0f7bc8a71e@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com, trix@redhat.com
Subject: Re: [PATCH] mm/hugetlb: fix null ptr defer in hugetlb_vma_lock_write
Date: Tue, 7 Nov 2023 19:22:46 -0800 [thread overview]
Message-ID: <20231108032246.GC41505@monkey> (raw)
In-Reply-To: <tencent_164A247533766D667C3D873798968236C409@qq.com>
Hello Edward,
Do you plan on following up with a new version of the patch?
My suggestion would be:
- Move __vma_private_lock into hugetlb.c as suggeted by Rik.
- Change __vma_private_lock to check for NULL resv_map even if low bit
flags are set as well as HPAGE_RESV_OWNER.
--
Mike Kravetz
next prev parent reply other threads:[~2023-11-08 3:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 9:27 [syzbot] [mm?] general protection fault in hugetlb_vma_lock_write syzbot
2023-10-31 18:38 ` Rik van Riel
2023-11-02 12:15 ` Aleksandr Nogikh
2023-11-01 6:36 ` [PATCH] mm/hugetlb: fix null ptr defer " Edward Adam Davis
2023-11-01 14:27 ` Rik van Riel
2023-11-02 12:58 ` Edward Adam Davis
2023-11-02 23:29 ` kernel test robot
2023-11-02 23:29 ` kernel test robot
2023-11-03 0:56 ` Rik van Riel
2023-11-03 1:26 ` kernel test robot
2023-11-03 2:24 ` Mike Kravetz
2023-11-03 2:28 ` Mike Kravetz
2023-11-03 2:37 ` Mike Kravetz
2023-11-03 3:15 ` Rik van Riel
2023-11-03 4:31 ` Mike Kravetz
2023-11-08 3:22 ` Mike Kravetz [this message]
2023-11-02 13:46 ` Yin, Fengwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231108032246.GC41505@monkey \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=eadavis@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=muchun.song@linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=riel@surriel.com \
--cc=syzbot+6ada951e7c0f7bc8a71e@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.