Re: [PATCH 02/22] fb: atmel_lcdfb: Stop using platform_driver_probe()

[kernel test robot <lkp@intel.com>]

Hi Uwe,

kernel test robot noticed the following build errors:

[auto build test ERROR on 3ff7a5781ceee3befb9224d29cef6e6a4766c5fe]

url:    https://github.com/intel-lab-lkp/linux/commits/Uwe-Kleine-K-nig/fb-amifb-Stop-using-platform_driver_probe/20231107-173128
base:   3ff7a5781ceee3befb9224d29cef6e6a4766c5fe
patch link:    https://lore.kernel.org/r/20231107091740.3924258-3-u.kleine-koenig%40pengutronix.de
patch subject: [PATCH 02/22] fb: atmel_lcdfb: Stop using platform_driver_probe()
config: arc-randconfig-002-20231108 (https://download.01.org/0day-ci/archive/20231108/202311080350.HLgrpabe-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231108/202311080350.HLgrpabe-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311080350.HLgrpabe-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

>> drivers/video/fbdev/atmel_lcdfb.c:1314:44: error: macro "module_platform_driver" passed 2 arguments, but takes just 1
    1314 | module_platform_driver(atmel_lcdfb_driver, );
         |                                            ^
   In file included from drivers/video/fbdev/atmel_lcdfb.c:12:
   include/linux/platform_device.h:302: note: macro "module_platform_driver" defined here
     302 | #define module_platform_driver(__platform_driver) \
         | 
>> drivers/video/fbdev/atmel_lcdfb.c:1314:1: warning: data definition has no type or storage class
    1314 | module_platform_driver(atmel_lcdfb_driver, );
         | ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/video/fbdev/atmel_lcdfb.c:1314:1: error: type defaults to 'int' in declaration of 'module_platform_driver' [-Werror=implicit-int]
>> drivers/video/fbdev/atmel_lcdfb.c:1303:31: warning: 'atmel_lcdfb_driver' defined but not used [-Wunused-variable]
    1303 | static struct platform_driver atmel_lcdfb_driver = {
         |                               ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/module_platform_driver +1314 drivers/video/fbdev/atmel_lcdfb.c

  1302	
> 1303	static struct platform_driver atmel_lcdfb_driver = {
  1304		.probe		= atmel_lcdfb_probe,
  1305		.remove		= atmel_lcdfb_remove,
  1306		.suspend	= atmel_lcdfb_suspend,
  1307		.resume		= atmel_lcdfb_resume,
  1308		.driver		= {
  1309			.name	= "atmel_lcdfb",
  1310			.of_match_table	= atmel_lcdfb_dt_ids,
  1311		},
  1312	};
  1313	
> 1314	module_platform_driver(atmel_lcdfb_driver, );
  1315	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki