All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com
Subject: fs/bcachefs/buckets.c:675:61: sparse: sparse: invalid access past the end of 'p' (4 8)
Date: Wed, 8 Nov 2023 06:45:13 +0800	[thread overview]
Message-ID: <202311080541.hrumYImb-lkp@intel.com> (raw)

:::::: 
:::::: Manual check reason: "low confidence static check warning: fs/bcachefs/buckets.c:675:61: sparse: sparse: invalid access past the end of 'p' (4 8)"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Kent Overstreet <kmo@daterainc.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   13d88ac54ddd1011b6e94443958e798aa06eb835
commit: cd575ddf57af004913ff5a994aa5f3203216fa68 bcachefs: Erasure coding
date:   2 weeks ago
:::::: branch date: 66 minutes ago
:::::: commit date: 2 weeks ago
config: powerpc-randconfig-r113-20231106 (https://download.01.org/0day-ci/archive/20231108/202311080541.hrumYImb-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231108/202311080541.hrumYImb-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202311080541.hrumYImb-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> fs/bcachefs/buckets.c:675:61: sparse: sparse: invalid access past the end of 'p' (4 8)
   fs/bcachefs/buckets.c: note: in included file (through fs/bcachefs/super.h, fs/bcachefs/buckets.h):
   fs/bcachefs/extents.h:273:44: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le32 [usertype] @@     got unsigned int const [usertype] csum @@
   fs/bcachefs/extents.h:273:44: sparse:     expected restricted __le32 [usertype]
   fs/bcachefs/extents.h:273:44: sparse:     got unsigned int const [usertype] csum
   fs/bcachefs/extents.h:287:44: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] @@     got unsigned long long const [usertype] csum_hi:16 @@
   fs/bcachefs/extents.h:287:44: sparse:     expected restricted __le16 [usertype]
   fs/bcachefs/extents.h:287:44: sparse:     got unsigned long long const [usertype] csum_hi:16
   fs/bcachefs/extents.h:273:44: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le32 [usertype] @@     got unsigned int const [usertype] csum @@
   fs/bcachefs/extents.h:273:44: sparse:     expected restricted __le32 [usertype]
   fs/bcachefs/extents.h:273:44: sparse:     got unsigned int const [usertype] csum
   fs/bcachefs/extents.h:287:44: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] @@     got unsigned long long const [usertype] csum_hi:16 @@
   fs/bcachefs/extents.h:287:44: sparse:     expected restricted __le16 [usertype]
   fs/bcachefs/extents.h:287:44: sparse:     got unsigned long long const [usertype] csum_hi:16

vim +/p +675 fs/bcachefs/buckets.c

1c6fdbd8f2465d Kent Overstreet 2017-03-16  645  
cd575ddf57af00 Kent Overstreet 2018-11-01  646  static void bch2_mark_stripe_ptr(struct bch_fs *c,
cd575ddf57af00 Kent Overstreet 2018-11-01  647  				 struct bch_extent_stripe_ptr p,
cd575ddf57af00 Kent Overstreet 2018-11-01  648  				 s64 sectors, unsigned flags,
cd575ddf57af00 Kent Overstreet 2018-11-01  649  				 s64 *adjusted_disk_sectors,
cd575ddf57af00 Kent Overstreet 2018-11-01  650  				 unsigned *redundancy)
cd575ddf57af00 Kent Overstreet 2018-11-01  651  {
cd575ddf57af00 Kent Overstreet 2018-11-01  652  	struct ec_stripe *m;
cd575ddf57af00 Kent Overstreet 2018-11-01  653  	unsigned old, new, nr_data;
cd575ddf57af00 Kent Overstreet 2018-11-01  654  	int blocks_nonempty_delta;
cd575ddf57af00 Kent Overstreet 2018-11-01  655  	s64 parity_sectors;
cd575ddf57af00 Kent Overstreet 2018-11-01  656  
cd575ddf57af00 Kent Overstreet 2018-11-01  657  	m = genradix_ptr(&c->ec_stripes, p.idx);
cd575ddf57af00 Kent Overstreet 2018-11-01  658  	if (WARN_ON(!m))
cd575ddf57af00 Kent Overstreet 2018-11-01  659  		return;
cd575ddf57af00 Kent Overstreet 2018-11-01  660  
cd575ddf57af00 Kent Overstreet 2018-11-01  661  	if (WARN_ON(!m->alive))
cd575ddf57af00 Kent Overstreet 2018-11-01  662  		return;
cd575ddf57af00 Kent Overstreet 2018-11-01  663  
cd575ddf57af00 Kent Overstreet 2018-11-01  664  	nr_data = m->nr_blocks - m->nr_redundant;
cd575ddf57af00 Kent Overstreet 2018-11-01  665  
cd575ddf57af00 Kent Overstreet 2018-11-01  666  	parity_sectors = DIV_ROUND_UP(abs(sectors) * m->nr_redundant, nr_data);
cd575ddf57af00 Kent Overstreet 2018-11-01  667  
cd575ddf57af00 Kent Overstreet 2018-11-01  668  	if (sectors < 0)
cd575ddf57af00 Kent Overstreet 2018-11-01  669  		parity_sectors = -parity_sectors;
cd575ddf57af00 Kent Overstreet 2018-11-01  670  
cd575ddf57af00 Kent Overstreet 2018-11-01  671  	*adjusted_disk_sectors += parity_sectors;
cd575ddf57af00 Kent Overstreet 2018-11-01  672  
cd575ddf57af00 Kent Overstreet 2018-11-01  673  	*redundancy = max_t(unsigned, *redundancy, m->nr_redundant + 1);
cd575ddf57af00 Kent Overstreet 2018-11-01  674  
cd575ddf57af00 Kent Overstreet 2018-11-01 @675  	new = atomic_add_return(sectors, &m->block_sectors[p.block]);
cd575ddf57af00 Kent Overstreet 2018-11-01  676  	old = new - sectors;
cd575ddf57af00 Kent Overstreet 2018-11-01  677  
cd575ddf57af00 Kent Overstreet 2018-11-01  678  	blocks_nonempty_delta = (int) !!new - (int) !!old;
cd575ddf57af00 Kent Overstreet 2018-11-01  679  	if (!blocks_nonempty_delta)
cd575ddf57af00 Kent Overstreet 2018-11-01  680  		return;
cd575ddf57af00 Kent Overstreet 2018-11-01  681  
cd575ddf57af00 Kent Overstreet 2018-11-01  682  	atomic_add(blocks_nonempty_delta, &m->blocks_nonempty);
cd575ddf57af00 Kent Overstreet 2018-11-01  683  
cd575ddf57af00 Kent Overstreet 2018-11-01  684  	BUG_ON(atomic_read(&m->blocks_nonempty) < 0);
cd575ddf57af00 Kent Overstreet 2018-11-01  685  
cd575ddf57af00 Kent Overstreet 2018-11-01  686  	bch2_stripes_heap_update(c, m, p.idx);
cd575ddf57af00 Kent Overstreet 2018-11-01  687  }
cd575ddf57af00 Kent Overstreet 2018-11-01  688  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2023-11-07 22:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-07 22:45 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-12-10 10:53 fs/bcachefs/buckets.c:675:61: sparse: sparse: invalid access past the end of 'p' (4 8) kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202311080541.hrumYImb-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.