From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E3FD18F; Wed, 8 Nov 2023 16:40:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3b5714439b3so3413252b6e.3; Wed, 08 Nov 2023 08:40:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699461614; x=1700066414; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ssuYxHfN9GAnFK7fIA31znw/q0iB6aLpzguCXmB/ycM=; b=heuvM3TUGvftOhOhrh276Pa2sR9EOtiRSdA1HUe4SjzTccxgo7CFo/Bq1cxGRw/5ln fm73IdBSSgsWwkEWOMCstcAwks8aR0tXNJ8ssjsy/secUoozPpNC8vx2I+A6MAAmhzt/ 7Z8fMhOKmm91GvDtfFyjEm9a9Sw4DMudUr6EbtckL30La1/6KAr3Vh3Sg86XCUlETa8a u63d31dDXYf+Mq7vJ//fIABUT+ha5pYNICswJI6IfQ2w7IkopmppmDGRjUc0X46VljbJ OKJ7swE3RL4O43vJJePm0c/LFR7WsQXHoudYDj7duMzP/EdGRvLj0T/7ci4kX4uta4u2 wzVQ== X-Gm-Message-State: AOJu0YwIT7lsbu1RinhC9IXLVauYYwx9gGtQmN1E3sqsaxTQOCDElBxT E8CUkcDU+7jpHQ/FewZHPA== X-Google-Smtp-Source: AGHT+IGXYQ4NWuhknPwkgNGSEQUWD6c5qRqqAmhMQTB6tTEvVpofwZw28IPC+YMCrYLivbXk6k+J5g== X-Received: by 2002:aca:905:0:b0:3af:26e3:92e with SMTP id 5-20020aca0905000000b003af26e3092emr2345076oij.28.1699461614688; Wed, 08 Nov 2023 08:40:14 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id bk31-20020a0568081a1f00b003a7a34a4ed8sm1940758oib.33.2023.11.08.08.40.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 08:40:14 -0800 (PST) Received: (nullmailer pid 2362820 invoked by uid 1000); Wed, 08 Nov 2023 16:40:12 -0000 Date: Wed, 8 Nov 2023 10:40:12 -0600 From: Rob Herring To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Krzysztof Kozlowski , Wim Van Sebroeck , Guenter Roeck , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hector Martin , Sven Peter , Alyssa Rosenzweig , Julius Werner , Evan Benn , Florian Fainelli , Broadcom internal kernel review list , Maxime Ripard , Oleksij Rempel , Justin Chen , Baruch Siach , Ahmad Zainie , Marc Zyngier , Linus Walleij , Jamie Iles , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, asahi@lists.linux.dev Subject: Re: [PATCH 1/2] dt-bindings: watchdog: re-order entries to match coding convention Message-ID: <20231108164012.GA2336524-robh@kernel.org> References: <20231105184154.43700-1-krzysztof.kozlowski@linaro.org> <300293570c0d29d5d4a39762121b5bef@milecki.pl> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <300293570c0d29d5d4a39762121b5bef@milecki.pl> On Mon, Nov 06, 2023 at 09:10:44AM +0100, Rafał Miłecki wrote: > On 2023-11-05 19:41, Krzysztof Kozlowski wrote: > > The Devicetree bindings coding convention, as used in most of the files > > and expressed in Documentation/devicetree/bindings/example-schema.yaml, > > expects: > > 1. "allOf:" block just before "properties:" (or after "required:" for > > more complex cases), > > 2. additionalProperties/unevaluatedProperties at the end of the file, > > just before the examples section. > > > > Re-order few schemas to match the convention to avoid repeating review > > comments for new patches using existing code as template. No functional > > changes. > > It's surely going to help a bit but for a long time solution maybe you > could consider adding proper check to Rob's bot and/or checkpatch.pl. I have such a check I wrote long ago. tools/yaml-format in dtschema. It just does a ruamel read and write back out so you get exactly how ruamel is configured or defaults to for things not configurable. Primarily, the non-configurable part is multi-line text without a '|'. So lots of 'description' paragraphs are reformatted. It ends up being too strict IMO. The key order is checked, but not fixed. Probably could add reordering. Adding this by default (and to the bot) means fixing *every* file in tree first. That's not something I care to do and enforce. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E549C4332F for ; Wed, 8 Nov 2023 16:40:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NVT3bzVUUHIJdexPmd2roeZr41AbDNGiggEgghUg89Y=; b=09cMe1fF02tix1 adJ2mUtDbDI6YvzLqxpkJ0RYOsyGVTxyy4j8V33MVd0CfSk6A2TwsSxLx3/BJDxT8ODxPBYKbLVSn g1iIJ94HMb8pH1gIeGK+5SnqYWsKhWKg6zfIl8knrDm6w8krvnhjzasGROVUkfXZEHrMgVSJzNuUG E+Ts1/sWFSAY2Pjr0Rb7gLEnE+w4tdVLRXznvtoa0mCDeg47wsQVxRTxR9qpZUGiz0qKCX4WRD5kR ZfBlqfOZ0ETJqZwWVX5cpLXfiPZegUBOkCZGx17ZnrTvwpsWpxkfxznEJAGZM8jZBmHTWFX4wPz3P FHl+sgQBgS6jABCVbnJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0lbG-004Jr9-1k; Wed, 08 Nov 2023 16:40:18 +0000 Received: from mail-oi1-f169.google.com ([209.85.167.169]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0lbD-004Jqi-1f for linux-arm-kernel@lists.infradead.org; Wed, 08 Nov 2023 16:40:16 +0000 Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-3b5aee410f2so1605588b6e.1 for ; Wed, 08 Nov 2023 08:40:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699461614; x=1700066414; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ssuYxHfN9GAnFK7fIA31znw/q0iB6aLpzguCXmB/ycM=; b=p7N0EcE7ET7L7FpVPNuXUT4xjVbC2OmOsDOF0FgeE76cvQEZghMG68E22019/UaAAq gnqm7AmHPayNp1BeYaT4U2iBAKBL9wy37ht/6Na8R/B6Y1A9gEx4YIkqiS153ss/1xbT ke17p8xAEsvh+ye5HQlLoOdBosJ4N0VmU2C5AISqjhNoZtsy+DdG/EJybwOMhqJwZ+mx 6+CylGSeB9dStEMzDYokNO/jWVQhpOReHXsu6DSFjKrCd+MFjyzOG/y++mVB4hAQMtwm oMd7+CoHVyIdsz8Wl9E/t65V+HTc5KGfUvsJEhsX5iNooMPY5iy91pum58BBOCEmT16q +w1Q== X-Gm-Message-State: AOJu0YwtciX7nTA6+eHfhhELcPDHgdMPxEPvPpczqp+1oc0X7MG9RWbe /GSZt4CN6fXpSlZvulAIpQ== X-Google-Smtp-Source: AGHT+IGXYQ4NWuhknPwkgNGSEQUWD6c5qRqqAmhMQTB6tTEvVpofwZw28IPC+YMCrYLivbXk6k+J5g== X-Received: by 2002:aca:905:0:b0:3af:26e3:92e with SMTP id 5-20020aca0905000000b003af26e3092emr2345076oij.28.1699461614688; Wed, 08 Nov 2023 08:40:14 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id bk31-20020a0568081a1f00b003a7a34a4ed8sm1940758oib.33.2023.11.08.08.40.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 08:40:14 -0800 (PST) Received: (nullmailer pid 2362820 invoked by uid 1000); Wed, 08 Nov 2023 16:40:12 -0000 Date: Wed, 8 Nov 2023 10:40:12 -0600 From: Rob Herring To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Krzysztof Kozlowski , Wim Van Sebroeck , Guenter Roeck , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hector Martin , Sven Peter , Alyssa Rosenzweig , Julius Werner , Evan Benn , Florian Fainelli , Broadcom internal kernel review list , Maxime Ripard , Oleksij Rempel , Justin Chen , Baruch Siach , Ahmad Zainie , Marc Zyngier , Linus Walleij , Jamie Iles , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, asahi@lists.linux.dev Subject: Re: [PATCH 1/2] dt-bindings: watchdog: re-order entries to match coding convention Message-ID: <20231108164012.GA2336524-robh@kernel.org> References: <20231105184154.43700-1-krzysztof.kozlowski@linaro.org> <300293570c0d29d5d4a39762121b5bef@milecki.pl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <300293570c0d29d5d4a39762121b5bef@milecki.pl> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231108_084015_576804_09A8E3B6 X-CRM114-Status: GOOD ( 19.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBOb3YgMDYsIDIwMjMgYXQgMDk6MTA6NDRBTSArMDEwMCwgUmFmYcWCIE1pxYJlY2tp IHdyb3RlOgo+IE9uIDIwMjMtMTEtMDUgMTk6NDEsIEtyenlzenRvZiBLb3psb3dza2kgd3JvdGU6 Cj4gPiBUaGUgRGV2aWNldHJlZSBiaW5kaW5ncyBjb2RpbmcgY29udmVudGlvbiwgYXMgdXNlZCBp biBtb3N0IG9mIHRoZSBmaWxlcwo+ID4gYW5kIGV4cHJlc3NlZCBpbiBEb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvZXhhbXBsZS1zY2hlbWEueWFtbCwKPiA+IGV4cGVjdHM6Cj4gPiAx LiAiYWxsT2Y6IiBibG9jayBqdXN0IGJlZm9yZSAicHJvcGVydGllczoiIChvciBhZnRlciAicmVx dWlyZWQ6IiBmb3IKPiA+ICAgIG1vcmUgY29tcGxleCBjYXNlcyksCj4gPiAyLiBhZGRpdGlvbmFs UHJvcGVydGllcy91bmV2YWx1YXRlZFByb3BlcnRpZXMgYXQgdGhlIGVuZCBvZiB0aGUgZmlsZSwK PiA+ICAgIGp1c3QgYmVmb3JlIHRoZSBleGFtcGxlcyBzZWN0aW9uLgo+ID4gCj4gPiBSZS1vcmRl ciBmZXcgc2NoZW1hcyB0byBtYXRjaCB0aGUgY29udmVudGlvbiB0byBhdm9pZCByZXBlYXRpbmcg cmV2aWV3Cj4gPiBjb21tZW50cyBmb3IgbmV3IHBhdGNoZXMgdXNpbmcgZXhpc3RpbmcgY29kZSBh cyB0ZW1wbGF0ZS4gIE5vIGZ1bmN0aW9uYWwKPiA+IGNoYW5nZXMuCj4gCj4gSXQncyBzdXJlbHkg Z29pbmcgdG8gaGVscCBhIGJpdCBidXQgZm9yIGEgbG9uZyB0aW1lIHNvbHV0aW9uIG1heWJlIHlv dQo+IGNvdWxkIGNvbnNpZGVyIGFkZGluZyBwcm9wZXIgY2hlY2sgdG8gUm9iJ3MgYm90IGFuZC9v ciBjaGVja3BhdGNoLnBsLgoKSSBoYXZlIHN1Y2ggYSBjaGVjayBJIHdyb3RlIGxvbmcgYWdvLiB0 b29scy95YW1sLWZvcm1hdCBpbiBkdHNjaGVtYS4gSXQgCmp1c3QgZG9lcyBhIHJ1YW1lbCByZWFk IGFuZCB3cml0ZSBiYWNrIG91dCBzbyB5b3UgZ2V0IGV4YWN0bHkgaG93IHJ1YW1lbCAKaXMgY29u ZmlndXJlZCBvciBkZWZhdWx0cyB0byBmb3IgdGhpbmdzIG5vdCBjb25maWd1cmFibGUuIFByaW1h cmlseSwgdGhlIApub24tY29uZmlndXJhYmxlIHBhcnQgaXMgbXVsdGktbGluZSB0ZXh0IHdpdGhv dXQgYSAnfCcuIFNvIGxvdHMgb2YgCidkZXNjcmlwdGlvbicgcGFyYWdyYXBocyBhcmUgcmVmb3Jt YXR0ZWQuIEl0IGVuZHMgdXAgYmVpbmcgdG9vIHN0cmljdCAKSU1PLgoKVGhlIGtleSBvcmRlciBp cyBjaGVja2VkLCBidXQgbm90IGZpeGVkLiBQcm9iYWJseSBjb3VsZCBhZGQgcmVvcmRlcmluZy4K CkFkZGluZyB0aGlzIGJ5IGRlZmF1bHQgKGFuZCB0byB0aGUgYm90KSBtZWFucyBmaXhpbmcgKmV2 ZXJ5KiBmaWxlIGluIAp0cmVlIGZpcnN0LiBUaGF0J3Mgbm90IHNvbWV0aGluZyBJIGNhcmUgdG8g ZG8gYW5kIGVuZm9yY2UuCgpSb2IKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK