From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAF3DC4332F for ; Wed, 8 Nov 2023 16:43:31 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 480A083A; Wed, 8 Nov 2023 17:42:39 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 480A083A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1699461809; bh=mTSad6bJhZGA212S/cPdKprvVKPQ/Wzqui55Qdqk7Q0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=vfto+SmhAM4aDTSFgbTzMBMtowgGgJjjYpD+dztTDKYNZxIpuSyFc3iYl1bzJHHr/ MoWOeMhdagXc3KVLN+5ySUrqvJgUKCUIboMWGTW+VvxBO9Z8AMibITWfAY9Y4e5Eor QE0GliVwqZNnKsyJQTRnfof6XYWJhh9ctFez/IWE= Received: by alsa1.perex.cz (Postfix, from userid 50401) id C57FEF80152; Wed, 8 Nov 2023 17:42:05 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 2CBD1F8016D; Wed, 8 Nov 2023 17:42:05 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DDD85F8016D; Wed, 8 Nov 2023 17:42:01 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 41F38F80152 for ; Wed, 8 Nov 2023 17:41:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 41F38F80152 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=mHEkXpn0 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 807EB61696; Wed, 8 Nov 2023 16:41:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE3EFC433C9; Wed, 8 Nov 2023 16:41:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699461714; bh=mTSad6bJhZGA212S/cPdKprvVKPQ/Wzqui55Qdqk7Q0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mHEkXpn0YUGCi5tDa5stf8TWfMEbxcSgszu1XhzbVhTBRgxBnyU/PzKxof2V9XnaY zuYUA7lRdYFVNhIGuPpGjAzNGK9m6qjHSad5xZq9BXgyC7S8qhsGji0Ws70V9ECWQW jJoXZW/EGelR6dVh/x8jxbO2B5fARPBf47voCmN+SWIdg/iQeJBUS+Yd3MJoHVi6ab DGmxVQMHM/QW683mvTs3EjeZs6+grLIqhLcS5nMjoq9FdFM+A/2Cc4onYm75xzfDY4 F/4s2fEWLVRP2PVf719XdVQKnBtekM8cBdJNMMOwLap8uCWbX1q7vDSzfyPAn2wgCM XZ+PJnY19Z6bg== Date: Wed, 8 Nov 2023 16:41:43 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 11/17] ASoC: dt-bindings: samsung-i2s: add specific compatibles for existing SoC Message-ID: <20231108164143.GC8909@google.com> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-12-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231108104343.24192-12-krzysztof.kozlowski@linaro.org> Message-ID-Hash: BEPC7DMFY7FEZPGOX37OW426DE3ITIIG X-Message-ID-Hash: BEPC7DMFY7FEZPGOX37OW426DE3ITIIG X-MailFrom: lee@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 08 Nov 2023, Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlowski > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../mfd/samsung,exynos5433-lpass.yaml | 2 +- > .../bindings/sound/samsung-i2s.yaml | 19 ++++++++++++------- > 2 files changed, 13 insertions(+), 8 deletions(-) Acked-by: Lee Jones -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 188C8C4332F for ; Wed, 8 Nov 2023 16:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IBOSQAdIyMUP2MQnTUeSaOBE5t3G4wJL1X66ucM27fY=; b=2Wbyp1LdcfNujb dlJ6t2wdGuzGXujPVK9H5oPjtxkp/TT0YGRUrAuiryMiufcYFQWzFRUoT1LCu3g6pnBh88rak+Bwq ieDegPa5WKIUXkrg8qqQo8yhpqNOD0c6Uez+f8lNZdvn3K5MYqbIqMjGp5WrOEcaPxSSEqxEGsp00 EjEb4VtqsAGebdt7AA+CZU5bCtlhNBTiUzAa18Prd+EDdTRzYZcd2Trib5hiAD0P1NOLWQeTa1YGO NOnch7+61naDSRtZNQcQG8uLa3vfqQMoOZVaOP5zfQ3UVczE7ocBtN4nEwBzin3KbtfKhsIbb7yaW 61UT+gxoqN6Rq/ruxkbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0lcr-004K8z-1T; Wed, 08 Nov 2023 16:41:57 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0lcp-004K8M-1H for linux-arm-kernel@lists.infradead.org; Wed, 08 Nov 2023 16:41:56 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 807EB61696; Wed, 8 Nov 2023 16:41:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE3EFC433C9; Wed, 8 Nov 2023 16:41:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699461714; bh=mTSad6bJhZGA212S/cPdKprvVKPQ/Wzqui55Qdqk7Q0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mHEkXpn0YUGCi5tDa5stf8TWfMEbxcSgszu1XhzbVhTBRgxBnyU/PzKxof2V9XnaY zuYUA7lRdYFVNhIGuPpGjAzNGK9m6qjHSad5xZq9BXgyC7S8qhsGji0Ws70V9ECWQW jJoXZW/EGelR6dVh/x8jxbO2B5fARPBf47voCmN+SWIdg/iQeJBUS+Yd3MJoHVi6ab DGmxVQMHM/QW683mvTs3EjeZs6+grLIqhLcS5nMjoq9FdFM+A/2Cc4onYm75xzfDY4 F/4s2fEWLVRP2PVf719XdVQKnBtekM8cBdJNMMOwLap8uCWbX1q7vDSzfyPAn2wgCM XZ+PJnY19Z6bg== Date: Wed, 8 Nov 2023 16:41:43 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Andi Shyti , Jonathan Cameron , Lars-Peter Clausen , Ulf Hansson , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Jiri Slaby , Liam Girdwood , Mark Brown , Jaehoon Chung , Sam Protsenko , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 11/17] ASoC: dt-bindings: samsung-i2s: add specific compatibles for existing SoC Message-ID: <20231108164143.GC8909@google.com> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-12-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231108104343.24192-12-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231108_084155_482579_3959A629 X-CRM114-Status: GOOD ( 17.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAwOCBOb3YgMjAyMywgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToKCj4gU2Ftc3Vu ZyBFeHlub3MgU29DIHJldXNlcyBzZXZlcmFsIGRldmljZXMgZnJvbSBvbGRlciBkZXNpZ25zLCB0 aHVzCj4gaGlzdG9yaWNhbGx5IHdlIGtlcHQgdGhlIG9sZCAoYmxvY2sncykgY29tcGF0aWJsZSBv bmx5LiAgVGhpcyB3b3JrcyBmaW5lCj4gYW5kIHRoZXJlIGlzIG5vIGJ1ZyBoZXJlLCBob3dldmVy IGd1aWRlbGluZXMgZXhwcmVzc2VkIGluCj4gRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL3dyaXRpbmctYmluZGluZ3MucnN0IHN0YXRlIHRoYXQ6Cj4gMS4gQ29tcGF0aWJsZXMgc2hv dWxkIGJlIHNwZWNpZmljLgo+IDIuIFdlIHNob3VsZCBhZGQgbmV3IGNvbXBhdGlibGVzIGluIGNh c2Ugb2YgYnVncyBvciBmZWF0dXJlcy4KPiAKPiBBZGQgY29tcGF0aWJsZXMgc3BlY2lmaWMgdG8g ZWFjaCBTb0MgaW4gZnJvbnQgb2YgYWxsIG9sZC1Tb0MtbGlrZQo+IGNvbXBhdGlibGVzLgo+IAo+ IFNpZ25lZC1vZmYtYnk6IEtyenlzenRvZiBLb3psb3dza2kgPGtyenlzenRvZi5rb3psb3dza2lA bGluYXJvLm9yZz4KPiAKPiAtLS0KPiAKPiBJIHByb3Bvc2UgdG8gdGFrZSB0aGUgcGF0Y2ggdGhy b3VnaCBTYW1zdW5nIFNvQyAobWUpLiBTZWUgY292ZXIgbGV0dGVyCj4gZm9yIGV4cGxhbmF0aW9u Lgo+IC0tLQo+ICAuLi4vbWZkL3NhbXN1bmcsZXh5bm9zNTQzMy1scGFzcy55YW1sICAgICAgICAg fCAgMiArLQo+ICAuLi4vYmluZGluZ3Mvc291bmQvc2Ftc3VuZy1pMnMueWFtbCAgICAgICAgICAg fCAxOSArKysrKysrKysrKystLS0tLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9u cygrKSwgOCBkZWxldGlvbnMoLSkKCkFja2VkLWJ5OiBMZWUgSm9uZXMgPGxlZUBrZXJuZWwub3Jn PgoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E748C04E85 for ; Wed, 8 Nov 2023 16:41:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5C43010E7E4; Wed, 8 Nov 2023 16:41:57 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3500910E7E4 for ; Wed, 8 Nov 2023 16:41:55 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 807EB61696; Wed, 8 Nov 2023 16:41:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE3EFC433C9; Wed, 8 Nov 2023 16:41:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699461714; bh=mTSad6bJhZGA212S/cPdKprvVKPQ/Wzqui55Qdqk7Q0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mHEkXpn0YUGCi5tDa5stf8TWfMEbxcSgszu1XhzbVhTBRgxBnyU/PzKxof2V9XnaY zuYUA7lRdYFVNhIGuPpGjAzNGK9m6qjHSad5xZq9BXgyC7S8qhsGji0Ws70V9ECWQW jJoXZW/EGelR6dVh/x8jxbO2B5fARPBf47voCmN+SWIdg/iQeJBUS+Yd3MJoHVi6ab DGmxVQMHM/QW683mvTs3EjeZs6+grLIqhLcS5nMjoq9FdFM+A/2Cc4onYm75xzfDY4 F/4s2fEWLVRP2PVf719XdVQKnBtekM8cBdJNMMOwLap8uCWbX1q7vDSzfyPAn2wgCM XZ+PJnY19Z6bg== Date: Wed, 8 Nov 2023 16:41:43 +0000 From: Lee Jones To: Krzysztof Kozlowski Subject: Re: [PATCH 11/17] ASoC: dt-bindings: samsung-i2s: add specific compatibles for existing SoC Message-ID: <20231108164143.GC8909@google.com> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-12-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231108104343.24192-12-krzysztof.kozlowski@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Sylwester Nawrocki , Alexandre Belloni , linux-pwm@vger.kernel.org, linux-iio@vger.kernel.org, Tomasz Figa , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-i2c@vger.kernel.org, Krzysztof Kozlowski , Jiri Slaby , Andi Shyti , linux-rtc@vger.kernel.org, Jaehoon Chung , linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Alim Akhtar , devicetree@vger.kernel.org, Conor Dooley , alsa-devel@alsa-project.org, Maxime Ripard , linux-gpio@vger.kernel.org, Rob Herring , linux-sound@vger.kernel.org, Sam Protsenko , linux-arm-kernel@lists.infradead.org, Alessandro Zummo , Greg Kroah-Hartman , linux-mmc@vger.kernel.org, Liam Girdwood , Mark Brown , Thomas Zimmermann , Jonathan Cameron Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 08 Nov 2023, Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlowski > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../mfd/samsung,exynos5433-lpass.yaml | 2 +- > .../bindings/sound/samsung-i2s.yaml | 19 ++++++++++++------- > 2 files changed, 13 insertions(+), 8 deletions(-) Acked-by: Lee Jones -- Lee Jones [李琼斯]