From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2093DC4332F for ; Wed, 8 Nov 2023 15:54:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229581AbjKHPyI (ORCPT ); Wed, 8 Nov 2023 10:54:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbjKHPyH (ORCPT ); Wed, 8 Nov 2023 10:54:07 -0500 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC2821BC3; Wed, 8 Nov 2023 07:54:04 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id C80EA60008; Wed, 8 Nov 2023 15:53:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1699458843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bYS94S7++WYKx+tHBKHHGfIvXY84QiR+o61nAhem3TE=; b=JMmrAxt6CfsPfRIT849ExEJi2VTTQkFSMaqLfqgUH4rvB5ZfddAYUbwUnjgGxDIq8YaOxl B5Zs58doliOu1V5XAgr5Tw38Z1+5CRVNvd7AZsFJ5YKyTc5v/EX8df+BFjxU/kDeqmhRWV 8mifPlDY5iQb3p6b6jxvAmqf0Y87HAK6Iz/dWJ2ogWB2MW6jdZshdyV/tjYtH+CDrseL6c tW0wdNCF061azZnNKVx9kSNfGNTvWf/PXpbdSKGyKItVc1PwwFQztE7OqJlQDOQ8QYNGuv K+J87XKp360j9MWnbE3DsJ5UTmGYXLso7wSAid5sirjABqj0oBrNjYf/fsuuPg== Date: Wed, 8 Nov 2023 16:53:59 +0100 From: Miquel Raynal To: Linus Walleij Cc: Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , Ben Dooks , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH 4/6] mtd: rawnand: gpio: Use device properties Message-ID: <20231108165359.33dccef0@xps-13> In-Reply-To: <20231108-fix-mips-nand-v1-4-5fc5586d04de@linaro.org> References: <20231108-fix-mips-nand-v1-0-5fc5586d04de@linaro.org> <20231108-fix-mips-nand-v1-4-5fc5586d04de@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Linus, linus.walleij@linaro.org wrote on Wed, 08 Nov 2023 15:33:52 +0100: > The platform data (struct gpio_nand_platdata) isn't really used > in any boardfile in the kernel: the only probe path is from > device tree. >=20 > Convert the driver to not use the platform data header at all > and read out the device tree properties using device > properties so we don't need to have the driver be exclusively > device tree either: ACPI or software nodes work fine if > need be. Drop the ifdeffery around CONFIG_OF as a consequence. >=20 > The code reads "bank-width" to plat->options flags and passes > it directly to the NAND chip struct, so just assign this > directly to the chip instead. >=20 > The code reads one property "chip-delay" that it stores > in pdata->delay and never use, so drop this altogether. > If timings should be supported this can probably be done in > a more detailed way using the new elaborate timings structs > that exist for NAND. >=20 > The platform data contains a callback to augment partitions, > but since there are no board files using this platform > data to define a gpio NAND device, this is never used so > the code handling it can be deleted. Nice cleanup. I'm a bit more reluctant on the bindings side, I'll come back to it later, but the driver side looks neat. Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 206BCC4332F for ; Wed, 8 Nov 2023 15:54:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AOwyIfpn5ZVjksqmpk2odbZa45pWqE4zC1c47CNRi6A=; b=hvnCIyP/LYzpPo TR60ZvGo5iSEMGfouLEtPUD+sqq/olGEx32SA5aaJQmGFdiXPK7UYgw8daLoW9z61mt/BTYXxDZsx +T1juR3xWGj3WI4e0F6s5DaOeiaZjo0r0wXg6QCJIplEVHTbo5+8B5NHgYQErYZNpdZTSjSgHZetb OSLThmORn1NIwt1PlxbXBe471viHY1rpOX0/tKmRPxiquMS5phm0OswZZ7Yn5/L67NSfZG+0LbcF9 NUSfzwqvqeMjpxet7RE35NhG2JvO5P1c3Ig1YJ0XAydCYUKqnm2y4cbL7TSL2UDpvWozgtOIw0UaG vhqnfjTDoI9iulDmcETw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0ksf-004EFO-0E; Wed, 08 Nov 2023 15:54:13 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0ksa-004EDx-2f; Wed, 08 Nov 2023 15:54:10 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id C80EA60008; Wed, 8 Nov 2023 15:53:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1699458843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bYS94S7++WYKx+tHBKHHGfIvXY84QiR+o61nAhem3TE=; b=JMmrAxt6CfsPfRIT849ExEJi2VTTQkFSMaqLfqgUH4rvB5ZfddAYUbwUnjgGxDIq8YaOxl B5Zs58doliOu1V5XAgr5Tw38Z1+5CRVNvd7AZsFJ5YKyTc5v/EX8df+BFjxU/kDeqmhRWV 8mifPlDY5iQb3p6b6jxvAmqf0Y87HAK6Iz/dWJ2ogWB2MW6jdZshdyV/tjYtH+CDrseL6c tW0wdNCF061azZnNKVx9kSNfGNTvWf/PXpbdSKGyKItVc1PwwFQztE7OqJlQDOQ8QYNGuv K+J87XKp360j9MWnbE3DsJ5UTmGYXLso7wSAid5sirjABqj0oBrNjYf/fsuuPg== Date: Wed, 8 Nov 2023 16:53:59 +0100 From: Miquel Raynal To: Linus Walleij Cc: Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , Ben Dooks , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH 4/6] mtd: rawnand: gpio: Use device properties Message-ID: <20231108165359.33dccef0@xps-13> In-Reply-To: <20231108-fix-mips-nand-v1-4-5fc5586d04de@linaro.org> References: <20231108-fix-mips-nand-v1-0-5fc5586d04de@linaro.org> <20231108-fix-mips-nand-v1-4-5fc5586d04de@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231108_075409_022511_403A7FF3 X-CRM114-Status: GOOD ( 21.98 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTGludXMsCgpsaW51cy53YWxsZWlqQGxpbmFyby5vcmcgd3JvdGUgb24gV2VkLCAwOCBOb3Yg MjAyMyAxNTozMzo1MiArMDEwMDoKCj4gVGhlIHBsYXRmb3JtIGRhdGEgKHN0cnVjdCBncGlvX25h bmRfcGxhdGRhdGEpIGlzbid0IHJlYWxseSB1c2VkCj4gaW4gYW55IGJvYXJkZmlsZSBpbiB0aGUg a2VybmVsOiB0aGUgb25seSBwcm9iZSBwYXRoIGlzIGZyb20KPiBkZXZpY2UgdHJlZS4KPiAKPiBD b252ZXJ0IHRoZSBkcml2ZXIgdG8gbm90IHVzZSB0aGUgcGxhdGZvcm0gZGF0YSBoZWFkZXIgYXQg YWxsCj4gYW5kIHJlYWQgb3V0IHRoZSBkZXZpY2UgdHJlZSBwcm9wZXJ0aWVzIHVzaW5nIGRldmlj ZQo+IHByb3BlcnRpZXMgc28gd2UgZG9uJ3QgbmVlZCB0byBoYXZlIHRoZSBkcml2ZXIgYmUgZXhj bHVzaXZlbHkKPiBkZXZpY2UgdHJlZSBlaXRoZXI6IEFDUEkgb3Igc29mdHdhcmUgbm9kZXMgd29y ayBmaW5lIGlmCj4gbmVlZCBiZS4gRHJvcCB0aGUgaWZkZWZmZXJ5IGFyb3VuZCBDT05GSUdfT0Yg YXMgYSBjb25zZXF1ZW5jZS4KPiAKPiBUaGUgY29kZSByZWFkcyAiYmFuay13aWR0aCIgdG8gcGxh dC0+b3B0aW9ucyBmbGFncyBhbmQgcGFzc2VzCj4gaXQgZGlyZWN0bHkgdG8gdGhlIE5BTkQgY2hp cCBzdHJ1Y3QsIHNvIGp1c3QgYXNzaWduIHRoaXMKPiBkaXJlY3RseSB0byB0aGUgY2hpcCBpbnN0 ZWFkLgo+IAo+IFRoZSBjb2RlIHJlYWRzIG9uZSBwcm9wZXJ0eSAiY2hpcC1kZWxheSIgdGhhdCBp dCBzdG9yZXMKPiBpbiBwZGF0YS0+ZGVsYXkgYW5kIG5ldmVyIHVzZSwgc28gZHJvcCB0aGlzIGFs dG9nZXRoZXIuCj4gSWYgdGltaW5ncyBzaG91bGQgYmUgc3VwcG9ydGVkIHRoaXMgY2FuIHByb2Jh Ymx5IGJlIGRvbmUgaW4KPiBhIG1vcmUgZGV0YWlsZWQgd2F5IHVzaW5nIHRoZSBuZXcgZWxhYm9y YXRlIHRpbWluZ3Mgc3RydWN0cwo+IHRoYXQgZXhpc3QgZm9yIE5BTkQuCj4gCj4gVGhlIHBsYXRm b3JtIGRhdGEgY29udGFpbnMgYSBjYWxsYmFjayB0byBhdWdtZW50IHBhcnRpdGlvbnMsCj4gYnV0 IHNpbmNlIHRoZXJlIGFyZSBubyBib2FyZCBmaWxlcyB1c2luZyB0aGlzIHBsYXRmb3JtCj4gZGF0 YSB0byBkZWZpbmUgYSBncGlvIE5BTkQgZGV2aWNlLCB0aGlzIGlzIG5ldmVyIHVzZWQgc28KPiB0 aGUgY29kZSBoYW5kbGluZyBpdCBjYW4gYmUgZGVsZXRlZC4KCk5pY2UgY2xlYW51cC4gSSdtIGEg Yml0IG1vcmUgcmVsdWN0YW50IG9uIHRoZSBiaW5kaW5ncyBzaWRlLCBJJ2xsIGNvbWUKYmFjayB0 byBpdCBsYXRlciwgYnV0IHRoZSBkcml2ZXIgc2lkZSBsb29rcyBuZWF0LgoKVGhhbmtzLApNaXF1 w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6102C4332F for ; Wed, 8 Nov 2023 15:54:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zPz41AEr25QnO/spW0YbxQ/+f62EUXyLZUcSi/fCyH0=; b=lYRR/XoROPDWAS WNwoWTAOau5nGm4/ifkVVXSxcKZx6n3Q5TyWTPf9gV5he4r8vhATKmrjg3ndw+Rn1zSJZaGkV94OW Gj2dyHCjdETL2QcpBMxPEtxhShr8NQGLPcbPlbBYU7FFNCP5vldx2BZbnN9R0Swms3HPlh7BTop92 Wp9xAtw29g1WQYjRe/W5rKmS1lQn0hzgV9ZwqjJ5UnuXiHPHoVtj/F2RvwKGyADeyCE/+YkMUlA8V EB7g3N6Noh7b3D+00ImNEkF4Jk2smGcYeznmpZqjWq5QPar70U9OVkinXZiU8fcwOTnhSe2HzmcEN 83LBLoLMBlfhUE0SCupw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0kse-004EF6-1e; Wed, 08 Nov 2023 15:54:12 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0ksa-004EDx-2f; Wed, 08 Nov 2023 15:54:10 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id C80EA60008; Wed, 8 Nov 2023 15:53:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1699458843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bYS94S7++WYKx+tHBKHHGfIvXY84QiR+o61nAhem3TE=; b=JMmrAxt6CfsPfRIT849ExEJi2VTTQkFSMaqLfqgUH4rvB5ZfddAYUbwUnjgGxDIq8YaOxl B5Zs58doliOu1V5XAgr5Tw38Z1+5CRVNvd7AZsFJ5YKyTc5v/EX8df+BFjxU/kDeqmhRWV 8mifPlDY5iQb3p6b6jxvAmqf0Y87HAK6Iz/dWJ2ogWB2MW6jdZshdyV/tjYtH+CDrseL6c tW0wdNCF061azZnNKVx9kSNfGNTvWf/PXpbdSKGyKItVc1PwwFQztE7OqJlQDOQ8QYNGuv K+J87XKp360j9MWnbE3DsJ5UTmGYXLso7wSAid5sirjABqj0oBrNjYf/fsuuPg== Date: Wed, 8 Nov 2023 16:53:59 +0100 From: Miquel Raynal To: Linus Walleij Cc: Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , Ben Dooks , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH 4/6] mtd: rawnand: gpio: Use device properties Message-ID: <20231108165359.33dccef0@xps-13> In-Reply-To: <20231108-fix-mips-nand-v1-4-5fc5586d04de@linaro.org> References: <20231108-fix-mips-nand-v1-0-5fc5586d04de@linaro.org> <20231108-fix-mips-nand-v1-4-5fc5586d04de@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231108_075409_022511_403A7FF3 X-CRM114-Status: GOOD ( 21.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTGludXMsCgpsaW51cy53YWxsZWlqQGxpbmFyby5vcmcgd3JvdGUgb24gV2VkLCAwOCBOb3Yg MjAyMyAxNTozMzo1MiArMDEwMDoKCj4gVGhlIHBsYXRmb3JtIGRhdGEgKHN0cnVjdCBncGlvX25h bmRfcGxhdGRhdGEpIGlzbid0IHJlYWxseSB1c2VkCj4gaW4gYW55IGJvYXJkZmlsZSBpbiB0aGUg a2VybmVsOiB0aGUgb25seSBwcm9iZSBwYXRoIGlzIGZyb20KPiBkZXZpY2UgdHJlZS4KPiAKPiBD b252ZXJ0IHRoZSBkcml2ZXIgdG8gbm90IHVzZSB0aGUgcGxhdGZvcm0gZGF0YSBoZWFkZXIgYXQg YWxsCj4gYW5kIHJlYWQgb3V0IHRoZSBkZXZpY2UgdHJlZSBwcm9wZXJ0aWVzIHVzaW5nIGRldmlj ZQo+IHByb3BlcnRpZXMgc28gd2UgZG9uJ3QgbmVlZCB0byBoYXZlIHRoZSBkcml2ZXIgYmUgZXhj bHVzaXZlbHkKPiBkZXZpY2UgdHJlZSBlaXRoZXI6IEFDUEkgb3Igc29mdHdhcmUgbm9kZXMgd29y ayBmaW5lIGlmCj4gbmVlZCBiZS4gRHJvcCB0aGUgaWZkZWZmZXJ5IGFyb3VuZCBDT05GSUdfT0Yg YXMgYSBjb25zZXF1ZW5jZS4KPiAKPiBUaGUgY29kZSByZWFkcyAiYmFuay13aWR0aCIgdG8gcGxh dC0+b3B0aW9ucyBmbGFncyBhbmQgcGFzc2VzCj4gaXQgZGlyZWN0bHkgdG8gdGhlIE5BTkQgY2hp cCBzdHJ1Y3QsIHNvIGp1c3QgYXNzaWduIHRoaXMKPiBkaXJlY3RseSB0byB0aGUgY2hpcCBpbnN0 ZWFkLgo+IAo+IFRoZSBjb2RlIHJlYWRzIG9uZSBwcm9wZXJ0eSAiY2hpcC1kZWxheSIgdGhhdCBp dCBzdG9yZXMKPiBpbiBwZGF0YS0+ZGVsYXkgYW5kIG5ldmVyIHVzZSwgc28gZHJvcCB0aGlzIGFs dG9nZXRoZXIuCj4gSWYgdGltaW5ncyBzaG91bGQgYmUgc3VwcG9ydGVkIHRoaXMgY2FuIHByb2Jh Ymx5IGJlIGRvbmUgaW4KPiBhIG1vcmUgZGV0YWlsZWQgd2F5IHVzaW5nIHRoZSBuZXcgZWxhYm9y YXRlIHRpbWluZ3Mgc3RydWN0cwo+IHRoYXQgZXhpc3QgZm9yIE5BTkQuCj4gCj4gVGhlIHBsYXRm b3JtIGRhdGEgY29udGFpbnMgYSBjYWxsYmFjayB0byBhdWdtZW50IHBhcnRpdGlvbnMsCj4gYnV0 IHNpbmNlIHRoZXJlIGFyZSBubyBib2FyZCBmaWxlcyB1c2luZyB0aGlzIHBsYXRmb3JtCj4gZGF0 YSB0byBkZWZpbmUgYSBncGlvIE5BTkQgZGV2aWNlLCB0aGlzIGlzIG5ldmVyIHVzZWQgc28KPiB0 aGUgY29kZSBoYW5kbGluZyBpdCBjYW4gYmUgZGVsZXRlZC4KCk5pY2UgY2xlYW51cC4gSSdtIGEg Yml0IG1vcmUgcmVsdWN0YW50IG9uIHRoZSBiaW5kaW5ncyBzaWRlLCBJJ2xsIGNvbWUKYmFjayB0 byBpdCBsYXRlciwgYnV0IHRoZSBkcml2ZXIgc2lkZSBsb29rcyBuZWF0LgoKVGhhbmtzLApNaXF1 w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg==