From: Jakub Kicinski <kuba@kernel.org>
To: Andrey Shumilin <shum.sdl@nppct.ru>
Cc: 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org, khoroshilov@ispras.ru,
ykarpov@ispras.ru, vmerzlyakov@ispras.ru, vefanov@ispras.ru
Subject: Re: [PATCH] iphase: Adding a null pointer check
Date: Wed, 8 Nov 2023 18:40:49 -0800 [thread overview]
Message-ID: <20231108184049.1f27de01@kernel.org> (raw)
In-Reply-To: <20231107123600.14529-1-shum.sdl@nppct.ru>
On Tue, 7 Nov 2023 15:36:00 +0300 Andrey Shumilin wrote:
> The pointer <dev->desc_tbl[i].iavcc> is dereferenced on line 195.
> Further in the code, it is checked for null on line 204.
> It is proposed to add a check before dereferencing the pointer.
How do you know this is the right way to address the problem.
Much easier to debug a crash than misbehaving driver.
This is ancient code, leave it be.
--
pw-bot: reject
pv-bot: nit
next prev parent reply other threads:[~2023-11-09 2:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 12:36 [PATCH] iphase: Adding a null pointer check Andrey Shumilin
2023-11-09 2:40 ` Jakub Kicinski [this message]
2024-01-08 17:28 ` Alexey Khoroshilov
-- strict thread matches above, loose matches on Subject: below --
2024-03-23 6:38 Andrey Shumilin
2024-03-23 16:27 ` Simon Horman
2023-11-07 11:24 Andrey Shumilin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231108184049.1f27de01@kernel.org \
--to=kuba@kernel.org \
--cc=3chas3@gmail.com \
--cc=khoroshilov@ispras.ru \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=shum.sdl@nppct.ru \
--cc=vefanov@ispras.ru \
--cc=vmerzlyakov@ispras.ru \
--cc=ykarpov@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.