Re: [Buildroot] [PATCH] support/testing/tests/package/test_ruby.py: new runtime test

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Waldmar,

On Mon, 18 Sep 2023 10:25:11 +0200
Waldemar Brodkorb <wbx@openadk.org> wrote:

> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
>  support/testing/tests/package/test_ruby.py | 42 ++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 support/testing/tests/package/test_ruby.py

The entry in the DEVELOPERS file was missing.

> diff --git a/support/testing/tests/package/test_ruby.py b/support/testing/tests/package/test_ruby.py
> new file mode 100644
> index 0000000000..bedd9afb1c
> --- /dev/null
> +++ b/support/testing/tests/package/test_ruby.py
> @@ -0,0 +1,42 @@
> +import os
> +
> +import infra.basetest
> +
> +
> +class TestRubyBase(infra.basetest.BRTest):
> +    config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
> +        """
> +        BR2_TARGET_ROOTFS_CPIO=y
> +        # BR2_TARGET_ROOTFS_TAR is not set
> +        """
> +    interpreter = "ruby"
> +
> +    def login(self):
> +        cpio_file = os.path.join(self.builddir, "images", "rootfs.cpio")
> +        self.emulator.boot(arch="armv5",
> +                           kernel="builtin",
> +                           options=["-initrd", cpio_file])
> +        self.emulator.login()
> +
> +class TestRuby(TestRubyBase):

With just one test, there really wasn't a good reason to split into two
classes. So I've re-grouped the whole thing into just one class. We can
always split things later if we get more tests, and we need to
factorize some parts.

Applied with those changes, thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot