From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: sound/soc/codecs/aw88399.c:1700 aw88399_request_firmware_file() warn: '&cont' from request_firmware() not released on lines: 1681,1690,1700.
Date: Thu, 9 Nov 2023 03:09:30 +0800 [thread overview]
Message-ID: <202311090211.W4fxFXHT-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Weidong Wang <wangweidong.a@awinic.com>
CC: Mark Brown <broonie@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 90450a06162e6c71ab813ea22a83196fe7cff4bc
commit: 8ade6cc7e26175529474690fdbc1965901ec2024 ASoC: codecs: Add aw88399 amplifier driver
date: 2 weeks ago
:::::: branch date: 71 minutes ago
:::::: commit date: 2 weeks ago
config: i386-randconfig-141-20231108 (https://download.01.org/0day-ci/archive/20231109/202311090211.W4fxFXHT-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce: (https://download.01.org/0day-ci/archive/20231109/202311090211.W4fxFXHT-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202311090211.W4fxFXHT-lkp@intel.com/
New smatch warnings:
sound/soc/codecs/aw88399.c:1700 aw88399_request_firmware_file() warn: '&cont' from request_firmware() not released on lines: 1681,1690,1700.
Old smatch warnings:
sound/soc/codecs/aw88399.c:441 aw_dev_set_vcalb() error: uninitialized symbol 'vsense_select'.
sound/soc/codecs/aw88399.c:963 aw_dev_check_sram() error: uninitialized symbol 'reg_val'.
vim +1700 sound/soc/codecs/aw88399.c
8ade6cc7e26175 Weidong Wang 2023-10-25 1660
8ade6cc7e26175 Weidong Wang 2023-10-25 1661 static int aw88399_request_firmware_file(struct aw88399 *aw88399)
8ade6cc7e26175 Weidong Wang 2023-10-25 1662 {
8ade6cc7e26175 Weidong Wang 2023-10-25 1663 const struct firmware *cont = NULL;
8ade6cc7e26175 Weidong Wang 2023-10-25 1664 int ret;
8ade6cc7e26175 Weidong Wang 2023-10-25 1665
8ade6cc7e26175 Weidong Wang 2023-10-25 1666 aw88399->aw_pa->fw_status = AW88399_DEV_FW_FAILED;
8ade6cc7e26175 Weidong Wang 2023-10-25 1667
8ade6cc7e26175 Weidong Wang 2023-10-25 1668 ret = request_firmware(&cont, AW88399_ACF_FILE, aw88399->aw_pa->dev);
8ade6cc7e26175 Weidong Wang 2023-10-25 1669 if (ret) {
8ade6cc7e26175 Weidong Wang 2023-10-25 1670 dev_err(aw88399->aw_pa->dev, "request [%s] failed!", AW88399_ACF_FILE);
8ade6cc7e26175 Weidong Wang 2023-10-25 1671 return ret;
8ade6cc7e26175 Weidong Wang 2023-10-25 1672 }
8ade6cc7e26175 Weidong Wang 2023-10-25 1673
8ade6cc7e26175 Weidong Wang 2023-10-25 1674 dev_dbg(aw88399->aw_pa->dev, "loaded %s - size: %zu\n",
8ade6cc7e26175 Weidong Wang 2023-10-25 1675 AW88399_ACF_FILE, cont ? cont->size : 0);
8ade6cc7e26175 Weidong Wang 2023-10-25 1676
8ade6cc7e26175 Weidong Wang 2023-10-25 1677 aw88399->aw_cfg = devm_kzalloc(aw88399->aw_pa->dev,
8ade6cc7e26175 Weidong Wang 2023-10-25 1678 struct_size(aw88399->aw_cfg, data, cont->size), GFP_KERNEL);
8ade6cc7e26175 Weidong Wang 2023-10-25 1679 if (!aw88399->aw_cfg) {
8ade6cc7e26175 Weidong Wang 2023-10-25 1680 release_firmware(cont);
8ade6cc7e26175 Weidong Wang 2023-10-25 1681 return -ENOMEM;
8ade6cc7e26175 Weidong Wang 2023-10-25 1682 }
8ade6cc7e26175 Weidong Wang 2023-10-25 1683 aw88399->aw_cfg->len = (int)cont->size;
8ade6cc7e26175 Weidong Wang 2023-10-25 1684 memcpy(aw88399->aw_cfg->data, cont->data, cont->size);
8ade6cc7e26175 Weidong Wang 2023-10-25 1685 release_firmware(cont);
8ade6cc7e26175 Weidong Wang 2023-10-25 1686
8ade6cc7e26175 Weidong Wang 2023-10-25 1687 ret = aw88395_dev_load_acf_check(aw88399->aw_pa, aw88399->aw_cfg);
8ade6cc7e26175 Weidong Wang 2023-10-25 1688 if (ret) {
8ade6cc7e26175 Weidong Wang 2023-10-25 1689 dev_err(aw88399->aw_pa->dev, "load [%s] failed!", AW88399_ACF_FILE);
8ade6cc7e26175 Weidong Wang 2023-10-25 1690 return ret;
8ade6cc7e26175 Weidong Wang 2023-10-25 1691 }
8ade6cc7e26175 Weidong Wang 2023-10-25 1692
8ade6cc7e26175 Weidong Wang 2023-10-25 1693 mutex_lock(&aw88399->lock);
8ade6cc7e26175 Weidong Wang 2023-10-25 1694 /* aw device init */
8ade6cc7e26175 Weidong Wang 2023-10-25 1695 ret = aw88399_dev_init(aw88399, aw88399->aw_cfg);
8ade6cc7e26175 Weidong Wang 2023-10-25 1696 if (ret)
8ade6cc7e26175 Weidong Wang 2023-10-25 1697 dev_err(aw88399->aw_pa->dev, "dev init failed");
8ade6cc7e26175 Weidong Wang 2023-10-25 1698 mutex_unlock(&aw88399->lock);
8ade6cc7e26175 Weidong Wang 2023-10-25 1699
8ade6cc7e26175 Weidong Wang 2023-10-25 @1700 return ret;
8ade6cc7e26175 Weidong Wang 2023-10-25 1701 }
8ade6cc7e26175 Weidong Wang 2023-10-25 1702
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-11-08 19:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 19:09 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-11-09 19:30 sound/soc/codecs/aw88399.c:1700 aw88399_request_firmware_file() warn: '&cont' from request_firmware() not released on lines: 1681,1690,1700 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202311090211.W4fxFXHT-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.