All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Gregory Etelson <getelson@nvidia.com>
Cc: <dev@dpdk.org>, <ferruh.yigit@amd.com>, <mkashani@nvidia.com>,
	Ori Kam <orika@nvidia.com>,
	Aman Singh <aman.deep.singh@intel.com>,
	Yuying Zhang <yuying.zhang@intel.com>
Subject: Re: [PATCH v2] app/testpmd: fix indirect action list parameters parsing
Date: Thu, 9 Nov 2023 11:41:37 -0800	[thread overview]
Message-ID: <20231109114137.7cf4292c@hermes.local> (raw)
In-Reply-To: <20231109183637.498742-1-getelson@nvidia.com>

On Thu, 9 Nov 2023 20:36:37 +0200
Gregory Etelson <getelson@nvidia.com> wrote:

> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 0d521159e9..397f9bc3eb 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -11331,7 +11331,7 @@ parse_indlst_id2ptr(struct context *ctx, const struct token *token,
>  	struct rte_flow_action *action = ctx->object;
>  	struct rte_flow_action_indirect_list *action_conf;
>  	const struct indlst_conf *indlst_conf;
> -	uint32_t id;
> +	uintptr_t id;
>  	int ret;
>  
>  	if (!action)
> @@ -11350,7 +11350,8 @@ parse_indlst_id2ptr(struct context *ctx, const struct token *token,
>  	action_conf->handle = (typeof(action_conf->handle))
>  				port_action_handle_get_by_id(ctx->port, id);
>  		if (!action_conf->handle) {
> -			printf("no indirect list handle for id %u\n", id);
> +			printf("no indirect list handle for id %"PRIu64"\n",
> +			       id);

On 32 bit platforms uintptr_t is 32 bits.
Uintptr_t is always a typedef for unsigned long so use %lu here instead.

  reply	other threads:[~2023-11-09 19:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-08 16:34 [PATCH] app/testpmd: fix indirect action list parameters parsing Gregory Etelson
2023-11-09 16:16 ` Ferruh Yigit
2023-11-09 18:22   ` Etelson, Gregory
2023-11-09 19:03     ` Ferruh Yigit
2023-11-09 19:57       ` Etelson, Gregory
2023-11-10 14:51         ` Ferruh Yigit
2023-11-10 17:41           ` Etelson, Gregory
2023-11-10 20:15             ` Ferruh Yigit
2023-11-10 21:22               ` Etelson, Gregory
2023-11-09 18:36 ` [PATCH v2] " Gregory Etelson
2023-11-09 19:41   ` Stephen Hemminger [this message]
2023-11-09 20:01     ` Bruce Richardson
2023-11-10  7:04 ` [PATCH v3] app/testpmd: fix indirect action list ID size Gregory Etelson
2023-11-10 23:40   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231109114137.7cf4292c@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=aman.deep.singh@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=getelson@nvidia.com \
    --cc=mkashani@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.