From: Manivannan Sadhasivam <mani@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Bart Van Assche <bvanassche@acm.org>,
Ziqi Chen <quic_ziqichen@quicinc.com>,
quic_asutoshd@quicinc.com, quic_cang@quicinc.com,
beanhuo@micron.com, avri.altman@wdc.com,
junwoo80.lee@samsung.com, martin.petersen@oracle.com,
quic_nguyenb@quicinc.com, quic_nitirawa@quicinc.com,
quic_rampraka@quicinc.com, linux-scsi@vger.kernel.org,
Alim Akhtar <alim.akhtar@samsung.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Wolfram Sang <wsa@kernel.org>, Guenter Roeck <linux@roeck-us.net>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Mark Brown <broonie@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: ufs: Add msi-parent for UFS MCQ
Date: Thu, 9 Nov 2023 21:46:56 +0530 [thread overview]
Message-ID: <20231109161656.GH3752@thinkpad> (raw)
In-Reply-To: <CAL_Jsq+XB5p_K3C+rc5XetQ-Xfxu4umNFzcF0idB2hhZvS7HLA@mail.gmail.com>
On Thu, Nov 09, 2023 at 07:55:14AM -0600, Rob Herring wrote:
> On Mon, Nov 6, 2023 at 11:56 AM Bart Van Assche <bvanassche@acm.org> wrote:
> >
> > On 11/6/23 06:48, Rob Herring wrote:
> > > On Wed, Nov 01, 2023 at 06:48:13PM +0800, Ziqi Chen wrote:
> > >> The Message Signaled Interrupts (MSI) has been introduced
> > >> to UFS driver since the MCQ be enabled.
> > >
> > > Not really relevant when a driver supported MSI, but the when the h/w
> > > did. Has UFS always supported MSI? It was added in some version of the
> > > spec?
> >
> > MSI support has been introduced in UFSHCI version 4.0 and I think that
> > the controller vendor can decide whether or not to implement MSI. Does
> > this mean that the patch needs to be improved?
>
> Yes, this information is what should be in the commit msg rather than
> driver details.
>
Yes, agreed. Ziqi, please update the commit message to incorporate the hw
details about when MCQ/MSI got introduced. Devicetree binding should describe
the hw, not the driver.
- Mani
> Rob
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2023-11-09 16:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 10:48 [PATCH] dt-bindings: ufs: Add msi-parent for UFS MCQ Ziqi Chen
2023-11-06 14:48 ` Rob Herring
2023-11-06 17:56 ` Bart Van Assche
2023-11-09 10:51 ` Ziqi Chen
2023-11-09 13:55 ` Rob Herring
2023-11-09 16:16 ` Manivannan Sadhasivam [this message]
2023-11-10 5:50 ` Ziqi Chen
2023-11-21 9:26 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231109161656.GH3752@thinkpad \
--to=mani@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=broonie@kernel.org \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=junwoo80.lee@samsung.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=martin.petersen@oracle.com \
--cc=miquel.raynal@bootlin.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_rampraka@quicinc.com \
--cc=quic_ziqichen@quicinc.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.