From: Petr Vorel <pvorel@suse.cz>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 1/1] samsung: Sort Makefile
Date: Fri, 10 Nov 2023 07:34:56 +0100 [thread overview]
Message-ID: <20231110063456.GB1536739@pevik> (raw)
In-Reply-To: <f7dd78c9-2020-4874-a49e-02a782dcb2a4@kernel.org>
Hi Krzysztof,
> On 09/11/2023 17:38, Krzysztof Kozlowski wrote:
> > On 08/11/2023 10:01, Petr Vorel wrote:
> >> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> >> ---
> You also lack commit msg explaining why doing this.
I'm sorry, I thought the reason is obvious - readability.
Some Makefiles are tried to be sorted (e.g. drivers/clk/qcom/Makefile),
but lots of them are not (drivers/net/Makefile). Anyway, it's up to you (and
other maintainers) to judge if it's useful or not. If considered useful, I'll
send v2.
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching.
Ah, I'm sorry. I did this actually (do that each time I send patch for kernel),
but I somehow overlooked "clk: ".
Kind regards,
Petr
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2023-11-10 19:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 9:01 [PATCH 1/1] samsung: Sort Makefile Petr Vorel
2023-11-09 16:38 ` Krzysztof Kozlowski
2023-11-09 16:39 ` Krzysztof Kozlowski
2023-11-10 6:34 ` Petr Vorel [this message]
2023-11-10 8:06 ` Krzysztof Kozlowski
2023-11-10 9:46 ` Petr Vorel
2023-11-10 6:25 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231110063456.GB1536739@pevik \
--to=pvorel@suse.cz \
--cc=krzk@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.