From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C061C4332F for ; Fri, 10 Nov 2023 18:24:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345433AbjKJSYz (ORCPT ); Fri, 10 Nov 2023 13:24:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345765AbjKJSXx (ORCPT ); Fri, 10 Nov 2023 13:23:53 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B98923975C; Fri, 10 Nov 2023 06:39:03 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0380EC433C7; Fri, 10 Nov 2023 14:39:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699627143; bh=s66gHHjMySKSZbn63cKJJA1Bvs2R0xW/wRdb8aMe4VM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=VFN97HdpzS3TdmFDybUTeRVCW09lhWWC4tRqyIS+CJOfjgUOb1/QZsUqBsh3Faud+ 8/VXIg+r7JgsdtSQWbNI2dCwUuSNis7hCZ33JkThOLGRHDkoGeIPItVjODWGpXGlAN e6htKbqPWQndkLiBSKa9sBfFQ/WvtOKbM81ZhJZTXZGfQzp3IIbfkgytF88bTCD2E1 WEahUa7JQGdec/XKOTdqLY2Nt9mBw1QeII28O3HYEF3X4JUDc76LlLvvXbfIe9ZxJ4 z++kez5RnEOipVViYdFHeoIgvWNLwwBN8Ux9Yha2VY9K+lV8BXD9edSHk8hgkbXiMO cHYbRBuQqKKow== Date: Fri, 10 Nov 2023 08:39:01 -0600 From: Bjorn Helgaas To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, Jim Quinlan , Florian Fainelli , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v7 2/3] PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream device Message-ID: <20231110143901.GA540912@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Nov 10, 2023 at 08:01:23AM -0500, Jim Quinlan wrote: > On Thu, Nov 9, 2023 at 5:31 PM Bjorn Helgaas wrote: > > > > On Thu, Nov 09, 2023 at 05:06:15PM -0500, Jim Quinlan wrote: > > > ... > > > > > BTW, besides the RPi4, I haven't been able to find a Linux platform > > > where I can do > > > > > > echo $POLICY > /sys/module/pcie_aspm/parameters/policy > > > > This sounds like something we should fix. What exactly happens? I > > think this should be handled at pcie_aspm_set_policy(), so: > > Well, I've tried changing the ASPM policy on my x86 Ubuntu system > and IIRC a Fedora system. In both cases it says "illegal write > operation" but I am root and the "policy" file does have rw perms > for root, so I have no idea how it comes back with that error. Some > machines allow one to change the setting in the BIOS, FWIW. BIOS settings like that are potentially misleading unless the BIOS *also* retains ownership of ASPM or changes the ASPM features advertised by devices. If BIOS grants ASPM ownership to the OS, BIOS should not assume anything about how the OS will configure ASPM. > Right now on my CM4, "echo $POLICY > policy" actually works. > Perhaps when I was testing this I did not yet apply my commits, or > perhaps it was with a specific endpoint device. Regardless, I'll > let you know with a backtrace if I see this again. Great, thanks! Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BC00C4332F for ; Fri, 10 Nov 2023 14:39:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=WAsonpS9haMds+mSSH0qXxdlXC+bepZ8RjHCOMPs6QQ=; b=BZCOvqLP/ROX1J L561PKdWQuqt2RRTj5Mqbc3LvU8pGcEugzN86tz7Mm6mimhUsHHyg6t2W52mDdIvkIZV3iAql0Bjv qroVde7eH8tNdb2OvG1f6V/24tsI6jaP8nf0dV3q6Rq3TaShD0gZpQPq5brFn8SWyUtoqTiN9YjrM wiIiDq03Mk247QrAD/SuDRcczQu74HAnkbLDz4DykIc2dCPkjJL9gxLau9EFu1zqYj6/FT9PB0JrQ IhRM+6YThedCu1avf6ndlfJHokn2nfLn+6pLhMn0FyjlMD2KnXEig2z1QQKYH95bSSN/+7+iFcp6E TAQSa62mb/KLSO4420hw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r1Sf5-008w6j-0B; Fri, 10 Nov 2023 14:39:07 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r1Sf2-008w6G-1S; Fri, 10 Nov 2023 14:39:05 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A8DED619BF; Fri, 10 Nov 2023 14:39:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0380EC433C7; Fri, 10 Nov 2023 14:39:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699627143; bh=s66gHHjMySKSZbn63cKJJA1Bvs2R0xW/wRdb8aMe4VM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=VFN97HdpzS3TdmFDybUTeRVCW09lhWWC4tRqyIS+CJOfjgUOb1/QZsUqBsh3Faud+ 8/VXIg+r7JgsdtSQWbNI2dCwUuSNis7hCZ33JkThOLGRHDkoGeIPItVjODWGpXGlAN e6htKbqPWQndkLiBSKa9sBfFQ/WvtOKbM81ZhJZTXZGfQzp3IIbfkgytF88bTCD2E1 WEahUa7JQGdec/XKOTdqLY2Nt9mBw1QeII28O3HYEF3X4JUDc76LlLvvXbfIe9ZxJ4 z++kez5RnEOipVViYdFHeoIgvWNLwwBN8Ux9Yha2VY9K+lV8BXD9edSHk8hgkbXiMO cHYbRBuQqKKow== Date: Fri, 10 Nov 2023 08:39:01 -0600 From: Bjorn Helgaas To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, Jim Quinlan , Florian Fainelli , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v7 2/3] PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream device Message-ID: <20231110143901.GA540912@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231110_063904_536103_00C2742A X-CRM114-Status: GOOD ( 20.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBOb3YgMTAsIDIwMjMgYXQgMDg6MDE6MjNBTSAtMDUwMCwgSmltIFF1aW5sYW4gd3Jv dGU6Cj4gT24gVGh1LCBOb3YgOSwgMjAyMyBhdCA1OjMx4oCvUE0gQmpvcm4gSGVsZ2FhcyA8aGVs Z2Fhc0BrZXJuZWwub3JnPiB3cm90ZToKPiA+Cj4gPiBPbiBUaHUsIE5vdiAwOSwgMjAyMyBhdCAw NTowNjoxNVBNIC0wNTAwLCBKaW0gUXVpbmxhbiB3cm90ZToKPiA+ID4gLi4uCj4gPgo+ID4gPiBC VFcsIGJlc2lkZXMgdGhlIFJQaTQsIEkgaGF2ZW4ndCBiZWVuIGFibGUgdG8gZmluZCBhIExpbnV4 IHBsYXRmb3JtCj4gPiA+IHdoZXJlIEkgY2FuIGRvCj4gPiA+Cj4gPiA+ICAgICAgICAgZWNobyAk UE9MSUNZID4gL3N5cy9tb2R1bGUvcGNpZV9hc3BtL3BhcmFtZXRlcnMvcG9saWN5Cj4gPgo+ID4g VGhpcyBzb3VuZHMgbGlrZSBzb21ldGhpbmcgd2Ugc2hvdWxkIGZpeC4gIFdoYXQgZXhhY3RseSBo YXBwZW5zPyAgSQo+ID4gdGhpbmsgdGhpcyBzaG91bGQgYmUgaGFuZGxlZCBhdCBwY2llX2FzcG1f c2V0X3BvbGljeSgpLCBzbzoKPiAKPiBXZWxsLCBJJ3ZlIHRyaWVkIGNoYW5naW5nIHRoZSBBU1BN IHBvbGljeSBvbiBteSB4ODYgVWJ1bnR1IHN5c3RlbQo+IGFuZCBJSVJDIGEgRmVkb3JhIHN5c3Rl bS4gIEluIGJvdGggY2FzZXMgaXQgc2F5cyAiaWxsZWdhbCB3cml0ZQo+IG9wZXJhdGlvbiIgYnV0 IEkgYW0gcm9vdCBhbmQgdGhlICJwb2xpY3kiIGZpbGUgZG9lcyBoYXZlIHJ3IHBlcm1zCj4gZm9y IHJvb3QsIHNvIEkgaGF2ZSBubyBpZGVhIGhvdyBpdCBjb21lcyBiYWNrIHdpdGggdGhhdCBlcnJv ci4gIFNvbWUKPiBtYWNoaW5lcyBhbGxvdyBvbmUgdG8gY2hhbmdlIHRoZSBzZXR0aW5nIGluIHRo ZSBCSU9TLCBGV0lXLgoKQklPUyBzZXR0aW5ncyBsaWtlIHRoYXQgYXJlIHBvdGVudGlhbGx5IG1p c2xlYWRpbmcgdW5sZXNzIHRoZSBCSU9TCiphbHNvKiByZXRhaW5zIG93bmVyc2hpcCBvZiBBU1BN IG9yIGNoYW5nZXMgdGhlIEFTUE0gZmVhdHVyZXMKYWR2ZXJ0aXNlZCBieSBkZXZpY2VzLiAgSWYg QklPUyBncmFudHMgQVNQTSBvd25lcnNoaXAgdG8gdGhlIE9TLCBCSU9TCnNob3VsZCBub3QgYXNz dW1lIGFueXRoaW5nIGFib3V0IGhvdyB0aGUgT1Mgd2lsbCBjb25maWd1cmUgQVNQTS4KCj4gUmln aHQgbm93IG9uIG15IENNNCwgImVjaG8gJFBPTElDWSAgPiBwb2xpY3kiIGFjdHVhbGx5IHdvcmtz Lgo+IFBlcmhhcHMgd2hlbiBJIHdhcyB0ZXN0aW5nIHRoaXMgSSBkaWQgbm90IHlldCBhcHBseSBt eSBjb21taXRzLCBvcgo+IHBlcmhhcHMgaXQgd2FzIHdpdGggYSBzcGVjaWZpYyBlbmRwb2ludCBk ZXZpY2UuICBSZWdhcmRsZXNzLCBJJ2xsCj4gbGV0IHlvdSBrbm93IHdpdGggYSBiYWNrdHJhY2Ug aWYgSSBzZWUgdGhpcyBhZ2Fpbi4KCkdyZWF0LCB0aGFua3MhCgpCam9ybgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=