Re: [RFC ipsec-next 8/8] iptfs: impl: add new iptfs xfrm mode impl

[kernel test robot <lkp@intel.com>]

Hi Christian,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on klassert-ipsec-next/master]
[also build test WARNING on klassert-ipsec/master netfilter-nf/main linus/master v6.6 next-20231110]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Hopps/iptfs-uapi-ip-add-ip_tfs_-_hdr-packet-formats/20231110-203822
base:   https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git master
patch link:    https://lore.kernel.org/r/20231110113719.3055788-9-chopps%40chopps.org
patch subject: [RFC ipsec-next 8/8] iptfs: impl: add new iptfs xfrm mode impl
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231111/202311110139.kmpx4546-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231111/202311110139.kmpx4546-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311110139.kmpx4546-lkp@intel.com/

All warnings (new ones prefixed by >>):

   net/xfrm/xfrm_iptfs.c:468:17: warning: no previous prototype for 'iptfs_pskb_add_frags' [-Wmissing-prototypes]
     468 | struct sk_buff *iptfs_pskb_add_frags(struct sk_buff *tpl,
         |                 ^~~~~~~~~~~~~~~~~~~~
   net/xfrm/xfrm_iptfs.c: In function '__iptfs_reassem_done':
   net/xfrm/xfrm_iptfs.c:629:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     629 |         int ret;
         |             ^~~
   net/xfrm/xfrm_iptfs.c: In function '__reorder_drop':
   net/xfrm/xfrm_iptfs.c:1262:13: warning: variable 'wantseq' set but not used [-Wunused-but-set-variable]
    1262 |         u64 wantseq = xtfs->w_wantseq;
         |             ^~~~~~~
   net/xfrm/xfrm_iptfs.c: In function '__reorder_this':
   net/xfrm/xfrm_iptfs.c:1311:13: warning: variable 'wantseq' set but not used [-Wunused-but-set-variable]
    1311 |         u64 wantseq = xtfs->w_wantseq;
         |             ^~~~~~~
   net/xfrm/xfrm_iptfs.c: In function '__reorder_future_shifts':
   net/xfrm/xfrm_iptfs.c:1433:13: warning: variable 'last_drop_seq' set but not used [-Wunused-but-set-variable]
    1433 |         u64 last_drop_seq = xtfs->w_wantseq;
         |             ^~~~~~~~~~~~~
   net/xfrm/xfrm_iptfs.c: In function 'iptfs_drop_timer':
   net/xfrm/xfrm_iptfs.c:1653:20: warning: variable 'fcount' set but not used [-Wunused-but-set-variable]
    1653 |         u32 count, fcount;
         |                    ^~~~~~
   net/xfrm/xfrm_iptfs.c: In function 'iptfs_delay_timer':
   net/xfrm/xfrm_iptfs.c:2396:16: warning: variable 'osize' set but not used [-Wunused-but-set-variable]
    2396 |         size_t osize;
         |                ^~~~~
   net/xfrm/xfrm_iptfs.c: In function 'iptfs_encap_add_ipv4':
   net/xfrm/xfrm_iptfs.c:2444:13: warning: variable 'flags' set but not used [-Wunused-but-set-variable]
    2444 |         int flags;
         |             ^~~~~
   net/xfrm/xfrm_iptfs.c: At top level:
>> net/xfrm/xfrm_iptfs.c:100:12: warning: '__trace_ip_proto_seq' defined but not used [-Wunused-function]
     100 | static u32 __trace_ip_proto_seq(struct iphdr *iph)
         |            ^~~~~~~~~~~~~~~~~~~~


vim +/__trace_ip_proto_seq +100 net/xfrm/xfrm_iptfs.c

    99	
 > 100	static u32 __trace_ip_proto_seq(struct iphdr *iph)
   101	{
   102		void *nexthdr;
   103		u32 protocol = 0;
   104	
   105		if (iph->version == 4) {
   106			nexthdr = (void *)(iph + 1);
   107			protocol = iph->protocol;
   108		} else if (iph->version == 6) {
   109			nexthdr = (void *)(((struct ipv6hdr *)(iph)) + 1);
   110			protocol = ((struct ipv6hdr *)(iph))->nexthdr;
   111		}
   112		switch (protocol) {
   113		case IPPROTO_ICMP:
   114			return ntohs(((struct icmphdr *)nexthdr)->un.echo.sequence);
   115		case IPPROTO_ICMPV6:
   116			return ntohs(((struct icmp6hdr *)nexthdr)->icmp6_sequence);
   117		case IPPROTO_TCP:
   118			return ntohl(((struct tcphdr *)nexthdr)->seq);
   119		case IPPROTO_UDP:
   120			return ntohs(((struct udphdr *)nexthdr)->source);
   121		default:
   122			return 0;
   123		}
   124	}
   125	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki