From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, "Morten Brørup" <mb@smartsharesystems.com>,
"Jerin Jacob" <jerinj@marvell.com>
Subject: Re: [PATCH v4] eventdev: ensure 16-byte alignment for events
Date: Sat, 11 Nov 2023 16:01:04 -0800 [thread overview]
Message-ID: <20231111160104.49360157@hermes.local> (raw)
In-Reply-To: <20231006102932.164630-1-bruce.richardson@intel.com>
On Fri, 6 Oct 2023 11:29:32 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:
> diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c
> index 95373bbaad..adc9751cef 100644
> --- a/lib/eventdev/rte_eventdev.c
> +++ b/lib/eventdev/rte_eventdev.c
> @@ -9,6 +9,7 @@
> #include <errno.h>
> #include <stdint.h>
> #include <inttypes.h>
> +#include <assert.h>
>
> #include <rte_string_fns.h>
> #include <rte_log.h>
> @@ -28,6 +29,8 @@
> #include "eventdev_pmd.h"
> #include "eventdev_trace.h"
>
> +static_assert(sizeof(struct rte_event) == 16, "Event structure size is not 16-bytes in size");
> +
> static struct rte_eventdev rte_event_devices[RTE_EVENT_MAX_DEVS];
Please don't reinvent RTE_BUILD_BUG_ON().
Instead fix that to be a static_assert()
next prev parent reply other threads:[~2023-11-12 0:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 11:51 [RFC PATCH] eventdev: ensure 16-byte alignment for events Bruce Richardson
2023-10-05 12:06 ` Bruce Richardson
2023-10-05 13:11 ` Jerin Jacob
2023-10-05 13:15 ` Bruce Richardson
2023-10-06 7:19 ` Jerin Jacob
2023-10-05 12:12 ` Morten Brørup
2023-10-05 13:02 ` Bruce Richardson
2023-10-06 9:37 ` [PATCH v2] " Bruce Richardson
2023-10-06 9:45 ` [PATCH v3] " Bruce Richardson
2023-10-06 10:13 ` Morten Brørup
2023-10-06 10:16 ` Jerin Jacob
2023-10-06 10:19 ` Bruce Richardson
2023-10-06 10:24 ` Jerin Jacob
2023-10-06 10:27 ` Bruce Richardson
2023-10-06 10:16 ` Bruce Richardson
2023-10-06 10:35 ` Morten Brørup
2023-10-06 10:44 ` Bruce Richardson
2023-10-06 10:29 ` [PATCH v4] " Bruce Richardson
2023-11-12 0:01 ` Stephen Hemminger [this message]
2023-11-12 8:30 ` Morten Brørup
2023-11-12 23:31 ` Stephen Hemminger
2023-11-13 7:58 ` Morten Brørup
2024-01-19 21:05 ` Tyler Retzlaff
2023-10-06 12:15 ` [RFC PATCH] " Mattias Rönnblom
2023-10-06 12:19 ` Bruce Richardson
2023-10-06 12:29 ` Mattias Rönnblom
2024-01-19 22:30 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231111160104.49360157@hermes.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.