From: Stephen Hemminger <stephen@networkplumber.org>
To: Ivan Malov <ivan.malov@arknetworks.am>
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, dev@dpdk.org
Subject: Re: BUILD bug hidden in SFC driver.
Date: Mon, 13 Nov 2023 08:30:42 -0800 [thread overview]
Message-ID: <20231113083042.73436883@hermes.local> (raw)
In-Reply-To: <97a09c56-d946-8c0b-85e2-c2ea4ce25dd6@arknetworks.am>
On Mon, 13 Nov 2023 16:04:51 +0400 (+04)
Ivan Malov <ivan.malov@arknetworks.am> wrote:
> diff --git a/drivers/net/sfc/sfc_ef100_tx.c b/drivers/net/sfc/sfc_ef100_tx.c
> index 1b6374775f..01f37c2616 100644
> --- a/drivers/net/sfc/sfc_ef100_tx.c
> +++ b/drivers/net/sfc/sfc_ef100_tx.c
> @@ -563,7 +563,7 @@ sfc_ef100_tx_pkt_descs_max(const struct rte_mbuf *m)
> * (split into many Tx descriptors).
> */
> RTE_BUILD_BUG_ON(SFC_EF100_TX_SEND_DESC_LEN_MAX <
> - RTE_MIN((unsigned int)EFX_MAC_PDU_MAX,
> + MIN((unsigned int)EFX_MAC_PDU_MAX,
> SFC_MBUF_SEG_LEN_MAX));
> }
>
> with MIN being defined in drivers/common/sfc_efx/efsys.h as
> #define MIN(v1, v2) ((v1) < (v2) ? (v1) : (v2))
That should work.
next prev parent reply other threads:[~2023-11-13 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 16:56 BUILD bug hidden in SFC driver Stephen Hemminger
2023-11-11 17:29 ` Stephen Hemminger
2023-11-13 12:04 ` Ivan Malov
2023-11-13 16:30 ` Stephen Hemminger [this message]
2023-11-13 16:28 ` Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231113083042.73436883@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ivan.malov@arknetworks.am \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.