From: Tony Lindgren <tony@atomide.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"John Ogness" <john.ogness@linutronix.de>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Thomas Richard" <thomas.richard@bootlin.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Thomas Gleixner" <tglx@linutronix.de>,
kernel@pengutronix.de, linux-serial@vger.kernel.org
Subject: Re: [PATCH 01/52] serial: 8250: omap: Don't skip resource freeing if pm_runtime_resume_and_get() failed
Date: Mon, 13 Nov 2023 11:49:29 +0200 [thread overview]
Message-ID: <20231113094929.GA5166@atomide.com> (raw)
In-Reply-To: <20231110152927.70601-2-u.kleine-koenig@pengutronix.de>
* Uwe Kleine-König <u.kleine-koenig@pengutronix.de> [231110 15:30]:
> Returning an error code from .remove() makes the driver core emit the
> little helpful error message:
>
> remove callback returned a non-zero value. This will be ignored.
>
> and then remove the device anyhow. So all resources that were not freed
> are leaked in this case. Skipping serial8250_unregister_port() has the
> potential to keep enough of the UART around to trigger a use-after-free.
>
> So replace the error return (and with it the little helpful error
> message) by a more useful error message and continue to cleanup.
Looks good to me thanks:
Reviewed-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2023-11-13 9:56 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 15:29 [PATCH 00/52] serial: Convert to platform remove callback returning void Uwe Kleine-König
2023-11-10 15:29 ` Uwe Kleine-König
2023-11-10 15:29 ` Uwe Kleine-König
2023-11-10 15:29 ` Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 01/52] serial: 8250: omap: Don't skip resource freeing if pm_runtime_resume_and_get() failed Uwe Kleine-König
2023-11-13 9:49 ` Tony Lindgren [this message]
2023-11-10 15:29 ` [PATCH 02/52] serial: sccnxp: Improve error message if regulator_disable() fails Uwe Kleine-König
[not found] ` <1699851843.639333963@f702.i.mail.ru>
2023-11-13 8:57 ` Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 03/52] serial: 8250: Convert to platform remove callback returning void Uwe Kleine-König
2023-11-10 15:29 ` Uwe Kleine-König
2023-11-10 15:29 ` Uwe Kleine-König
2023-11-10 17:49 ` Florian Fainelli
2023-11-10 17:49 ` Florian Fainelli
2023-11-10 17:49 ` Florian Fainelli
2023-11-13 9:09 ` AngeloGioacchino Del Regno
2023-11-13 9:09 ` AngeloGioacchino Del Regno
2023-11-13 9:09 ` AngeloGioacchino Del Regno
2023-11-13 10:15 ` Geert Uytterhoeven
2023-11-13 10:15 ` Geert Uytterhoeven
2023-11-13 10:15 ` Geert Uytterhoeven
2023-11-22 23:23 ` Andi Shyti
2023-11-22 23:23 ` Andi Shyti
2023-11-22 23:23 ` Andi Shyti
2023-11-10 15:29 ` [PATCH 04/52] serial: altera_jtaguart: " Uwe Kleine-König
2023-11-16 13:32 ` Tobias Klauser
2023-11-10 15:29 ` [PATCH 05/52] serial: altera: " Uwe Kleine-König
2023-11-16 13:32 ` Tobias Klauser
2023-11-10 15:29 ` [PATCH 06/52] serial: amba-pl011: " Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 07/52] serial: ar933x: " Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 08/52] serial: atmel: " Uwe Kleine-König
2023-11-10 15:29 ` Uwe Kleine-König
2023-11-10 18:09 ` claudiu beznea
2023-11-10 18:09 ` claudiu beznea
2023-11-13 16:22 ` Richard Genoud
2023-11-13 16:22 ` Richard Genoud
2023-11-10 15:29 ` [PATCH 09/52] serial: bcm63xx: " Uwe Kleine-König
2023-11-10 17:03 ` Florian Fainelli
2023-11-10 15:29 ` [PATCH 10/52] serial: clps711x: " Uwe Kleine-König
2023-11-10 15:29 ` Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 11/52] serial: cpm: " Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 12/52] serial: digicolor: " Uwe Kleine-König
2023-11-10 15:29 ` Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 13/52] serial: esp32_acm: " Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 14/52] serial: esp32: " Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 15/52] serial: fsl_linflexuart: " Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 16/52] serial: fsl_lpuart: " Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 17/52] serial: imx: " Uwe Kleine-König
2023-11-10 15:29 ` Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 18/52] serial: lantiq: " Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 19/52] serial: liteuart: " Uwe Kleine-König
2023-11-10 18:09 ` Gabriel L. Somlo
2023-11-10 15:29 ` [PATCH 20/52] serial: lpc32xx_hs: " Uwe Kleine-König
2023-11-10 15:29 ` Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 21/52] serial: ma35d1: " Uwe Kleine-König
2023-11-10 15:29 ` Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 22/52] serial: mcf: " Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 23/52] serial: meson: " Uwe Kleine-König
2023-11-10 15:29 ` Uwe Kleine-König
2023-11-10 15:29 ` Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 24/52] serial: milbeaut_usio: " Uwe Kleine-König
2023-11-10 15:29 ` Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 25/52] serial: mpc52xx: " Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 26/52] serial: msm: " Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 27/52] serial: mxs-auart: " Uwe Kleine-König
2023-11-10 15:29 ` Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 28/52] serial: omap: " Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 29/52] serial: owl: " Uwe Kleine-König
2023-11-10 15:29 ` Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 30/52] serial: pic32: " Uwe Kleine-König
2023-11-10 15:29 ` [PATCH 31/52] serial: qcom_geni: " Uwe Kleine-König
2023-11-10 15:30 ` [PATCH 32/52] serial: rda: " Uwe Kleine-König
2023-11-10 15:30 ` Uwe Kleine-König
2023-11-10 15:30 ` [PATCH 33/52] serial: sa1100: " Uwe Kleine-König
2023-11-10 15:30 ` [PATCH 34/52] serial: samsung: " Uwe Kleine-König
2023-11-10 15:30 ` Uwe Kleine-König
2023-11-12 7:48 ` Krzysztof Kozlowski
2023-11-12 7:48 ` Krzysztof Kozlowski
2023-11-12 9:09 ` Uwe Kleine-König
2023-11-12 9:09 ` Uwe Kleine-König
2023-11-10 15:30 ` [PATCH 35/52] serial: sccnxp: " Uwe Kleine-König
2023-11-10 15:30 ` [PATCH 36/52] serial: tegra: " Uwe Kleine-König
2023-11-10 15:30 ` [PATCH 37/52] serial: txx9: " Uwe Kleine-König
2023-11-10 15:30 ` [PATCH 38/52] serial: sh-sci: " Uwe Kleine-König
2023-11-13 10:17 ` Geert Uytterhoeven
2023-11-10 15:30 ` [PATCH 39/52] serial: sifive: " Uwe Kleine-König
2023-11-10 15:30 ` Uwe Kleine-König
2023-11-10 17:31 ` Samuel Holland
2023-11-10 17:31 ` Samuel Holland
2023-11-10 15:30 ` [PATCH 40/52] serial: sprd: " Uwe Kleine-König
2023-11-13 2:20 ` Chunyan Zhang
2023-11-10 15:30 ` [PATCH 41/52] serial: st-asc: " Uwe Kleine-König
2023-11-10 15:30 ` Uwe Kleine-König
2023-11-10 15:30 ` [PATCH 42/52] serial: stm32: " Uwe Kleine-König
2023-11-10 15:30 ` Uwe Kleine-König
2023-11-10 15:30 ` [PATCH 43/52] serial: sunhv: " Uwe Kleine-König
2023-11-10 15:30 ` [PATCH 44/52] serial: sunplus: " Uwe Kleine-König
2023-11-10 15:30 ` [PATCH 45/52] serial: sunsab: " Uwe Kleine-König
2023-11-10 15:30 ` [PATCH 46/52] serial: sunsu: " Uwe Kleine-König
2023-11-10 15:30 ` [PATCH 47/52] serial: sunzilog: " Uwe Kleine-König
2023-11-10 15:30 ` [PATCH 48/52] serial: tegra-tcu: " Uwe Kleine-König
2023-11-10 15:30 ` [PATCH 49/52] serial: timbuart: " Uwe Kleine-König
2023-11-10 15:30 ` [PATCH 50/52] serial: uartlite: " Uwe Kleine-König
2023-11-10 15:30 ` [PATCH 51/52] serial: ucc: " Uwe Kleine-König
2023-11-10 15:30 ` Uwe Kleine-König
2023-11-10 15:30 ` [PATCH 52/52] serial: xilinx_uartps: " Uwe Kleine-König
2023-11-10 15:30 ` Uwe Kleine-König
2023-11-13 9:41 ` Michal Simek
2023-11-13 9:41 ` Michal Simek
2023-11-13 10:03 ` Uwe Kleine-König
2023-11-13 10:03 ` Uwe Kleine-König
2023-11-13 14:31 ` Greg Kroah-Hartman
2023-11-13 14:31 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231113094929.GA5166@atomide.com \
--to=tony@atomide.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-serial@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.richard@bootlin.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.