Re: |PATCH] stmmac: dwmac-loongson: Add architecture dependency

[Simon Horman <horms@kernel.org>]

On Mon, Nov 13, 2023 at 03:45:22PM +0100, Jean Delvare wrote:
> Only present the DWMAC_LOONGSON option on architectures where it can
> actually be used.
> 
> This follows the same logic as the DWMAC_INTEL option.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Keguang Zhang <keguang.zhang@gmail.com>
> ---
> I'm not familiar with the hardware, so please let me know if the
> dependency needs to be adjusted somehow.
> 
>  drivers/net/ethernet/stmicro/stmmac/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-6.6.orig/drivers/net/ethernet/stmicro/stmmac/Kconfig
> +++ linux-6.6/drivers/net/ethernet/stmicro/stmmac/Kconfig
> @@ -269,7 +269,7 @@ config DWMAC_INTEL
>  config DWMAC_LOONGSON
>  	tristate "Loongson PCI DWMAC support"
>  	default MACH_LOONGSON64
> -	depends on STMMAC_ETH && PCI
> +	depends on MACH_LOONGSON64 && STMMAC_ETH && PCI

Hi Jean,

Could we consider also allowing the build to occur if COMPILE_TEST is set?
This would maintain the current level of build test coverage.

Something line this (completely untested!):

	depends on (MACH_LOONGSON64 || COMPILE_TEST) && STMMAC_ETH && PCI

>  	depends on COMMON_CLK
>  	help
>  	  This selects the LOONGSON PCI bus support for the stmmac driver,
> 
> 
> -- 
> Jean Delvare
> SUSE L3 Support
>