From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Stefan Hajnoczi" <stefanha@redhat.com>,
"Janosch Frank" <frankja@linux.ibm.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PULL 1/3] target/s390x/dump: Remove unneeded dump info function pointer init
Date: Tue, 14 Nov 2023 12:43:16 +0100 [thread overview]
Message-ID: <20231114114318.158226-2-thuth@redhat.com> (raw)
In-Reply-To: <20231114114318.158226-1-thuth@redhat.com>
From: Janosch Frank <frankja@linux.ibm.com>
dump_state_prepare() now sets the function pointers to NULL so we only
need to touch them if we're going to use them.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20231109120443.185979-2-frankja@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
target/s390x/arch_dump.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/target/s390x/arch_dump.c b/target/s390x/arch_dump.c
index 51a2116515..bdb0bfa0e7 100644
--- a/target/s390x/arch_dump.c
+++ b/target/s390x/arch_dump.c
@@ -448,10 +448,6 @@ int cpu_get_dump_info(ArchDumpInfo *info,
info->arch_sections_add_fn = *arch_sections_add;
info->arch_sections_write_hdr_fn = *arch_sections_write_hdr;
info->arch_sections_write_fn = *arch_sections_write;
- } else {
- info->arch_sections_add_fn = NULL;
- info->arch_sections_write_hdr_fn = NULL;
- info->arch_sections_write_fn = NULL;
}
return 0;
}
--
2.41.0
next prev parent reply other threads:[~2023-11-14 11:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 11:43 [PULL 0/3] Fix s390x PV dumps in case of errors Thomas Huth
2023-11-14 11:43 ` Thomas Huth [this message]
2023-11-14 11:43 ` [PULL 2/3] dump: Add arch cleanup function Thomas Huth
2023-11-14 11:43 ` [PULL 3/3] target/s390x/arch_dump: Add arch cleanup function for PV dumps Thomas Huth
2023-11-14 17:32 ` [PULL 0/3] Fix s390x PV dumps in case of errors Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231114114318.158226-2-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.