From: Sui Jingfeng <sui.jingfeng@linux.dev>
To: Phong LE <ple@baylibre.com>, Neil Armstrong <neil.armstrong@linaro.org>
Cc: Maxime Ripard <mripard@kernel.org>,
Sui Jingfeng <suijingfeng@loongson.cn>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 3/8] drm/bridge: it66121: Add a helper function to read bus width
Date: Tue, 14 Nov 2023 23:01:25 +0800 [thread overview]
Message-ID: <20231114150130.497915-4-sui.jingfeng@linux.dev> (raw)
In-Reply-To: <20231114150130.497915-1-sui.jingfeng@linux.dev>
From: Sui Jingfeng <suijingfeng@loongson.cn>
Group those relavent code lines (which with common purpose) into one helper
function, suppress the dependency on DT to function level. Just trivial
cleanup, no functional change.
Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
---
drivers/gpu/drm/bridge/ite-it66121.c | 32 ++++++++++++++++++++--------
1 file changed, 23 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
index 83dbdbfc9ed8..0f78737adc83 100644
--- a/drivers/gpu/drm/bridge/ite-it66121.c
+++ b/drivers/gpu/drm/bridge/ite-it66121.c
@@ -320,6 +320,26 @@ static inline struct it66121_ctx *bridge_to_it66121(struct drm_bridge *bridge)
return container_of(bridge, struct it66121_ctx, bridge);
}
+static int it66121_of_read_bus_width(struct device *dev, u32 *bus_width)
+{
+ struct device_node *np;
+ u32 bw;
+
+ np = of_graph_get_endpoint_by_regs(dev->of_node, 0, 0);
+ if (!np)
+ return -EINVAL;
+
+ of_property_read_u32(np, "bus-width", &bw);
+ of_node_put(np);
+
+ if (bw != 12 && bw != 24)
+ return -EINVAL;
+
+ *bus_width = bw;
+
+ return 0;
+}
+
static const struct regmap_range_cfg it66121_regmap_banks[] = {
{
.name = "it66121",
@@ -1525,19 +1545,13 @@ static int it66121_probe(struct i2c_client *client)
if (!ctx)
return -ENOMEM;
- ep = of_graph_get_endpoint_by_regs(dev->of_node, 0, 0);
- if (!ep)
- return -EINVAL;
-
ctx->dev = dev;
ctx->client = client;
ctx->info = i2c_get_match_data(client);
- of_property_read_u32(ep, "bus-width", &ctx->bus_width);
- of_node_put(ep);
-
- if (ctx->bus_width != 12 && ctx->bus_width != 24)
- return -EINVAL;
+ ret = it66121_of_read_bus_width(dev, &ctx->bus_width);
+ if (ret)
+ return ret;
ep = of_graph_get_remote_node(dev->of_node, 1, -1);
if (!ep) {
--
2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Sui Jingfeng <sui.jingfeng@linux.dev>
To: Phong LE <ple@baylibre.com>, Neil Armstrong <neil.armstrong@linaro.org>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Sui Jingfeng <suijingfeng@loongson.cn>
Subject: [PATCH 3/8] drm/bridge: it66121: Add a helper function to read bus width
Date: Tue, 14 Nov 2023 23:01:25 +0800 [thread overview]
Message-ID: <20231114150130.497915-4-sui.jingfeng@linux.dev> (raw)
In-Reply-To: <20231114150130.497915-1-sui.jingfeng@linux.dev>
From: Sui Jingfeng <suijingfeng@loongson.cn>
Group those relavent code lines (which with common purpose) into one helper
function, suppress the dependency on DT to function level. Just trivial
cleanup, no functional change.
Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
---
drivers/gpu/drm/bridge/ite-it66121.c | 32 ++++++++++++++++++++--------
1 file changed, 23 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
index 83dbdbfc9ed8..0f78737adc83 100644
--- a/drivers/gpu/drm/bridge/ite-it66121.c
+++ b/drivers/gpu/drm/bridge/ite-it66121.c
@@ -320,6 +320,26 @@ static inline struct it66121_ctx *bridge_to_it66121(struct drm_bridge *bridge)
return container_of(bridge, struct it66121_ctx, bridge);
}
+static int it66121_of_read_bus_width(struct device *dev, u32 *bus_width)
+{
+ struct device_node *np;
+ u32 bw;
+
+ np = of_graph_get_endpoint_by_regs(dev->of_node, 0, 0);
+ if (!np)
+ return -EINVAL;
+
+ of_property_read_u32(np, "bus-width", &bw);
+ of_node_put(np);
+
+ if (bw != 12 && bw != 24)
+ return -EINVAL;
+
+ *bus_width = bw;
+
+ return 0;
+}
+
static const struct regmap_range_cfg it66121_regmap_banks[] = {
{
.name = "it66121",
@@ -1525,19 +1545,13 @@ static int it66121_probe(struct i2c_client *client)
if (!ctx)
return -ENOMEM;
- ep = of_graph_get_endpoint_by_regs(dev->of_node, 0, 0);
- if (!ep)
- return -EINVAL;
-
ctx->dev = dev;
ctx->client = client;
ctx->info = i2c_get_match_data(client);
- of_property_read_u32(ep, "bus-width", &ctx->bus_width);
- of_node_put(ep);
-
- if (ctx->bus_width != 12 && ctx->bus_width != 24)
- return -EINVAL;
+ ret = it66121_of_read_bus_width(dev, &ctx->bus_width);
+ if (ret)
+ return ret;
ep = of_graph_get_remote_node(dev->of_node, 1, -1);
if (!ep) {
--
2.34.1
next prev parent reply other threads:[~2023-11-14 15:09 UTC|newest]
Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 15:01 [PATCH 0/8] Allow link the it66121 display bridge driver as a lib Sui Jingfeng
2023-11-14 15:01 ` Sui Jingfeng
2023-11-14 15:01 ` [PATCH 1/8] drm/bridge: it66121: Use dev replace ctx->dev in the it66121_probe() Sui Jingfeng
2023-11-14 15:01 ` Sui Jingfeng
2023-11-14 16:01 ` Dmitry Baryshkov
2023-11-14 16:01 ` Dmitry Baryshkov
2023-11-14 15:01 ` [PATCH 2/8] drm/bridge: it66121: Add bridge_to_it66121() helper and use it Sui Jingfeng
2023-11-14 15:01 ` Sui Jingfeng
2023-11-14 16:01 ` Dmitry Baryshkov
2023-11-14 16:01 ` Dmitry Baryshkov
2023-11-14 15:01 ` Sui Jingfeng [this message]
2023-11-14 15:01 ` [PATCH 3/8] drm/bridge: it66121: Add a helper function to read bus width Sui Jingfeng
2023-11-14 16:03 ` Dmitry Baryshkov
2023-11-14 16:03 ` Dmitry Baryshkov
2023-11-14 15:01 ` [PATCH 4/8] drm/bridge: it66121: Add a helper function to get the next bridge Sui Jingfeng
2023-11-14 15:01 ` Sui Jingfeng
2023-11-14 16:05 ` Dmitry Baryshkov
2023-11-14 16:05 ` Dmitry Baryshkov
2023-11-23 5:25 ` Sui Jingfeng
2023-11-23 5:25 ` Sui Jingfeng
2023-11-23 7:54 ` Dmitry Baryshkov
2023-11-23 7:54 ` Dmitry Baryshkov
2023-11-14 15:01 ` [PATCH 5/8] drm/bridge: it66121: Add a helper function to read chip id Sui Jingfeng
2023-11-14 15:01 ` Sui Jingfeng
2023-11-14 16:06 ` Dmitry Baryshkov
2023-11-14 16:06 ` Dmitry Baryshkov
2023-11-16 12:18 ` Sui Jingfeng
2023-11-16 12:18 ` Sui Jingfeng
2023-11-16 13:00 ` Dmitry Baryshkov
2023-11-16 13:00 ` Dmitry Baryshkov
2023-11-16 18:29 ` Sui Jingfeng
2023-11-16 18:29 ` Sui Jingfeng
2023-11-16 22:00 ` Dmitry Baryshkov
2023-11-16 22:00 ` Dmitry Baryshkov
2023-11-23 5:37 ` Sui Jingfeng
2023-11-23 5:37 ` Sui Jingfeng
2023-11-23 7:48 ` Dmitry Baryshkov
2023-11-23 7:48 ` Dmitry Baryshkov
2023-11-23 13:03 ` Sui Jingfeng
2023-11-23 13:03 ` Sui Jingfeng
2023-11-14 15:01 ` [PATCH 6/8] drm/bridge: it66121: Add a helper to initialize the DRM bridge structure Sui Jingfeng
2023-11-14 15:01 ` Sui Jingfeng
2023-11-14 16:10 ` Dmitry Baryshkov
2023-11-14 16:10 ` Dmitry Baryshkov
2023-11-14 15:01 ` [PATCH 7/8] drm/bridge: it66121: Add another implementation for getting match data Sui Jingfeng
2023-11-14 15:01 ` Sui Jingfeng
2023-11-14 16:00 ` Dmitry Baryshkov
2023-11-14 16:00 ` Dmitry Baryshkov
2023-11-14 15:01 ` [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib Sui Jingfeng
2023-11-14 15:01 ` Sui Jingfeng
2023-11-14 16:30 ` Dmitry Baryshkov
2023-11-14 16:30 ` Dmitry Baryshkov
2023-11-16 9:14 ` Sui Jingfeng
2023-11-16 9:14 ` Sui Jingfeng
2023-11-16 9:30 ` Dmitry Baryshkov
2023-11-16 9:30 ` Dmitry Baryshkov
2023-11-16 10:12 ` Sui Jingfeng
2023-11-16 10:12 ` Sui Jingfeng
2023-11-16 11:19 ` Dmitry Baryshkov
2023-11-16 11:19 ` Dmitry Baryshkov
2023-11-23 5:05 ` Sui Jingfeng
2023-11-23 5:05 ` Sui Jingfeng
2023-11-23 8:08 ` Dmitry Baryshkov
2023-11-23 8:08 ` Dmitry Baryshkov
2023-11-23 13:39 ` Neil Armstrong
2023-11-23 13:39 ` Neil Armstrong
2023-11-23 16:20 ` Sui Jingfeng
2023-11-23 16:20 ` Sui Jingfeng
2023-11-23 15:41 ` Sui Jingfeng
2023-11-23 15:41 ` Sui Jingfeng
2023-11-23 16:06 ` Dmitry Baryshkov
2023-11-23 16:06 ` Dmitry Baryshkov
2023-11-23 16:29 ` Sui Jingfeng
2023-11-23 16:29 ` Sui Jingfeng
2023-11-23 17:04 ` Sui Jingfeng
2023-11-23 17:04 ` Sui Jingfeng
2023-11-23 17:39 ` Dmitry Baryshkov
2023-11-23 17:39 ` Dmitry Baryshkov
2023-11-23 17:52 ` Sui Jingfeng
2023-11-23 17:52 ` Sui Jingfeng
2023-11-24 7:38 ` Maxime Ripard
2023-11-24 7:38 ` Maxime Ripard
2023-11-24 7:51 ` Sui Jingfeng
2023-11-24 7:51 ` Sui Jingfeng
2023-11-24 8:13 ` Maxime Ripard
2023-11-24 8:13 ` Maxime Ripard
2023-11-24 8:48 ` Sui Jingfeng
2023-11-24 8:48 ` Sui Jingfeng
2023-11-25 2:30 ` Sui Jingfeng
2023-11-25 2:30 ` Sui Jingfeng
2023-11-16 10:29 ` Sui Jingfeng
2023-11-16 10:29 ` Sui Jingfeng
2023-11-16 11:11 ` Dmitry Baryshkov
2023-11-16 11:11 ` Dmitry Baryshkov
2023-11-16 11:15 ` Jani Nikula
2023-11-16 11:18 ` Sui Jingfeng
2023-11-16 11:18 ` Sui Jingfeng
2023-11-16 11:29 ` Dmitry Baryshkov
2023-11-16 11:29 ` Dmitry Baryshkov
2023-11-16 11:53 ` Sui Jingfeng
2023-11-16 11:53 ` Sui Jingfeng
2023-11-16 12:07 ` Sui Jingfeng
2023-11-16 12:07 ` Sui Jingfeng
2023-11-16 15:23 ` Dmitry Baryshkov
2023-11-16 15:23 ` Dmitry Baryshkov
2023-11-16 17:18 ` Sui Jingfeng
2023-11-16 17:18 ` Sui Jingfeng
2023-11-17 9:52 ` Maxime Ripard
2023-11-17 9:52 ` Maxime Ripard
2023-11-17 4:24 ` Sui Jingfeng
2023-11-17 4:24 ` Sui Jingfeng
2023-11-17 9:03 ` Dmitry Baryshkov
2023-11-17 9:03 ` Dmitry Baryshkov
2023-11-17 17:14 ` Sui Jingfeng
2023-11-17 17:14 ` Sui Jingfeng
2023-11-20 8:23 ` Neil Armstrong
2023-11-20 8:23 ` Neil Armstrong
2023-11-17 17:35 ` Sui Jingfeng
2023-11-17 17:35 ` Sui Jingfeng
2023-11-20 10:06 ` Dmitry Baryshkov
2023-11-20 10:06 ` Dmitry Baryshkov
2023-11-17 12:13 ` Maxime Ripard
2023-11-17 12:13 ` Maxime Ripard
2023-11-15 13:02 ` kernel test robot
2023-11-15 13:02 ` kernel test robot
2023-11-20 9:08 ` kernel test robot
2023-11-20 9:08 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231114150130.497915-4-sui.jingfeng@linux.dev \
--to=sui.jingfeng@linux.dev \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=ple@baylibre.com \
--cc=suijingfeng@loongson.cn \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.