All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Aneesh Kumar K V <aneesh.kumar@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com
Subject: Re: [PATCH] powerpc/sched: Cleanup vcpu_is_preempted()
Date: Tue, 14 Nov 2023 21:26:10 +0530	[thread overview]
Message-ID: <20231114155610.GS2194132@linux.vnet.ibm.com> (raw)
In-Reply-To: <b21c7dc2-cdfa-45f2-b799-18aaa7297b46@linux.ibm.com>

* Aneesh Kumar K V <aneesh.kumar@linux.ibm.com> [2023-11-14 15:45:35]:

> On 11/14/23 3:16 PM, Srikar Dronamraju wrote:
> > * Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> [2023-11-14 12:42:19]:
> > 
> >> No functional change in this patch. A helper is added to find if
> >> vcpu is dispatched by hypervisor. Use that instead of opencoding.
> >> Also clarify some of the comments.
> >>
> > 
> > If we are introducing vcpu_is_dispatched, we should remove 
> > yield_count_of() and use vcpu_is_dispatched everwhere
> > 
> > No point in having yield_count_of() and vcpu_is_dispatched, since
> > yield_count_of() is only used to check if we are running in OS or not.
> > 
> 
> We do
> 
> yield_count = yield_count_of(owner);
> yield_to_preempted(owner, yield_count);

yield_to_preempted is defined just below yield_count_of() and we are anyway
passing the CPU, so we dont have to pass yield_count to yield_to_preempted


-- 
Thanks and Regards
Srikar Dronamraju

  reply	other threads:[~2023-11-14 15:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-14  7:12 [PATCH] powerpc/sched: Cleanup vcpu_is_preempted() Aneesh Kumar K.V
2023-11-14  9:23 ` Shrikanth Hegde
2023-11-14  9:29   ` Aneesh Kumar K V
2023-11-14  9:46 ` Srikar Dronamraju
2023-11-14 10:15   ` Aneesh Kumar K V
2023-11-14 15:56     ` Srikar Dronamraju [this message]
2023-12-21 10:38 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231114155610.GS2194132@linux.vnet.ibm.com \
    --to=srikar@linux.vnet.ibm.com \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.