From: Herve Codina <herve.codina@bootlin.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Saravana Kannan <saravanak@google.com>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-kernel@vger.kernel.org,
Allan Nielsen <allan.nielsen@microchip.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Steen Hegelund <steen.hegelund@microchip.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/1] lib/vsprintf: Fix %pfwf when current node refcount == 0
Date: Tue, 14 Nov 2023 16:13:41 +0100 [thread overview]
Message-ID: <20231114161341.2651d393@bootlin.com> (raw)
In-Reply-To: <ZVOLV008PaKFXRy9@smile.fi.intel.com>
Hi Andy,
On Tue, 14 Nov 2023 16:59:35 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
[...]
>
> One nit-pick below, otherwise
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> ...
>
> > /* Loop starting from the root node to the current node. */
> > for (depth = fwnode_count_parents(fwnode); depth >= 0; depth--) {
> > - struct fwnode_handle *__fwnode =
> > - fwnode_get_nth_parent(fwnode, depth);
> > + /*
> > + * Only get a reference for other nodes (ie parents node).
>
> "parent's node" (doesn't look right)? Or "parent nodes"?
>
Will be changed to "parent nodes" in the next iteration.
Best regards,
Hervé
prev parent reply other threads:[~2023-11-14 15:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 14:35 [PATCH v2 1/1] lib/vsprintf: Fix %pfwf when current node refcount == 0 Herve Codina
2023-11-14 14:47 ` Sakari Ailus
2023-11-14 15:12 ` Herve Codina
2023-11-14 14:59 ` Andy Shevchenko
2023-11-14 15:13 ` Herve Codina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231114161341.2651d393@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=horatiu.vultur@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rostedt@goodmis.org \
--cc=sakari.ailus@linux.intel.com \
--cc=saravanak@google.com \
--cc=senozhatsky@chromium.org \
--cc=stable@vger.kernel.org \
--cc=steen.hegelund@microchip.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.