Re: [PATCH][net-next][v2] rtnetlink: instroduce vnlmsg_new and use it in rtnl_getlink

[Jakub Kicinski <kuba@kernel.org>]

On Tue, 14 Nov 2023 17:55:22 +0800 Li RongQing wrote:
> -	nskb = nlmsg_new(if_nlmsg_size(dev, ext_filter_mask), GFP_KERNEL);
> +	nskb = vnlmsg_new(if_nlmsg_size(dev, ext_filter_mask));

Why vnlmsg_new()? nlmsg_ is a prefix, for netlink message.
prefixes do not combine like you're trying to make them.
Can you call it nlmsg_new_large() or similar?

>  	if (nskb == NULL)
>  		goto out;
>  
> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index eb086b0..17587f1 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -1204,7 +1204,7 @@ struct sock *netlink_getsockbyfilp(struct file *filp)
>  	return sock;
>  }
>  
> -static struct sk_buff *netlink_alloc_large_skb(unsigned int size,
> +struct sk_buff *netlink_alloc_large_skb(unsigned int size,
>  					       int broadcast)

You need to fix the alignment of the continuation line.
Perhaps it now fits in 80chars so line break is not needed?