From: Al Viro <viro@zeniv.linux.org.uk>
To: Christian Brauner <brauner@kernel.org>
Cc: Chuck Lever <cel@kernel.org>,
akpm@linux-foundation.org, hughd@google.com, jlayton@redhat.com,
Tavian Barnes <tavianator@tavianator.com>,
Chuck Lever <chuck.lever@oracle.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH RFC] libfs: getdents() should return 0 after reaching EOD
Date: Tue, 14 Nov 2023 17:57:14 +0000 [thread overview]
Message-ID: <20231114175714.GT1957730@ZenIV> (raw)
In-Reply-To: <20231114-begleichen-miniatur-3c3a02862c4c@brauner>
On Tue, Nov 14, 2023 at 06:29:15PM +0100, Christian Brauner wrote:
> I think it's usually best practice to only modify the file->private_data
> pointer during f_op->open and f_op->close but not override
> file->private_data once the file is visible to other threads. I think
> here it might not matter because access to file->private_data is
> serialized on f_pos_lock and it's not used by anything else.
That is entirely up to filesystem. Warning that use of that library
helper means that you can't use your ->d_fsdata for anything else - sure,
but that's it.
next prev parent reply other threads:[~2023-11-14 17:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 15:49 [PATCH RFC] libfs: getdents() should return 0 after reaching EOD Chuck Lever
2023-11-14 15:56 ` Matthew Wilcox
2023-11-14 16:00 ` Chuck Lever
2023-11-14 17:29 ` Christian Brauner
2023-11-14 17:57 ` Al Viro [this message]
2023-11-15 20:25 ` Christian Brauner
2023-11-14 18:13 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231114175714.GT1957730@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=hughd@google.com \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tavianator@tavianator.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.