From: Simon Horman <horms@kernel.org>
To: Gerd Bayer <gbayer@linux.ibm.com>
Cc: Alexandra Winter <wintera@linux.ibm.com>,
Wenjia Zhang <wenjia@linux.ibm.com>,
Paolo Abeni <pabeni@redhat.com>, Wen Gu <guwen@linux.alibaba.com>,
Randy Dunlap <rdunlap@infradead.org>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
alibuda@linux.alibaba.com, tonylu@linux.alibaba.com,
dust.li@linux.alibaba.com, linux-s390@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net] s390/ism: ism driver implies smc protocol
Date: Wed, 15 Nov 2023 10:23:04 +0000 [thread overview]
Message-ID: <20231115102304.GN74656@kernel.org> (raw)
In-Reply-To: <20231114091718.3482624-1-gbayer@linux.ibm.com>
On Tue, Nov 14, 2023 at 10:17:18AM +0100, Gerd Bayer wrote:
> Since commit a72178cfe855 ("net/smc: Fix dependency of SMC on ISM")
> you can build the ism code without selecting the SMC network protocol.
> That leaves some ism functions be reported as unused. Move these
> functions under the conditional compile with CONFIG_SMC.
>
> Also codify the suggestion to also configure the SMC protocol in ism's
> Kconfig - but with an "imply" rather than a "select" as SMC depends on
> other config options and allow for a deliberate decision not to build
> SMC. Also, mention that in ISM's help.
>
> Fixes: a72178cfe855 ("net/smc: Fix dependency of SMC on ISM")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Closes: https://lore.kernel.org/netdev/afd142a2-1fa0-46b9-8b2d-7652d41d3ab8@infradead.org/
> Signed-off-by: Gerd Bayer <gbayer@linux.ibm.com>
> Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>
Hi Gerd,
In a similar vein, I am wondering if the forward declaration of ism_ops
could be removed. In my very light compile test it shows up as unused when
CONFIG_SMC is unset.
next prev parent reply other threads:[~2023-11-15 10:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 3:33 linux-next: Tree for Oct 3 Stephen Rothwell
2023-10-04 1:08 ` linux-next: Tree for Oct 3 (net/smc/smc_ism.o) Randy Dunlap
2023-10-04 12:37 ` Wenjia Zhang
2023-10-06 12:58 ` [PATCH net] net/smc: Fix dependency of SMC on ISM Gerd Bayer
2023-10-06 14:48 ` Simon Horman
2023-10-06 20:05 ` Randy Dunlap
2023-10-10 10:20 ` patchwork-bot+netdevbpf
2023-10-16 23:09 ` Randy Dunlap
2023-10-17 14:15 ` Gerd Bayer
2023-11-14 9:17 ` [PATCH net] s390/ism: ism driver implies smc protocol Gerd Bayer
2023-11-15 10:23 ` Simon Horman [this message]
2023-11-15 15:29 ` Gerd Bayer
2023-11-15 15:59 ` [PATCH net v2] " Gerd Bayer
2023-11-15 17:06 ` Simon Horman
2023-11-15 20:43 ` Randy Dunlap
2023-11-17 0:40 ` patchwork-bot+netdevbpf
2023-11-16 8:26 ` [PATCH net] " Wen Gu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231115102304.GN74656@kernel.org \
--to=horms@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=alibuda@linux.alibaba.com \
--cc=borntraeger@linux.ibm.com \
--cc=dust.li@linux.alibaba.com \
--cc=gbayer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=guwen@linux.alibaba.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=svens@linux.ibm.com \
--cc=tonylu@linux.alibaba.com \
--cc=wenjia@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.