From: Chris Morgan <macroalpha82@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: quic_jesszhan@quicinc.com, sam@ravnborg.org,
Chris Morgan <macromorgan@hotmail.com>,
neil.armstrong@linaro.org
Subject: [PATCH 2/4] drm/panel-elida-kd35t133: hold panel in reset for unprepare
Date: Wed, 15 Nov 2023 09:26:45 -0600 [thread overview]
Message-ID: <20231115152647.2303283-3-macroalpha82@gmail.com> (raw)
In-Reply-To: <20231115152647.2303283-1-macroalpha82@gmail.com>
From: Chris Morgan <macromorgan@hotmail.com>
For devices like the Anbernic RG351M and RG351P the panel is wired to
an always on regulator. When the device suspends and wakes up, there
are some slight artifacts on the screen that go away over time. If
instead we hold the panel in reset status after it is unprepared,
this does not happen.
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
drivers/gpu/drm/panel/panel-elida-kd35t133.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-elida-kd35t133.c b/drivers/gpu/drm/panel/panel-elida-kd35t133.c
index 6cd8536c09ff..f1fc4a26f447 100644
--- a/drivers/gpu/drm/panel/panel-elida-kd35t133.c
+++ b/drivers/gpu/drm/panel/panel-elida-kd35t133.c
@@ -104,6 +104,8 @@ static int kd35t133_unprepare(struct drm_panel *panel)
return ret;
}
+ gpiod_set_value_cansleep(ctx->reset_gpio, 1);
+
regulator_disable(ctx->iovcc);
regulator_disable(ctx->vdd);
--
2.34.1
next prev parent reply other threads:[~2023-11-15 15:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 15:26 [PATCH 0/4] Elida KD35T133 Panel Improvements Chris Morgan
2023-11-15 15:26 ` [PATCH 1/4] drm/panel-elida-kd35t133: trival: update panel size from 5.5 to 3.5 Chris Morgan
2023-11-15 21:22 ` Jessica Zhang
2023-11-15 15:26 ` Chris Morgan [this message]
2023-11-15 21:38 ` [PATCH 2/4] drm/panel-elida-kd35t133: hold panel in reset for unprepare Jessica Zhang
2023-11-16 15:17 ` Chris Morgan
2023-11-16 21:40 ` Jessica Zhang
2023-11-15 15:26 ` [PATCH 3/4] drm/panel-elida-kd35t133: drop drm_connector_set_orientation_from_panel Chris Morgan
2023-11-15 22:00 ` Jessica Zhang
2023-11-15 15:26 ` [PATCH 4/4] drm/panel-elida-kd35t133: Drop prepare/unprepare logic Chris Morgan
2023-11-15 22:30 ` Jessica Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231115152647.2303283-3-macroalpha82@gmail.com \
--to=macroalpha82@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=macromorgan@hotmail.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.