All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc: oe-kbuild-all@lists.linux.dev,
	Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
	linux-media@vger.kernel.org,
	Kieran Bingham <kieran.bingham@ideasonboard.com>
Subject: Re: [PATCH v2 2/2] media: i2c: Add driver for OmniVision OV64A40
Date: Wed, 15 Nov 2023 21:58:48 +0800	[thread overview]
Message-ID: <202311152102.decxO6op-lkp@intel.com> (raw)
In-Reply-To: <20231114182831.220823-3-jacopo.mondi@ideasonboard.com>

Hi Jacopo,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 61ab89c1916219ccbeca9f6cefb1680212de8d1c]

url:    https://github.com/intel-lab-lkp/linux/commits/Jacopo-Mondi/media-dt-bindings-Add-OmniVision-OV64A40/20231115-035231
base:   61ab89c1916219ccbeca9f6cefb1680212de8d1c
patch link:    https://lore.kernel.org/r/20231114182831.220823-3-jacopo.mondi%40ideasonboard.com
patch subject: [PATCH v2 2/2] media: i2c: Add driver for OmniVision OV64A40
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231115/202311152102.decxO6op-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231115/202311152102.decxO6op-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311152102.decxO6op-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/media/i2c/ov64a40.c:2808:31: warning: no previous prototype for 'ov64a40_get_timings' [-Wmissing-prototypes]
    2808 | const struct ov64a40_timings *ov64a40_get_timings(struct ov64a40 *ov64a40)
         |                               ^~~~~~~~~~~~~~~~~~~
   drivers/media/i2c/ov64a40.c: In function 'ov64a40_remove':
   drivers/media/i2c/ov64a40.c:3609:25: warning: unused variable 'ov64a40' [-Wunused-variable]
    3609 |         struct ov64a40 *ov64a40 = sd_to_ov64a40(sd);
         |                         ^~~~~~~
   drivers/media/i2c/ov64a40.c: At top level:
>> drivers/media/i2c/ov64a40.c:3175:12: warning: 'ov64a40_power_on' defined but not used [-Wunused-function]
    3175 | static int ov64a40_power_on(struct device *dev)
         |            ^~~~~~~~~~~~~~~~
   drivers/media/i2c/ov64a40.c:119:18: warning: 'ov64a40_link_freq_menu' defined but not used [-Wunused-const-variable=]
     119 | static const s64 ov64a40_link_freq_menu[] = {
         |                  ^~~~~~~~~~~~~~~~~~~~~~


vim +/ov64a40_power_on +3175 drivers/media/i2c/ov64a40.c

  3174	
> 3175	static int ov64a40_power_on(struct device *dev)
  3176	{
  3177		struct v4l2_subdev *sd = dev_get_drvdata(dev);
  3178		struct ov64a40 *ov64a40 = sd_to_ov64a40(sd);
  3179		int ret;
  3180	
  3181		ret = ov64a40_enable(dev);
  3182		if (ret)
  3183			return ret;
  3184	
  3185		/*
  3186		 * The first configuration sequence is pretty long, so we write it
  3187		 * once at power-on time to avoid doing it in consecutive
  3188		 * start_streaming calls.
  3189		 */
  3190		return cci_multi_reg_write(ov64a40->cci, ov64a40_init,
  3191					   ARRAY_SIZE(ov64a40_init), NULL);
  3192	}
  3193	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2023-11-15 13:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-14 18:28 [PATCH v2 0/2] media: i2c: Add driver for OmniVision OV64A40 Jacopo Mondi
2023-11-14 18:28 ` [PATCH v2 1/2] media: dt-bindings: Add " Jacopo Mondi
2023-11-14 21:30   ` Krzysztof Kozlowski
2023-11-14 18:28 ` [PATCH v2 2/2] media: i2c: Add driver for " Jacopo Mondi
2023-11-15 13:58   ` kernel test robot [this message]
2023-11-15 13:42 ` [PATCH v2 0/2] " Jacopo Mondi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202311152102.decxO6op-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.