From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E41E8C197A0 for ; Thu, 16 Nov 2023 06:56:46 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 4EBC726A37 for ; Thu, 16 Nov 2023 06:56:46 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 22B03986DD4 for ; Thu, 16 Nov 2023 06:56:46 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 092F5986DD1; Thu, 16 Nov 2023 06:56:46 +0000 (UTC) Mailing-List: contact virtio-comment-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id EC609986DD2 for ; Thu, 16 Nov 2023 06:56:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: iWQfMxJwPq2AaXnudEQefg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700117802; x=1700722602; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KmOusb9rJOjPu5up36y2wBU3VaW/OqGkwPogngR7QTk=; b=t9dotuJ28P9RBIL3MXkki8aRe0VnBzU2+hdehp/adxEUnQgo4Hg92KVy30zRk9mT6j EiBICGVVkUPPTl6swEsv8SLdR7QBYAz82z+ViWjrosZ/R/2M+Ft+eO+1O2H2+eQHqp2c cqCPAy99Af6r3pTuWj/H4JX7kJwt7ssBukwRzSFpuwhedKBqSS2EXm0WQHQ4qzGjAJj9 OuKkYVyQEYOVMVfX09ATu2f9s9/qDrG6y1PZfUBhCR22FVHVyL5LLKcU75w5DAUR9GCo +ruPi9x3LeeRZJbISqFwgw4os+Ixd+wAhySE9+AAilNOq+1uB6wihD1ru8Wt+RBPdAuM 0iUA== X-Gm-Message-State: AOJu0YxM94KfPBXT2RKI+dQ9pi9ZFgS01HvaFrRlP/wytS3Aw4N46JqT 7lBAUwZeGIUtjNJiXRfMcWOsIx56ho7FjgM/JOZyILWCWkM+q8eG1w/6M5IsxPErnqzj1MaZud2 4AdTrppCkdneRv7Tag3zmHd7xABnIFdomuA== X-Received: by 2002:adf:f40f:0:b0:319:67ac:4191 with SMTP id g15-20020adff40f000000b0031967ac4191mr9618584wro.37.1700117802537; Wed, 15 Nov 2023 22:56:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IFSZnxMxNJ1CrauE/fD+AN8FozJTVm4LljLKdDnT7bO76v+nwvZ+mDIRnxGKxziDENvuNvXow== X-Received: by 2002:adf:f40f:0:b0:319:67ac:4191 with SMTP id g15-20020adff40f000000b0031967ac4191mr9618577wro.37.1700117802236; Wed, 15 Nov 2023 22:56:42 -0800 (PST) Date: Thu, 16 Nov 2023 01:56:38 -0500 From: "Michael S. Tsirkin" To: Parav Pandit Cc: Jason Wang , "Zhu, Lingshan" , "virtio-comment@lists.oasis-open.org" , "cohuck@redhat.com" , "sburla@marvell.com" , Shahaf Shuler , Maor Gottlieb , Yishai Hadas Message-ID: <20231116015424-mutt-send-email-mst@kernel.org> References: <20231116012208-mutt-send-email-mst@kernel.org> <20231116013650-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: Re: [virtio-comment] [PATCH v1 1/8] admin: Add theory of operation for device migration On Thu, Nov 16, 2023 at 06:43:05AM +0000, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, November 16, 2023 12:09 PM > > > > On Thu, Nov 16, 2023 at 06:34:23AM +0000, Parav Pandit wrote: > > > > > > > > > > From: Michael S. Tsirkin > > > > Sent: Thursday, November 16, 2023 11:53 AM > > > > > > > > On Thu, Nov 16, 2023 at 05:28:19AM +0000, Parav Pandit wrote: > > > > > You continue to want to overload admin commands for dual purpose, > > > > > does > > > > not make sense to me. > > > > > > > > dual -> as a transport and for migration? why can't they be used for > > > > this? I was really hoping to cover these two cases when I proposed them. > > > For following reasons. > > > > > > 1. migration needs incremental reads of only changed context between > > > two reads > > > > > > 2. migration writes covers large part of the configurations not just virtio > > common config and device config. > > > Such as configuration occurred through the CVQ. All of these is not needed > > when done from guest directly via member's own CVQ. > > > > > > For backward compatible SIOV transport, one may need them to transport > > without above two properties. > > > > > > 3. None of this transport is needed for PFs, VFs and non-backward compatible > > SIOVs. > > > Each device to have its own transport that is not intercepted by the hypervisor > > and follow the equivalency principle uniformly for all 3 device types. > > > > > > > To clarify. Above seems to justify why the admin commands for migration must > > be distinct from admin commands for transport. But I don't see why (e.g. two > > sets of) admin commands can not be used for both. Do you? > > I didn't follow, "used for both". > Can you please explain? > Both meaning, > a. for device migration and > b. for transporting configuration by owner device on behalf of member device? Yes, so one set of commands for migration another for passing config space accesses. We do in fact have admin commands as transport for legacy, do we not? And in this model we can have new group types, e.g. SIOV's subfunction or even a "self" group. -- MST This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/