Re: [PATCHv3 14/14] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method

[kernel test robot <lkp@intel.com>]

Hi Kirill,

kernel test robot noticed the following build errors:

[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on tip/master linus/master v6.7-rc1 next-20231115]
[cannot apply to tip/x86/core rafael-pm/acpi-bus tip/smp/core tip/x86/mm rafael-pm/devprop tip/auto-latest]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Kirill-A-Shutemov/x86-acpi-Extract-ACPI-MADT-wakeup-code-into-a-separate-file/20231115-200533
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link:    https://lore.kernel.org/r/20231115120044.8034-15-kirill.shutemov%40linux.intel.com
patch subject: [PATCHv3 14/14] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method
config: x86_64-randconfig-004-20231116 (https://download.01.org/0day-ci/archive/20231116/202311160404.P79tKafL-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231116/202311160404.P79tKafL-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311160404.P79tKafL-lkp@intel.com/

All errors (new ones prefixed by >>):

   arch/x86/kernel/acpi/madt_wakeup.c: In function 'crash_nmi_callback':
>> arch/x86/kernel/acpi/madt_wakeup.c:67:9: error: implicit declaration of function 'crash_save_cpu' [-Werror=implicit-function-declaration]
      67 |         crash_save_cpu(regs, raw_smp_processor_id());
         |         ^~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/crash_save_cpu +67 arch/x86/kernel/acpi/madt_wakeup.c

    62	
    63	static int crash_nmi_callback(unsigned int val, struct pt_regs *regs)
    64	{
    65		local_irq_disable();
    66	
  > 67		crash_save_cpu(regs, raw_smp_processor_id());
    68	
    69		cpu_emergency_stop_pt();
    70	
    71		disable_local_APIC();
    72	
    73		/*
    74		 * Prepare the CPU for reboot _after_ invoking the callback so that the
    75		 * callback can safely use virtualization instructions, e.g. VMCLEAR.
    76		 */
    77		cpu_emergency_disable_virtualization();
    78	
    79		atomic_dec(&waiting_for_crash_ipi);
    80	
    81		asm_acpi_mp_play_dead(acpi_mp_reset_vector_paddr,
    82				      acpi_mp_pgd);
    83	
    84		return NMI_HANDLED;
    85	}
    86	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki