All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Aditya Gupta <adityag@linux.ibm.com>
Cc: kexec@lists.infradead.org, Hari Bathini <hbathini@linux.ibm.com>,
	Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
	Sourabh Jain <sourabhjain@linux.ibm.com>,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Subject: Re: [PATCH] kexec: ppc64: print help to stdout instead of stderr
Date: Thu, 16 Nov 2023 11:34:57 +0000	[thread overview]
Message-ID: <20231116113457.GA314364@kernel.org> (raw)
In-Reply-To: <20231116084137.179818-1-adityag@linux.ibm.com>

On Thu, Nov 16, 2023 at 02:11:37PM +0530, Aditya Gupta wrote:
> Currently 'kexec --help' on powerpc64 prints the generic help/usage to
> stdout, and the powerpc64 specific options to stderr
> 
> That is, if the stdout of 'kexec --help' is redirected to some file,
> some of the help options will not be redirected, and instead printed on
> the terminal/stderr:
> 
>     [root@machine kexec-tools]# kexec --help > /tmp/out
>          --command-line=<Command line> command line to append.
>          --append=<Command line> same as --command-line.
>          --ramdisk=<filename> Initial RAM disk.
>          --initrd=<filename> same as --ramdisk.
>          --devicetreeblob=<filename> Specify device tree blob file.
>                                      Not applicable while using
>     --kexec-file-syscall.
>          --dtb=<filename> same as --devicetreeblob.
>     elf support is still broken
>          --elf64-core-headers Prepare core headers in ELF64 format
>          --dt-no-old-root Do not reuse old kernel root= param.
>                           while creating flatten device tree.
> 
> Fix this inconsistency by writing powerpc64 specific options to stdout,
> similar to the generic 'kexec --help'
> 
> With the proposed changes, it is like this (nothing printed to stderr):
> 
>     [root@machine kexec-tools]# ./build/sbin/kexec --help > /tmp/out
> 
> Reported-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> Signed-off-by: Aditya Gupta <adityag@linux.ibm.com>

Thanks Aditya,

applied.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2023-11-16 11:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-16  8:41 [PATCH] kexec: ppc64: print help to stdout instead of stderr Aditya Gupta
2023-11-16 11:34 ` Simon Horman [this message]
2023-11-17  6:06 ` Srikar Dronamraju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231116113457.GA314364@kernel.org \
    --to=horms@kernel.org \
    --cc=adityag@linux.ibm.com \
    --cc=hbathini@linux.ibm.com \
    --cc=kexec@lists.infradead.org \
    --cc=mahesh@linux.ibm.com \
    --cc=sourabhjain@linux.ibm.com \
    --cc=srikar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.