From: Jakub Kicinski <kuba@kernel.org>
To: leit@meta.com
Cc: Jonathan Corbet <corbet@lwn.net>,
Breno Leitao <leitao@debian.org>,
netdev@vger.kernel.org, donald.hunter@gmail.com,
linux-doc@vger.kernel.org, pabeni@redhat.com,
edumazet@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Documentation: Document each netlink family
Date: Fri, 17 Nov 2023 16:39:39 -0800 [thread overview]
Message-ID: <20231117163939.2de33e83@kernel.org> (raw)
In-Reply-To: <87y1ew6n4x.fsf@meer.lwn.net>
On Fri, 17 Nov 2023 15:17:02 -0700 Jonathan Corbet wrote:
> In principle I like this approach better. There is one problem, though:
>
> - In current kernels, on my machine, "make htmldocs" when nothing has
> changed takes about 6s to complete.
>
> - With this patch applied, it takes a little over 5 *minutes*.
>
> Without having delved into it too far, I am guessing that the
> unconditional recreation of the netlink RST files is causing the rebuild
> of much of the documentation. Even so, I don't quite get it.
>
> That, clearly, would need to be fixed before this can go in.
FWIW on the C code-gen side we avoid touching the files if nothing
changed both at the Makefile level:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/tools/net/ynl/generated/Makefile#n28
And the tool itself actually generates to a tempfile and compares
if the output changed:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=2b7ac0c87d985c92e519995853c52b9649ea4b07
next prev parent reply other threads:[~2023-11-18 0:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 20:29 [PATCH v2] Documentation: Document each netlink family Breno Leitao
2023-11-17 22:17 ` Jonathan Corbet
2023-11-18 0:39 ` Jakub Kicinski [this message]
2023-11-20 19:55 ` Breno Leitao
2023-11-20 20:07 ` Jakub Kicinski
2023-11-20 20:43 ` Breno Leitao
2023-11-20 21:14 ` Jakub Kicinski
2023-11-21 11:17 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231117163939.2de33e83@kernel.org \
--to=kuba@kernel.org \
--cc=corbet@lwn.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=leit@meta.com \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.