From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com
Subject: drivers/iio/adc/axp20x_adc.c:572:26: sparse: sparse: dubious: x & !y
Date: Sat, 18 Nov 2023 09:24:59 +0800 [thread overview]
Message-ID: <202311180939.iYu7ELDX-lkp@intel.com> (raw)
::::::
:::::: Manual check reason: "low confidence static check warning: drivers/iio/adc/axp20x_adc.c:572:26: sparse: sparse: dubious: x & !y"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
CC: Jonathan Cameron <Jonathan.Cameron@huawei.com>
CC: "Chen-Yu Tsai" <wens@csie.org>
CC: Andy Shevchenko <andy.shevchenko@gmail.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 791c8ab095f71327899023223940dd52257a4173
commit: 8957e5344353e9cd3f6b1e3004942e35449fa0e8 iio: adc: axp20x_adc: Minor code cleanups
date: 8 months ago
:::::: branch date: 3 hours ago
:::::: commit date: 8 months ago
config: x86_64-randconfig-x001-20230717 (https://download.01.org/0day-ci/archive/20231118/202311180939.iYu7ELDX-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231118/202311180939.iYu7ELDX-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202311180939.iYu7ELDX-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/iio/adc/axp20x_adc.c:572:26: sparse: sparse: dubious: x & !y
drivers/iio/adc/axp20x_adc.c:577:26: sparse: sparse: dubious: x & !y
vim +572 drivers/iio/adc/axp20x_adc.c
1a3f6755649dd4 Quentin Schulz 2018-01-15 551
0e34d5de961d5a Quentin Schulz 2017-04-04 552 static int axp20x_write_raw(struct iio_dev *indio_dev,
0e34d5de961d5a Quentin Schulz 2017-04-04 553 struct iio_chan_spec const *chan, int val, int val2,
0e34d5de961d5a Quentin Schulz 2017-04-04 554 long mask)
0e34d5de961d5a Quentin Schulz 2017-04-04 555 {
0e34d5de961d5a Quentin Schulz 2017-04-04 556 struct axp20x_adc_iio *info = iio_priv(indio_dev);
8957e5344353e9 Aidan MacDonald 2023-02-17 557 unsigned int regmask, regval;
0e34d5de961d5a Quentin Schulz 2017-04-04 558
0e34d5de961d5a Quentin Schulz 2017-04-04 559 /*
0e34d5de961d5a Quentin Schulz 2017-04-04 560 * The AXP20X PMIC allows the user to choose between 0V and 0.7V offsets
0e34d5de961d5a Quentin Schulz 2017-04-04 561 * for (independently) GPIO0 and GPIO1 when in ADC mode.
0e34d5de961d5a Quentin Schulz 2017-04-04 562 */
0e34d5de961d5a Quentin Schulz 2017-04-04 563 if (mask != IIO_CHAN_INFO_OFFSET)
0e34d5de961d5a Quentin Schulz 2017-04-04 564 return -EINVAL;
0e34d5de961d5a Quentin Schulz 2017-04-04 565
0e34d5de961d5a Quentin Schulz 2017-04-04 566 if (val != 0 && val != 700000)
0e34d5de961d5a Quentin Schulz 2017-04-04 567 return -EINVAL;
0e34d5de961d5a Quentin Schulz 2017-04-04 568
0e34d5de961d5a Quentin Schulz 2017-04-04 569 switch (chan->channel) {
0e34d5de961d5a Quentin Schulz 2017-04-04 570 case AXP20X_GPIO0_V:
8957e5344353e9 Aidan MacDonald 2023-02-17 571 regmask = AXP20X_GPIO10_IN_RANGE_GPIO0;
8957e5344353e9 Aidan MacDonald 2023-02-17 @572 regval = FIELD_PREP(AXP20X_GPIO10_IN_RANGE_GPIO0, !!val);
0e34d5de961d5a Quentin Schulz 2017-04-04 573 break;
0e34d5de961d5a Quentin Schulz 2017-04-04 574
0e34d5de961d5a Quentin Schulz 2017-04-04 575 case AXP20X_GPIO1_V:
8957e5344353e9 Aidan MacDonald 2023-02-17 576 regmask = AXP20X_GPIO10_IN_RANGE_GPIO1;
8957e5344353e9 Aidan MacDonald 2023-02-17 577 regval = FIELD_PREP(AXP20X_GPIO10_IN_RANGE_GPIO1, !!val);
0e34d5de961d5a Quentin Schulz 2017-04-04 578 break;
0e34d5de961d5a Quentin Schulz 2017-04-04 579
0e34d5de961d5a Quentin Schulz 2017-04-04 580 default:
0e34d5de961d5a Quentin Schulz 2017-04-04 581 return -EINVAL;
0e34d5de961d5a Quentin Schulz 2017-04-04 582 }
0e34d5de961d5a Quentin Schulz 2017-04-04 583
8957e5344353e9 Aidan MacDonald 2023-02-17 584 return regmap_update_bits(info->regmap, AXP20X_GPIO10_IN_RANGE, regmask, regval);
0e34d5de961d5a Quentin Schulz 2017-04-04 585 }
0e34d5de961d5a Quentin Schulz 2017-04-04 586
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-11-18 1:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 1:24 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-01-10 17:53 drivers/iio/adc/axp20x_adc.c:572:26: sparse: sparse: dubious: x & !y kernel test robot
2024-01-07 1:28 kernel test robot
2024-01-07 5:37 ` Chen-Yu Tsai
2024-01-07 19:46 ` Andy Shevchenko
2023-11-15 22:27 kernel test robot
2023-05-02 4:56 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202311180939.iYu7ELDX-lkp@intel.com \
--to=lkp@intel.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.