From: Johan Hovold <johan+linaro@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>,
Shazad Hussain <quic_shazhuss@quicinc.com>
Subject: [PATCH 02/11] arm64: dts: qcom: sa8775p: fix USB wakeup interrupt types
Date: Mon, 20 Nov 2023 17:43:22 +0100 [thread overview]
Message-ID: <20231120164331.8116-3-johan+linaro@kernel.org> (raw)
In-Reply-To: <20231120164331.8116-1-johan+linaro@kernel.org>
The DP/DM wakeup interrupts are edge triggered and which edge to trigger
on depends on use-case and whether a Low speed or Full/High speed device
is connected.
Note that only triggering on rising edges can be used to detect resume
events but not disconnect events.
Fixes: de1001525c1a ("arm64: dts: qcom: sa8775p: add USB nodes")
Cc: Shazad Hussain <quic_shazhuss@quicinc.com>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index b6a93b11cbbd..4b42a329460c 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -1610,8 +1610,8 @@ usb_0: usb@a6f8800 {
assigned-clock-rates = <19200000>, <200000000>;
interrupts-extended = <&intc GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>,
- <&pdc 14 IRQ_TYPE_EDGE_RISING>,
- <&pdc 15 IRQ_TYPE_EDGE_RISING>,
+ <&pdc 14 IRQ_TYPE_EDGE_BOTH>,
+ <&pdc 15 IRQ_TYPE_EDGE_BOTH>,
<&pdc 12 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "pwr_event",
"dp_hs_phy_irq",
@@ -1697,8 +1697,8 @@ usb_1: usb@a8f8800 {
assigned-clock-rates = <19200000>, <200000000>;
interrupts-extended = <&intc GIC_SPI 352 IRQ_TYPE_LEVEL_HIGH>,
- <&pdc 8 IRQ_TYPE_EDGE_RISING>,
- <&pdc 7 IRQ_TYPE_EDGE_RISING>,
+ <&pdc 8 IRQ_TYPE_EDGE_BOTH>,
+ <&pdc 7 IRQ_TYPE_EDGE_BOTH>,
<&pdc 13 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "pwr_event",
"dp_hs_phy_irq",
@@ -1760,8 +1760,8 @@ usb_2: usb@a4f8800 {
assigned-clock-rates = <19200000>, <200000000>;
interrupts-extended = <&intc GIC_SPI 444 IRQ_TYPE_LEVEL_HIGH>,
- <&pdc 10 IRQ_TYPE_EDGE_RISING>,
- <&pdc 9 IRQ_TYPE_EDGE_RISING>;
+ <&pdc 10 IRQ_TYPE_EDGE_BOTH>,
+ <&pdc 9 IRQ_TYPE_EDGE_BOTH>;
interrupt-names = "pwr_event",
"dp_hs_phy_irq",
"dm_hs_phy_irq";
--
2.41.0
next prev parent reply other threads:[~2023-11-20 16:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 16:43 [PATCH 00/11] ARM/arm64: dts: qcom: fix USB wakeup interrupt types Johan Hovold
2023-11-20 16:43 ` [PATCH 01/11] ARM: dts: qcom: sdx55: " Johan Hovold
2023-11-20 16:43 ` Johan Hovold [this message]
2023-11-20 17:26 ` [PATCH 02/11] arm64: dts: qcom: sa8775p: " Andrew Halaney
2023-11-20 16:43 ` [PATCH 03/11] arm64: dts: qcom: sc7180: " Johan Hovold
2023-11-20 16:43 ` [PATCH 04/11] arm64: dts: qcom: sc7280: fix usb_1 " Johan Hovold
2023-11-20 17:58 ` Krzysztof Kozlowski
2023-11-20 16:43 ` [PATCH 05/11] arm64: dts: qcom: sc7280: fix usb_2 " Johan Hovold
2023-11-20 16:43 ` [PATCH 06/11] arm64: dts: qcom: sc8180x: fix USB " Johan Hovold
2023-11-20 16:43 ` [PATCH 07/11] arm64: dts: qcom: sdm670: " Johan Hovold
2023-11-21 2:01 ` Richard Acayan
2023-11-20 16:43 ` [PATCH 08/11] arm64: dts: qcom: sdm845: " Johan Hovold
2023-11-20 16:43 ` [PATCH 09/11] arm64: dts: qcom: sm6375: " Johan Hovold
2023-11-20 16:43 ` [PATCH 10/11] arm64: dts: qcom: sm8150: " Johan Hovold
2023-11-23 2:16 ` Jack Pham
2023-11-20 16:43 ` [PATCH 11/11] arm64: dts: qcom: sm8550: " Johan Hovold
2023-11-20 16:53 ` Abel Vesa
2023-12-08 14:55 ` (subset) [PATCH 00/11] ARM/arm64: dts: qcom: " Bjorn Andersson
2023-12-11 16:39 ` Johan Hovold
2023-12-12 9:30 ` Krishna Kurapati PSSNV
2023-12-13 17:38 ` Johan Hovold
2023-12-13 18:39 ` Konrad Dybcio
2023-12-14 7:49 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231120164331.8116-3-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_shazhuss@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.