From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:906:b00f:b0:9d0:bf65:29fa with SMTP id v15csp64952ejy; Mon, 20 Nov 2023 13:34:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IEeOb2w7fl5Av0Mz4OFv0/USH4p6Q6IbqaKcF05fhizjgBXCUp5xYN5+POtE0cO+hU0tx8R X-Received: by 2002:a05:6214:d0d:b0:677:fba7:4f3a with SMTP id 13-20020a0562140d0d00b00677fba74f3amr9256709qvh.1.1700516079897; Mon, 20 Nov 2023 13:34:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700516079; cv=none; d=google.com; s=arc-20160816; b=BOKRJbNlXLqWeWJFvQ/g0TBn/URwXr3CYpsipfPQ1tEXu5HL4/ITQUD/0/IcikbHhW bU/BIxcyfCv5wfJkBRj3T2vlHY/BFKtakdvh6LdPHI/iAtExluUpVD98yDFuJer/Z1RY 9GbDvkX3dweXb8QWBSDB7EmiS+MPXq/PYBsW6yOrXzvLx9U3hbH1nwsphFFbVghph02a 65C0M4JcyPhRvCFhx8PWCjYTB7TLAKpyTiAzwLvIeaiyTFTMw/k5tXk6yaiI1t32WciX sWnL7YgjB5Z+SOjB6f+EHfkMYDFk988wMT9NzFJls5e5ez7QkHr7uzb1IdAvQahvLZSM tJgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WK6ixy1lWz865bxFpaXwaNdgjrdvugwCVDt1SZLip8M=; fh=toXMQ9nuJ3L4CLQ8EKaTQ8L/ltDlD3GauRZSJpgYVzU=; b=f8qF7AI3YgcxoYWg/TWvqCF9d+x/+LTRwL8xckZm57fwWme9ctg4YwmCtn8YRvpIPf cFRZfCvzqFPhm15rfhBN43QCue6FgueepIKNu1a8TL2Zj+y28aC0iQW7dc8aElWR4E8+ JT8/RDOhPiKV1SFo0bUk0oYc6KLuwEjM4waLmp8Ij9/IEJBDY4jgK/6nlm0zbpjUQigZ ZSWAtkaWYl/zSAEB6p1ElVefrGUM7XpJCFzTX3F2rgePmuGxntLX5T3CGxG8r+4Fuqva gXzdEWhe5qNfNtwcGJvM2jy8sXtXQYotw7LyZTJ3XgvhJT4N9CBpYZ2eb1arytt7qhvP ozyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OfYtZD1h; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g7-20020a05620a40c700b00767dc58f2f8si8510498qko.48.2023.11.20.13.34.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 Nov 2023 13:34:39 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OfYtZD1h; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r5BuZ-0001vH-Pu; Mon, 20 Nov 2023 16:34:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5BuP-0001Uc-Oj for qemu-arm@nongnu.org; Mon, 20 Nov 2023 16:34:23 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r5BuL-0003UP-Mg for qemu-arm@nongnu.org; Mon, 20 Nov 2023 16:34:20 -0500 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-40a4d04af5cso16952905e9.0 for ; Mon, 20 Nov 2023 13:34:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700516053; x=1701120853; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WK6ixy1lWz865bxFpaXwaNdgjrdvugwCVDt1SZLip8M=; b=OfYtZD1hwOiGO2WrGPlQ1/u8tmVk9ydezkCv6qz3eIaDsWxT+Jr1Rn8PcThTcdLttr eUS2e4fzYbP5qovO5GzP90cn19YkyE2Fxo2dwVthZwd23OXvqubyNxJW4NIuycs4N2kq LDTCcQ4L3M8ydyrsUkB9+4sRpmMeLg0+A8pbh/7Y5rXK7h/OzK7sK38h+J0rt9HqkmAf HB5s4NTVSoaDvHDCO9VUcrpP81N4FRF4w262PM8ZY/pLpRkFBPL4oWy59E6ML/21zC0L e8BXkV/wk1IeFcLqR23/8wtgYeRIA5WMV0nkMi5eDijW9l72H6xUuqZsifUHSkGGhYJi 6OmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700516053; x=1701120853; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WK6ixy1lWz865bxFpaXwaNdgjrdvugwCVDt1SZLip8M=; b=jxN3r9AGOHtjiQEgaiZet6ctKuUZ/j9dIkKt2p/9V2+V0psviUJcGj8qm8Ib1MvmEt b6lPdTHjEbmzXkJmtGzQID3pR78UPOlMM0BG3t7Wfl3eQinaZjoqjByht5ODrHLVJJx4 jqnnkNlt5t6Gv3IrPOzEH0Da+t5RYhcKoYogDOsDIvdbCvQ3yN6C0JevG4bxCqLlxO3F nr+b4yAx1g91NrWysC8xbgqQFDuw1FScVYj2vQhCBBU1hNJHYGXAaSDN3AfTZJn3S6P3 pBmw4FM6SVi1NFmsLEjwVLd05KUmOeGtQMK3Whz/0cSxPYnT+ZC+FNIoUemUTqmll5wt 1TWQ== X-Gm-Message-State: AOJu0YxV7Q9Zxkm9ujLb4J6VAqdYbVoEn2kQk7AirGdwIjfQypr8lhIX Aw2U1WO51vg2VWTIZGGGEUJdnQ== X-Received: by 2002:a05:600c:3b05:b0:408:5a1c:9de7 with SMTP id m5-20020a05600c3b0500b004085a1c9de7mr7663702wms.7.1700516053245; Mon, 20 Nov 2023 13:34:13 -0800 (PST) Received: from m1x-phil.lan ([176.176.181.190]) by smtp.gmail.com with ESMTPSA id a3-20020a05600c348300b0040a5e69482esm19352313wmq.11.2023.11.20.13.34.11 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 20 Nov 2023 13:34:12 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: David Hildenbrand , Peter Maydell , "Michael S. Tsirkin" , qemu-arm@nongnu.org, Mark Cave-Ayland , Markus Armbruster , Paolo Bonzini , Igor Mammedov , qemu-ppc@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Xu Subject: [PATCH-for-9.0 07/25] memory: Have memory_region_init_rom() handler return a boolean Date: Mon, 20 Nov 2023 22:32:41 +0100 Message-ID: <20231120213301.24349-8-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231120213301.24349-1-philmd@linaro.org> References: <20231120213301.24349-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: 5dodlottDnDU Following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), have cpu_exec_realizefn() return a boolean indicating whether an error is set or not. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/memory.h | 4 +++- system/memory.c | 6 ++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 788872e4a4..9d9798a527 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -1611,8 +1611,10 @@ bool memory_region_init_ram(MemoryRegion *mr, * must be unique within any device * @size: size of the region. * @errp: pointer to Error*, to store an error if it happens. + * + * Return: true on success, else false setting @errp with error. */ -void memory_region_init_rom(MemoryRegion *mr, +bool memory_region_init_rom(MemoryRegion *mr, Object *owner, const char *name, uint64_t size, diff --git a/system/memory.c b/system/memory.c index 4142eac498..2c764947fa 100644 --- a/system/memory.c +++ b/system/memory.c @@ -3620,7 +3620,7 @@ bool memory_region_init_ram(MemoryRegion *mr, return true; } -void memory_region_init_rom(MemoryRegion *mr, +bool memory_region_init_rom(MemoryRegion *mr, Object *owner, const char *name, uint64_t size, @@ -3629,7 +3629,7 @@ void memory_region_init_rom(MemoryRegion *mr, DeviceState *owner_dev; if (!memory_region_init_rom_nomigrate(mr, owner, name, size, errp)) { - return; + return false; } /* This will assert if owner is neither NULL nor a DeviceState. * We only want the owner here for the purposes of defining a @@ -3639,6 +3639,8 @@ void memory_region_init_rom(MemoryRegion *mr, */ owner_dev = DEVICE(owner); vmstate_register_ram(mr, owner_dev); + + return true; } void memory_region_init_rom_device(MemoryRegion *mr, -- 2.41.0