From: Philipp Stanner <pstanner@redhat.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
Arnd Bergmann <arnd@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
Eric Auger <eric.auger@redhat.com>,
Kent Overstreet <kent.overstreet@gmail.com>,
Niklas Schnelle <schnelle@linux.ibm.com>,
NeilBrown <neilb@suse.de>, Philipp Stanner <pstanner@redhat.com>,
John Sanpe <sanpeqf@gmail.com>, Dave Jiang <dave.jiang@intel.com>,
Yury Norov <yury.norov@gmail.com>,
Kees Cook <keescook@chromium.org>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
David Gow <davidgow@google.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Thomas Gleixner <tglx@linutronix.de>,
"wuqiang.matt" <wuqiang.matt@bytedance.com>,
Jason Baron <jbaron@akamai.com>,
Ben Dooks <ben.dooks@codethink.co.uk>,
Danilo Krummrich <dakr@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: [PATCH 0/4] Regather scattered PCI-Code
Date: Mon, 20 Nov 2023 22:59:42 +0100 [thread overview]
Message-ID: <20231120215945.52027-2-pstanner@redhat.com> (raw)
Hi!
So it seems that since ca. 2007 the PCI code has been scattered a bit.
PCI's devres code, which is only ever used by users of the entire
PCI-subsystem anyways, resides in lib/devres.c and is guarded by an
#ifdef PCI, just as the content of lib/pci_iomap.c is.
It, thus, seems reasonable to move all of that.
As I were at it, I moved as much of the devres-specific code from pci.c
to devres.c, too. The only exceptions are four functions that are
currently difficult to move. More information about that can be read
here [1].
I noticed these scattered files while working on (new) PCI-specific
devres functions. If we can get this here merged, I'll soon send another
patch series that addresses some API-inconsistencies and could move the
devres-part of the four remaining functions.
I don't want to do that in this series as this here is only about moving
code, whereas the next series would have to actually change API
behavior.
I successfully (cross-)built this for x86, x86_64, AARCH64 and ARM
(allyesconfig). I booted a kernel with it on x86_64, with a Fedora
desktop environment as payload. The OS came up fine
I hope this is OK. If we can get it in, we'd soon have a very
consistent PCI API again.
Regards,
P.
[1] https://lore.kernel.org/all/84be1049e41283cf8a110267646320af9ffe59fe.camel@redhat.com/
Philipp Stanner (4):
lib: move pci_iomap.c to drivers/pci/
lib: move pci-specific devres code to drivers/pci/
pci: move devres code from pci.c to devres.c
lib/iomap.c: improve comment about pci anomaly
drivers/pci/Kconfig | 3 +
drivers/pci/Makefile | 3 +-
drivers/pci/devres.c | 449 +++++++++++++++++++++++++
lib/pci_iomap.c => drivers/pci/iomap.c | 3 -
drivers/pci/pci.c | 249 --------------
drivers/pci/pci.h | 24 ++
lib/Kconfig | 3 -
lib/Makefile | 1 -
lib/devres.c | 208 +-----------
lib/iomap.c | 13 +-
10 files changed, 490 insertions(+), 466 deletions(-)
create mode 100644 drivers/pci/devres.c
rename lib/pci_iomap.c => drivers/pci/iomap.c (99%)
--
2.41.0
next reply other threads:[~2023-11-20 22:00 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 21:59 Philipp Stanner [this message]
2023-11-20 21:59 ` [PATCH 1/4] lib: move pci_iomap.c to drivers/pci/ Philipp Stanner
2023-11-21 4:20 ` kernel test robot
2023-11-21 10:44 ` Philipp Stanner
2023-11-21 6:48 ` kernel test robot
2023-11-21 7:22 ` Arnd Bergmann
2023-11-21 7:20 ` kernel test robot
2023-11-21 7:45 ` kernel test robot
2023-11-21 7:58 ` kernel test robot
2023-11-21 8:46 ` kernel test robot
2023-11-21 10:44 ` kernel test robot
2023-11-21 10:44 ` kernel test robot
2023-11-21 13:14 ` kernel test robot
2023-11-21 14:38 ` kernel test robot
2023-11-21 15:04 ` kernel test robot
2023-11-21 15:40 ` kernel test robot
2023-11-21 15:56 ` kernel test robot
2023-11-22 1:51 ` Liu, Yujie
2023-11-22 8:15 ` Philipp Stanner
2023-11-23 6:42 ` Yujie Liu
2023-11-22 16:28 ` kernel test robot
2023-11-20 21:59 ` [PATCH 2/4] lib: move pci-specific devres code " Philipp Stanner
2023-11-21 7:29 ` Arnd Bergmann
2023-11-21 8:00 ` Philipp Stanner
2023-11-21 10:10 ` Arnd Bergmann
2023-11-20 21:59 ` [PATCH 3/4] pci: move devres code from pci.c to devres.c Philipp Stanner
2023-11-21 10:17 ` Arnd Bergmann
2023-11-21 10:36 ` Philipp Stanner
2023-11-20 21:59 ` [PATCH 4/4] lib/iomap.c: improve comment about pci anomaly Philipp Stanner
2023-11-21 10:03 ` Arnd Bergmann
2023-11-21 14:38 ` Philipp Stanner
2023-11-21 14:41 ` Arnd Bergmann
2023-11-24 19:08 ` Danilo Krummrich
2023-11-29 10:16 ` Philipp Stanner
2023-11-29 17:37 ` Arnd Bergmann
2023-11-29 12:40 ` Philipp Stanner
2023-11-29 16:52 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231120215945.52027-2-pstanner@redhat.com \
--to=pstanner@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@kernel.org \
--cc=ben.dooks@codethink.co.uk \
--cc=bhelgaas@google.com \
--cc=dakr@redhat.com \
--cc=dave.jiang@intel.com \
--cc=davidgow@google.com \
--cc=eric.auger@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jbaron@akamai.com \
--cc=jgg@ziepe.ca \
--cc=keescook@chromium.org \
--cc=kent.overstreet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=neilb@suse.de \
--cc=rdunlap@infradead.org \
--cc=sanpeqf@gmail.com \
--cc=schnelle@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=wuqiang.matt@bytedance.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.