From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <lkp@intel.com>
Cc: <andrii@kernel.org>, <ast@kernel.org>, <bpf@vger.kernel.org>,
<daniel@iogearbox.net>, <davem@davemloft.net>,
<dsahern@kernel.org>, <edumazet@google.com>, <haoluo@google.com>,
<john.fastabend@gmail.com>, <jolsa@kernel.org>,
<kpsingh@kernel.org>, <kuba@kernel.org>, <kuniyu@amazon.com>,
<martin.lau@linux.dev>, <mykolal@fb.com>,
<netdev@vger.kernel.org>, <oe-kbuild-all@lists.linux.dev>,
<pabeni@redhat.com>, <sdf@google.com>, <song@kernel.org>,
<yonghong.song@linux.dev>
Subject: Re: [PATCH v2 bpf-next 10/11] bpf: tcp: Support arbitrary SYN Cookie.
Date: Mon, 20 Nov 2023 21:18:57 -0800 [thread overview]
Message-ID: <20231121051857.89600-1-kuniyu@amazon.com> (raw)
In-Reply-To: <202311211229.8GAmfTPp-lkp@intel.com>
From: kernel test robot <lkp@intel.com>
Date: Tue, 21 Nov 2023 13:06:23 +0800
> Hi Kuniyuki,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on bpf-next/master]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/tcp-Clean-up-reverse-xmas-tree-in-cookie_v-46-_check/20231121-063036
> base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
> patch link: https://lore.kernel.org/r/20231120222341.54776-11-kuniyu%40amazon.com
> patch subject: [PATCH v2 bpf-next 10/11] bpf: tcp: Support arbitrary SYN Cookie.
> config: arm-randconfig-001-20231121 (https://download.01.org/0day-ci/archive/20231121/202311211229.8GAmfTPp-lkp@intel.com/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231121/202311211229.8GAmfTPp-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202311211229.8GAmfTPp-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> >> net/core/filter.c:11812:48: warning: 'struct tcp_cookie_attributes' declared inside parameter list will not be visible outside of this definition or declaration
> 11812 | struct tcp_cookie_attributes *attr,
> | ^~~~~~~~~~~~~~~~~~~~~
> net/core/filter.c: In function 'bpf_sk_assign_tcp_reqsk':
> net/core/filter.c:11821:31: error: invalid application of 'sizeof' to incomplete type 'struct tcp_cookie_attributes'
> 11821 | if (attr__sz != sizeof(*attr))
> | ^
> net/core/filter.c:11851:17: error: invalid use of undefined type 'struct tcp_cookie_attributes'
> 11851 | if (attr->tcp_opt.mss_clamp < min_mss) {
> | ^~
> net/core/filter.c:11856:17: error: invalid use of undefined type 'struct tcp_cookie_attributes'
> 11856 | if (attr->tcp_opt.wscale_ok &&
> | ^~
> net/core/filter.c:11857:17: error: invalid use of undefined type 'struct tcp_cookie_attributes'
> 11857 | attr->tcp_opt.snd_wscale > TCP_MAX_WSCALE) {
> | ^~
> net/core/filter.c:11875:24: error: invalid use of undefined type 'struct tcp_cookie_attributes'
> 11875 | req->mss = attr->tcp_opt.mss_clamp;
> | ^~
> net/core/filter.c:11877:32: error: invalid use of undefined type 'struct tcp_cookie_attributes'
> 11877 | ireq->snd_wscale = attr->tcp_opt.snd_wscale;
> | ^~
> net/core/filter.c:11878:31: error: invalid use of undefined type 'struct tcp_cookie_attributes'
> 11878 | ireq->wscale_ok = attr->tcp_opt.wscale_ok;
> | ^~
> net/core/filter.c:11879:31: error: invalid use of undefined type 'struct tcp_cookie_attributes'
> 11879 | ireq->tstamp_ok = attr->tcp_opt.tstamp_ok;
> | ^~
> net/core/filter.c:11880:29: error: invalid use of undefined type 'struct tcp_cookie_attributes'
> 11880 | ireq->sack_ok = attr->tcp_opt.sack_ok;
> | ^~
> net/core/filter.c:11881:28: error: invalid use of undefined type 'struct tcp_cookie_attributes'
> 11881 | ireq->ecn_ok = attr->ecn_ok;
> | ^~
> net/core/filter.c:11883:33: error: invalid use of undefined type 'struct tcp_cookie_attributes'
> 11883 | treq->req_usec_ts = attr->usec_ts_ok;
> | ^~
>
>
> vim +11812 net/core/filter.c
>
> 11810
> 11811 __bpf_kfunc int bpf_sk_assign_tcp_reqsk(struct sk_buff *skb, struct sock *sk,
> 11812 struct tcp_cookie_attributes *attr,
> 11813 int attr__sz)
> 11814 {
bpf_sk_assign_tcp_reqsk() needs to be guarded by CONFIG_SYN_COOKIE.
Will fix in v3.
Thanks!
---8<---
diff --git a/net/core/filter.c b/net/core/filter.c
index 58b567aaf577..7beba469e8a7 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -11808,6 +11808,7 @@ __bpf_kfunc int bpf_sock_addr_set_sun_path(struct bpf_sock_addr_kern *sa_kern,
return 0;
}
+#if IS_ENABLED(CONFIG_SYN_COOKIE)
__bpf_kfunc int bpf_sk_assign_tcp_reqsk(struct sk_buff *skb, struct sock *sk,
struct tcp_cookie_attributes *attr,
int attr__sz)
@@ -11888,6 +11889,7 @@ __bpf_kfunc int bpf_sk_assign_tcp_reqsk(struct sk_buff *skb, struct sock *sk,
return 0;
}
+#endif
__bpf_kfunc_end_defs();
---8<---
next prev parent reply other threads:[~2023-11-21 5:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 22:23 [PATCH v2 bpf-next 00/11] bpf: tcp: Support arbitrary SYN Cookie at TC Kuniyuki Iwashima
2023-11-20 22:23 ` [PATCH v2 bpf-next 01/11] tcp: Clean up reverse xmas tree in cookie_v[46]_check() Kuniyuki Iwashima
2023-11-20 22:23 ` [PATCH v2 bpf-next 02/11] tcp: Cache sock_net(sk) " Kuniyuki Iwashima
2023-11-20 22:23 ` [PATCH v2 bpf-next 03/11] tcp: Clean up goto labels " Kuniyuki Iwashima
2023-11-20 22:23 ` [PATCH v2 bpf-next 04/11] tcp: Don't pass cookie to __cookie_v[46]_check() Kuniyuki Iwashima
2023-11-20 22:23 ` [PATCH v2 bpf-next 05/11] tcp: Don't initialise tp->tsoffset in tcp_get_cookie_sock() Kuniyuki Iwashima
2023-11-20 22:23 ` [PATCH v2 bpf-next 06/11] tcp: Move TCP-AO bits from cookie_v[46]_check() to tcp_ao_syncookie() Kuniyuki Iwashima
2023-11-20 22:23 ` [PATCH v2 bpf-next 07/11] tcp: Factorise cookie req initialisation Kuniyuki Iwashima
2023-11-20 22:23 ` [PATCH v2 bpf-next 08/11] tcp: Factorise non-BPF SYN Cookie handling Kuniyuki Iwashima
2023-11-20 22:23 ` [PATCH v2 bpf-next 09/11] bpf: tcp: Handle BPF SYN Cookie in cookie_v[46]_check() Kuniyuki Iwashima
2023-11-20 22:23 ` [PATCH v2 bpf-next 10/11] bpf: tcp: Support arbitrary SYN Cookie Kuniyuki Iwashima
2023-11-21 5:06 ` kernel test robot
2023-11-21 5:18 ` Kuniyuki Iwashima [this message]
2023-11-21 5:17 ` kernel test robot
2023-11-21 5:37 ` Kuniyuki Iwashima
2023-11-21 5:21 ` kernel test robot
2023-11-20 22:23 ` [PATCH v2 bpf-next 11/11] selftest: bpf: Test bpf_sk_assign_tcp_reqsk() Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121051857.89600-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=lkp@intel.com \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.