From: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
To: gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Subject: [PATCH 4/6] tty: jsm: remove unused struct jsm_board members
Date: Tue, 21 Nov 2023 11:36:24 +0100 [thread overview]
Message-ID: <20231121103626.17772-5-jirislaby@kernel.org> (raw)
In-Reply-To: <20231121103626.17772-1-jirislaby@kernel.org>
clang-struct [1] found jsm_board::type and ::jsm_board_entry unused.
::jsm_board_entry is unused since 614a7d6a76b7 ("fix up newly added jsm driver")
::type was never used as far as I can tell. Even when the driver was
introduced in the pre-git era.
Remove them both.
[1] https://github.com/jirislaby/clang-struct
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
---
drivers/tty/serial/jsm/jsm.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/tty/serial/jsm/jsm.h b/drivers/tty/serial/jsm/jsm.h
index 08a42f045ec8..df55e5dc5afc 100644
--- a/drivers/tty/serial/jsm/jsm.h
+++ b/drivers/tty/serial/jsm/jsm.h
@@ -125,7 +125,6 @@ struct jsm_board
{
int boardnum; /* Board number: 0-32 */
- int type; /* Type of board */
u8 rev; /* PCI revision ID */
struct pci_dev *pci_dev;
u32 maxports; /* MAX ports this board can handle */
@@ -153,8 +152,6 @@ struct jsm_board
u32 bd_dividend; /* Board/UARTs specific dividend */
struct board_ops *bd_ops;
-
- struct list_head jsm_board_entry;
};
/************************************************************************
--
2.42.1
next prev parent reply other threads:[~2023-11-21 10:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 10:36 [PATCH 0/6] tty: remove unused structure members Jiri Slaby (SUSE)
2023-11-21 10:36 ` [PATCH 1/6] tty: con3215: drop raw3215_info::ubuffer Jiri Slaby (SUSE)
2023-11-21 16:39 ` Alexander Gordeev
2023-11-21 10:36 ` [PATCH 2/6] tty: ipwireless: remove unused ipw_dev::attribute_memory Jiri Slaby (SUSE)
2023-11-21 12:18 ` Jiri Kosina
2023-11-21 18:30 ` David Sterba
2023-11-21 10:36 ` [PATCH 3/6] tty: jsm: remove unused members from struct board_ops Jiri Slaby (SUSE)
2023-11-21 10:36 ` Jiri Slaby (SUSE) [this message]
2023-11-21 10:36 ` [PATCH 5/6] tty: rp2: remove unused rp2_uart_port::ignore_rx Jiri Slaby (SUSE)
2023-11-21 10:36 ` [PATCH 6/6] tty: serial_cs: remove unused struct serial_cfg_mem Jiri Slaby (SUSE)
2023-11-21 15:35 ` [PATCH 0/6] tty: remove unused structure members Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121103626.17772-5-jirislaby@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.