From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C31058113 for ; Tue, 21 Nov 2023 15:33:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Sd5xMDKX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C23E7C433C8; Tue, 21 Nov 2023 15:33:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700580787; bh=XGyoaHeSQMXUdK/oz16TGCV+JeLwZhhXo+pE++5TlmU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Sd5xMDKXxYhjEWideaWWRGi9f7ZQbdnzpH+ctwSw1NEOw9YDnWCeqAOHbnBCkAhWQ wsmzPhVLwfI29xgyO4usvTjySzF3XAt4uuTeJ51lCccwxZ6Ea/ec9VeA0jJoUdJ5Dq FDB5dXp28cKPIz/YiWcksEjHe/yoN+UETo0oDnBQjE9NVuZW7i7yrJjoKgEbChM8qn ZOriZ3sTUDjX/fMDyd6/E8m2W4P4cKj4hE8lCxHGaq0x5zLdmG6vTVc3GraMCwA9Lo 4pWkhU5VtycrWX7avJ9ZXN3+xpFz2EnuVkd5zLAMJBgk+YpRlwiML6B2JkUkYBOpkD +YP3y1J6MyMaQ== Date: Tue, 21 Nov 2023 15:33:02 +0000 From: Lee Jones To: Naresh Solanki Cc: Pavel Machek , Patrick Rudolph , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [RESEND PATCH v3] leds: max5970: Add support for max5970 Message-ID: <20231121153302.GD173820@google.com> References: <20230914114521.1491390-1-naresh.solanki@9elements.com> <20230920130528.GG13143@google.com> <20230921103156.GB3449785@google.com> <20231117121531.GC137434@google.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, 20 Nov 2023, Naresh Solanki wrote: > Hi > > On Fri, 17 Nov 2023 at 17:45, Lee Jones wrote: > > > > On Thu, 09 Nov 2023, Naresh Solanki wrote: > > > > > Hey Lee, > > > > > > Is there anything specific you'd suggest changing in the current > > > patchset, or are we good to proceed? > > > > What do you mean by proceed? > > > > You are good to make changes and submit a subsequent version. > > > > Not entirely sure what you're asking. > > As a follow up on previous discussion regarding use of DEFER on probe > if regmap isn't initialized, the implementation was based on other similar > drivers & hence it was retained although its not needed due to dependencies. > > I'm not entirely sure to keep the regmap check or make another > patch revision with regmap check removed ? You tell me. You should understand the device you're attempting to support along with the code you're authoring and its subsequent implications. If you don't know what a section of code does or whether/why it's required, why did you write it? -- Lee Jones [李琼斯]