All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.com>,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>,
	Naohiro Aota <Naohiro.Aota@wdc.com>
Subject: Re: [PATCH 0/5] btrfs: zoned: remove extent_buffer redirtying
Date: Tue, 21 Nov 2023 16:01:41 -0500	[thread overview]
Message-ID: <20231121210141.GB1675377@perftesting> (raw)
In-Reply-To: <20231121-josef-generic-163-v1-0-049e37185841@wdc.com>

On Tue, Nov 21, 2023 at 08:32:29AM -0800, Johannes Thumshirn wrote:
> Since the beginning of zoned mode, I've promised Josef to get rid of the
> extent_buffer redirtying, but never actually got around to doing so.
> 
> Then 2 weeks ago our CI has hit an ASSERT() in this area and I started to look
> into it again. After some discussion with Christoph we came to the conclusion
> to finally take the time and get rid of the extent_buffer redirtying once and
> for all.
> 
> Patch one renames EXTENT_BUFFER_NO_CHECK into EXTENT_BUFFER_CANCELLED, because
> this fits the new model somewhat better.
> 
> Number two sets the cancel bit instead of clearing the dirty bit from a zoned
> extent_buffer.
> 
> Number three removes the last remaining bits of btrfs_redirty_list_add().
> 
> The last two patches in this series are just trivial cleanups I came across
> while looking at the code.
>

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef 

      parent reply	other threads:[~2023-11-21 21:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-21 16:32 [PATCH 0/5] btrfs: zoned: remove extent_buffer redirtying Johannes Thumshirn
2023-11-21 16:32 ` [PATCH 1/5] btrfs: rename EXTENT_BUFFER_NO_CHECK to EXTENT_BUFFER_CANCELLED Johannes Thumshirn
2023-11-21 17:02   ` Christoph Hellwig
2023-11-22 13:20   ` David Sterba
2023-11-22 13:57     ` Johannes Thumshirn
2023-11-21 16:32 ` [PATCH 2/5] btrfs: zoned: don't clear dirty flag of extent buffer Johannes Thumshirn
2023-11-21 17:03   ` Christoph Hellwig
2023-11-21 16:32 ` [PATCH 3/5] btrfs: remove now unneeded btrfs_redirty_list_add Johannes Thumshirn
2023-11-21 17:03   ` Christoph Hellwig
2023-11-21 16:32 ` [PATCH 4/5] btrfs: use memset_page instead of opencoding it Johannes Thumshirn
2023-11-21 17:04   ` Christoph Hellwig
2023-11-21 16:32 ` [PATCH 5/5] btrfs: reflow btrfs_free_tree_block Johannes Thumshirn
2023-11-21 17:04   ` Christoph Hellwig
2023-11-21 21:01 ` Josef Bacik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231121210141.GB1675377@perftesting \
    --to=josef@toxicpanda.com \
    --cc=Naohiro.Aota@wdc.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=hch@lst.de \
    --cc=johannes.thumshirn@wdc.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.